Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2022-01-28 Thread Iain Sandoe
> On 25 Jan 2022, at 15:27, David Edelsohn wrote: > > This patch broke bootstrap on AIX. It may have broken Darwin. As you anticipated, it did : fixed as below (tested on powerpc-darwin9, pushed to master). thanks Iain [pushed] Darwin, PPC: Fix bootstrap after GLIBC version changes. A

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2022-01-25 Thread David Edelsohn via Gcc-patches
This patch broke bootstrap on AIX. It may have broken Darwin. I have applied the following patch. AIX doesn't need to distinguish between different Linux libc implementations. Bootstrapped on powerpc-ibm-aix7.2.3.0 Thanks, David aix: AIX is not GLIBC. A recent patch added tests for

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2022-01-24 Thread Richard Biener via Gcc-patches
On Mon, 24 Jan 2022, Jakub Jelinek wrote: > On Sat, Jan 22, 2022 at 07:03:48PM +0100, Jakub Jelinek via Gcc-patches wrote: > > On Sat, Jan 22, 2022 at 01:16:38PM +0100, Jakub Jelinek via Gcc-patches > > wrote: > > > Actually, I suspect we either need something like following patch, > > > or need

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2022-01-24 Thread Jakub Jelinek via Gcc-patches
On Sat, Jan 22, 2022 at 07:03:48PM +0100, Jakub Jelinek via Gcc-patches wrote: > On Sat, Jan 22, 2022 at 01:16:38PM +0100, Jakub Jelinek via Gcc-patches wrote: > > Actually, I suspect we either need something like following patch, > > or need to change

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2022-01-23 Thread Jakub Jelinek via Gcc-patches
On Sun, Jan 23, 2022 at 10:06:24AM +0100, Uros Bizjak wrote: > > 2022-01-22 Jakub Jelinek > > > > * config/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P, > > OPTION_BIONIC_P, OPTION_MUSL_P): Define. > > (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine > >

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2022-01-23 Thread Uros Bizjak via Gcc-patches
On Sat, Jan 22, 2022 at 7:04 PM Jakub Jelinek via Gcc-patches wrote: > > On Sat, Jan 22, 2022 at 01:16:38PM +0100, Jakub Jelinek via Gcc-patches wrote: > > Actually, I suspect we either need something like following patch, > > or need to change gcc/config/{linux,rs6000/linux{,64},alpha/linux}.h >

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2022-01-22 Thread Jakub Jelinek via Gcc-patches
On Sat, Jan 22, 2022 at 01:16:38PM +0100, Jakub Jelinek via Gcc-patches wrote: > Actually, I suspect we either need something like following patch, > or need to change gcc/config/{linux,rs6000/linux{,64},alpha/linux}.h > so that next to those OPTION_GLIBC etc. macros it also defines versions > of

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2022-01-22 Thread Jakub Jelinek via Gcc-patches
On Sat, Jan 22, 2022 at 10:32:21AM +0100, Martin Liška wrote: > I've just noticed the patch broke a few cross compilers: > > s390x-ibm-tpf: > > /home/marxin/buildworker/zen2-cross-compilers/build/gcc/common/config/s390/s390-common.cc: > In function ‘bool s390_supports_split_stack(bool,

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2022-01-22 Thread Jakub Jelinek via Gcc-patches
On Sat, Jan 22, 2022 at 10:32:21AM +0100, Martin Liška wrote: > Hello. > > I've just noticed the patch broke a few cross compilers: > > s390x-ibm-tpf: > > /home/marxin/buildworker/zen2-cross-compilers/build/gcc/common/config/s390/s390-common.cc: > In function ‘bool

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2022-01-22 Thread Martin Liška
Hello. I've just noticed the patch broke a few cross compilers: s390x-ibm-tpf: /home/marxin/buildworker/zen2-cross-compilers/build/gcc/common/config/s390/s390-common.cc: In function ‘bool s390_supports_split_stack(bool, gcc_options*)’:

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2021-12-18 Thread Andrew Pinski via Gcc-patches
On Sat, Dec 18, 2021 at 3:13 AM Sören Tempel wrote: > > Andrew Pinski wrote: > > I think it should check OPTION_MUSL at runtime instead of > > TARGET_GLIBC_MAJOR at compile time. > > or rather opts->x_linux_libc == LIBC_MUSL > > The others should be done similarly too. > > Thanks for pointing

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2021-12-18 Thread Sören Tempel via Gcc-patches
Andrew Pinski wrote: > I think it should check OPTION_MUSL at runtime instead of > TARGET_GLIBC_MAJOR at compile time. > or rather opts->x_linux_libc == LIBC_MUSL > The others should be done similarly too. Thanks for pointing this out, I wasn't aware of OPTION_MUSL and OPTION_GLIBC. However, I

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2021-12-18 Thread Andrew Pinski via Gcc-patches
On Sat, Dec 18, 2021 at 2:44 AM soeren--- via Gcc-patches wrote: > > From: Sören Tempel > > The -fsplit-stack option requires the pthread_t TCB definition in the > libc to provide certain struct fields at specific hardcoded offsets. As > far as I know, only glibc provides these fields at the

[PATCH] Disable -fsplit-stack support on non-glibc targets

2021-12-18 Thread soeren--- via Gcc-patches
From: Sören Tempel The -fsplit-stack option requires the pthread_t TCB definition in the libc to provide certain struct fields at specific hardcoded offsets. As far as I know, only glibc provides these fields at the required offsets. Most notably, musl libc does not have these fields. However,