Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

On Thu, 15 Feb 2024, Florian Weimer wrote: >>> +GCC no longer casts all pointer types to all other pointer types. >> >> Do you mean it no longer does so implicitly, or not at all? That is, >> there are now cases where even an explicit cast such as >> >> foo_p = (foo_type*) bar_p >> >> no longer

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

On Thu, 15 Feb 2024, Florian Weimer wrote: >> Naive questions: Can definitions really be prototypes (in C)? > Yes, I think so: definitions can be declarations, and function > prototypes are declarations. The standard uses the phrase “function > definition that does not include a function

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

* Gerald Pfeifer: > On Fri, 2 Feb 2024, Florian Weimer wrote: >> +Certain warnings are now errors > > That's quite a nice description, thank you, Florian! > >> +The initial ISO C standard and its 1999 revision removed support for > > May I suggest to wrap paragraphs in ...? Not strictly necessary

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

* Gerald Pfeifer: > On Fri, 2 Feb 2024, Florian Weimer wrote: >> htdocs/gcc-14/porting_to.html | 465 >> ++ >> 1 file changed, 465 insertions(+) >> + >> +Using pointers as integers and vice versa >> (-Werror=int-conversion) > >> +It makes sense to

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

* Gerald Pfeifer: >> This mostly happens in function definitions >> +that are not prototypes > > Naive questions: Can definitions really be prototypes (in C)? Yes, I think so: definitions can be declarations, and function prototypes are declarations. The standard uses the phrase “function

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

Florian Weimer writes: > * Sam James: > >> It's fine if you leave this out, but consider mentioning the common >> pitfall of autoconf projects not including config.h consistently before >> all inclues. We could also mention AC_USE_SYSTEM_EXTENSIONS. > > I added: > > “ > Alternatively, projects

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

* Sam James: > It's fine if you leave this out, but consider mentioning the common > pitfall of autoconf projects not including config.h consistently before > all inclues. We could also mention AC_USE_SYSTEM_EXTENSIONS. I added: “ Alternatively, projects using using Autoconf could enable

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

* Jonathan Wakely: >>+To fix the remaining int-conversions issues, add casts >>+to an appropriate pointer or integer type. On GNU systems, the >>+standard (but generally optional) types > > I know what you mean here, but I'm not sure the parenthesis adds > clarity for anybody who doesn't already

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

Hi Florian, that's been quite a bit. Thank you for putting this together so comprehensively and thoughtfully, with examples and background! Note many of my points are suggestions or questions, especially if phrased as questions or using maybe or similar, so for your consideration. On Fri, 2

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

On Fri, 2 Feb 2024, Florian Weimer wrote: > +Certain warnings are now errors That's quite a nice description, thank you, Florian! > +The initial ISO C standard and its 1999 revision removed support for May I suggest to wrap paragraphs in ...? Not strictly necessary any more, now that we

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

Florian Weimer writes: > --- > htdocs/gcc-14/porting_to.html | 465 > ++ > 1 file changed, 465 insertions(+) > Can't approve but LGTM. Thank you for being so thorough - it'll be helpful when showing upstreams. > diff --git

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

On 02/02/24 17:59 +0100, Florian Weimer wrote: --- htdocs/gcc-14/porting_to.html | 465 ++ 1 file changed, 465 insertions(+) base-commit: 15056edbb60e24a6410d9b75f7386de28ea60bc1 diff --git a/htdocs/gcc-14/porting_to.html b/htdocs/gcc-14/porting_to.html

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

On 02/02/24 17:59 +0100, Florian Weimer wrote: --- htdocs/gcc-14/porting_to.html | 465 ++ 1 file changed, 465 insertions(+) base-commit: 15056edbb60e24a6410d9b75f7386de28ea60bc1 diff --git a/htdocs/gcc-14/porting_to.html b/htdocs/gcc-14/porting_to.html

[PATCH] Notes on the warnings-as-errors change in GCC 14

--- htdocs/gcc-14/porting_to.html | 465 ++ 1 file changed, 465 insertions(+) diff --git a/htdocs/gcc-14/porting_to.html b/htdocs/gcc-14/porting_to.html index 3e4cedc3..4c8f9c8f 100644 --- a/htdocs/gcc-14/porting_to.html +++ b/htdocs/gcc-14/porting_to.html