Re: Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG.

2022-12-28 Thread 钟居哲
ichard Sandiford Date: 2022-12-28 19:47 To: Jeff Law via Gcc-patches CC: juzhe.zhong; Jeff Law; kito.cheng\@gmail.com; palmer\@dabbelt.com Subject: Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG. Jeff Law via Gcc-patches writes: > On 12/27/22 16:11, juzhe.zhong wrote: >

Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG.

2022-12-28 Thread Richard Sandiford via Gcc-patches
Jeff Law via Gcc-patches writes: > On 12/27/22 16:11, juzhe.zhong wrote: >> You mean only change to this form you suggested in this patch? Since in >> all other places of this PASS,I use RTL_SSA framework to iterate >> instructions and blocks. I use RTL_SSA framework to iterate blocks here >>

Re: Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG.

2022-12-27 Thread 钟居哲
Hi, I fixed that form like you said: https://gcc.gnu.org/pipermail/gcc-patches/2022-December/609217.html juzhe.zh...@rivai.ai From: Jeff Law Date: 2022-12-28 09:11 To: 钟居哲 CC: gcc-patches; kito.cheng; palmer Subject: Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG

Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG.

2022-12-27 Thread Kito Cheng via Gcc-patches
oops, I just committed this yesterday, anyway, I think we can always have further patches to improve that. On Wed, Dec 28, 2022 at 9:12 AM Jeff Law via Gcc-patches wrote: > > > > On 12/27/22 17:24, 钟居哲 wrote: > > OK, I will change that after I finished my current work. > Sounds good. Thanks. >

Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG.

2022-12-27 Thread Jeff Law via Gcc-patches
On 12/27/22 17:24, 钟居哲 wrote: OK, I will change that after I finished my current work. Sounds good. Thanks. Jeff

Re: Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG.

2022-12-27 Thread 钟居哲
OK, I will change that after I finished my current work. juzhe.zh...@rivai.ai From: Jeff Law Date: 2022-12-28 08:06 To: juzhe.zhong CC: gcc-patches@gcc.gnu.org; kito.ch...@gmail.com; pal...@dabbelt.com Subject: Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG. On 12/27/22

Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG.

2022-12-27 Thread Jeff Law via Gcc-patches
On 12/27/22 16:11, juzhe.zhong wrote: You mean only change to this form you suggested in this patch? Since in all other places of this PASS,I use RTL_SSA framework to iterate instructions and blocks. I use RTL_SSA framework to iterate blocks here to make codes look more consistent even

Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG.

2022-12-27 Thread Jeff Law via Gcc-patches
On 12/23/22 20:08, juzhe.zh...@rivai.ai wrote: From: Ju-Zhe Zhong This patch is to fix issue of visiting non-existing block of CFG. Since blocks index of CFG in GCC are not always contiguous, we will potentially visit a gap block which is no existing in the current CFG. This patch can

[PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG.

2022-12-23 Thread juzhe . zhong
From: Ju-Zhe Zhong This patch is to fix issue of visiting non-existing block of CFG. Since blocks index of CFG in GCC are not always contiguous, we will potentially visit a gap block which is no existing in the current CFG. This patch can avoid visiting non existing block in CFG. I noticed