Re: [PATCH] Remove VRP threader passes in exchange for better threading pre-VRP.

2021-10-29 Thread Aldy Hernandez via Gcc-patches
Yes as well as anything ASSERT related in the forward threader. That'll be a follow-up patch. Aldy On Fri, Oct 29, 2021, 22:58 David Malcolm wrote: > On Thu, 2021-10-28 at 17:24 +0200, Aldy Hernandez via Gcc-patches > wrote: > > [...snip...] > > > gcc/ChangeLog: > > > > * passes.def:

Re: [PATCH] Remove VRP threader passes in exchange for better threading pre-VRP.

2021-10-29 Thread David Malcolm via Gcc-patches
On Thu, 2021-10-28 at 17:24 +0200, Aldy Hernandez via Gcc-patches wrote: [...snip...] > gcc/ChangeLog: > > * passes.def: Replace the pass_thread_jumps before VRP* with > pass_thread_jumps_full.  Remove all pass_vrp_threader > instances. Given that you're deleting all

Re: [PATCH] Remove VRP threader passes in exchange for better threading pre-VRP.

2021-10-29 Thread Aldy Hernandez via Gcc-patches
On Fri, Oct 29, 2021 at 10:10 AM Richard Biener wrote: > > On Fri, Oct 29, 2021 at 10:06 AM Aldy Hernandez wrote: > > > > On Fri, Oct 29, 2021 at 9:30 AM Richard Biener > > wrote: > > > > > Btw, in case the "fully resolving" mode is slower than not fully resolving > > > please consider gating

Re: [PATCH] Remove VRP threader passes in exchange for better threading pre-VRP.

2021-10-29 Thread Aldy Hernandez via Gcc-patches
On Fri, Oct 29, 2021 at 10:10 AM Richard Biener wrote: > > On Fri, Oct 29, 2021 at 10:06 AM Aldy Hernandez wrote: > > > > On Fri, Oct 29, 2021 at 9:30 AM Richard Biener > > wrote: > > > > > Btw, in case the "fully resolving" mode is slower than not fully resolving > > > please consider gating

Re: [PATCH] Remove VRP threader passes in exchange for better threading pre-VRP.

2021-10-29 Thread Richard Biener via Gcc-patches
On Fri, Oct 29, 2021 at 10:06 AM Aldy Hernandez wrote: > > On Fri, Oct 29, 2021 at 9:30 AM Richard Biener > wrote: > > > Btw, in case the "fully resolving" mode is slower than not fully resolving > > please consider gating it on -fexpensive-optimizations (aka -O2+), thus > > run the passes in

Re: [PATCH] Remove VRP threader passes in exchange for better threading pre-VRP.

2021-10-29 Thread Aldy Hernandez via Gcc-patches
On Fri, Oct 29, 2021 at 9:30 AM Richard Biener wrote: > Btw, in case the "fully resolving" mode is slower than not fully resolving > please consider gating it on -fexpensive-optimizations (aka -O2+), thus > run the passes in not fully resolving modes at-O1. Sorry for the awkward naming. I

Re: [PATCH] Remove VRP threader passes in exchange for better threading pre-VRP.

2021-10-29 Thread Richard Biener via Gcc-patches
On Thu, Oct 28, 2021 at 8:34 PM Jeff Law via Gcc-patches wrote: > > > > On 10/28/2021 9:24 AM, Aldy Hernandez wrote: > > This patch upgrades the pre-VRP threading passes to fully resolving > > backward threaders, and removes the post-VRP threading passes altogether. > > With it, we reduce the

Re: [PATCH] Remove VRP threader passes in exchange for better threading pre-VRP.

2021-10-28 Thread Jeff Law via Gcc-patches
On 10/28/2021 9:24 AM, Aldy Hernandez wrote: This patch upgrades the pre-VRP threading passes to fully resolving backward threaders, and removes the post-VRP threading passes altogether. With it, we reduce the number of threaders in our pipeline from 9 to 7. This will leave DOM as the only

Re: [PATCH] Remove VRP threader passes in exchange for better threading pre-VRP.

2021-10-28 Thread Aldy Hernandez via Gcc-patches
> > > And... the total compilation improves by 1.32%! > This last number is compilation speed, not number of threads. Aldy

[PATCH] Remove VRP threader passes in exchange for better threading pre-VRP.

2021-10-28 Thread Aldy Hernandez via Gcc-patches
This patch upgrades the pre-VRP threading passes to fully resolving backward threaders, and removes the post-VRP threading passes altogether. With it, we reduce the number of threaders in our pipeline from 9 to 7. This will leave DOM as the only forward threader client. When the ranger can