Re: [PATCH] c++, coroutines: Partial reversion of r12-8308-g15a176a833f23e [PR105426].

2022-04-28 Thread Jakub Jelinek via Gcc-patches
On Thu, Apr 28, 2022 at 11:22:45PM +0100, Iain Sandoe wrote: > how about the following, which uniques the names by bind scope, scope nest > and then > sequence within that? That LGTM. > --- a/gcc/cp/coroutines.cc > +++ b/gcc/cp/coroutines.cc > @@ -3913,6 +3913,7 @@ register_local_var_uses (tree

Re: [PATCH] c++, coroutines: Partial reversion of r12-8308-g15a176a833f23e [PR105426].

2022-04-28 Thread Iain Sandoe
> On 28 Apr 2022, at 20:26, Jakub Jelinek wrote: > > On Thu, Apr 28, 2022 at 08:17:04PM +0100, Iain Sandoe wrote: >> Signed-off-by: Iain Sandoe >> >> PR c++/105426 >> >> gcc/cp/ChangeLog: >> >> * coroutines.cc (register_local_var_uses): Allow promotion of unnamed >>

Re: [PATCH] c++, coroutines: Partial reversion of r12-8308-g15a176a833f23e [PR105426].

2022-04-28 Thread Jakub Jelinek via Gcc-patches
On Thu, Apr 28, 2022 at 08:17:04PM +0100, Iain Sandoe wrote: > Signed-off-by: Iain Sandoe > > PR c++/105426 > > gcc/cp/ChangeLog: > > * coroutines.cc (register_local_var_uses): Allow promotion of unnamed > temporaries to coroutine frame copies. > --- > gcc/cp/coroutines.cc |

[PATCH] c++, coroutines: Partial reversion of r12-8308-g15a176a833f23e [PR105426].

2022-04-28 Thread Iain Sandoe via Gcc-patches
The changes to fix PR 105287 included a tightening of the constraints on which variables are promoted to frame copies. This has exposed that we are failing to name some variables that should be promoted. The long-term fix is to address the cases where the naming has been missed, but for the