Re: [PATCH] c++: call complete_type after performing auto deduction [PR80351]

2022-03-29 Thread Jason Merrill via Gcc-patches
On 3/29/22 02:02, Pokechu22 wrote: On Thu, Mar 24, 2022 at 1:53 PM Jason Merrill wrote: Thanks! For future reference, the patch doesn't apply easily because gmail wrapped lines; for sending patches via gmail you'll need to use attachments. Or you can use another MUA, or git send-email. This

Re: [PATCH] c++: call complete_type after performing auto deduction [PR80351]

2022-03-29 Thread Pokechu22 via Gcc-patches
On Thu, Mar 24, 2022 at 1:53 PM Jason Merrill wrote: > Thanks! For future reference, the patch doesn't apply easily because > gmail wrapped lines; for sending patches via gmail you'll need to use > attachments. Or you can use another MUA, or git send-email. This time > I fixed the wrapping by

Re: [PATCH] c++: call complete_type after performing auto deduction [PR80351]

2022-03-24 Thread Jason Merrill via Gcc-patches
On 3/23/22 21:01, Pokechu22 via Gcc-patches wrote: When cp_finish_decl calls cp_apply_type_quals_to_decl on a const auto or constexpr auto variable, the type might not be complete the first time (this happened when auto deduces to an initializer_list). cp_apply_type_quals_to_decl removes the

[PATCH] c++: call complete_type after performing auto deduction [PR80351]

2022-03-23 Thread Pokechu22 via Gcc-patches
When cp_finish_decl calls cp_apply_type_quals_to_decl on a const auto or constexpr auto variable, the type might not be complete the first time (this happened when auto deduces to an initializer_list). cp_apply_type_quals_to_decl removes the const qualifier if the type is not complete, which is