Re: [PATCH] contrib/gcc-changelog: Handle Reviewed-{by,on}

2020-05-20 Thread Martin Liška
On 5/20/20 7:53 AM, Frederik Harwath wrote: Yes, I will add it. Thank you for the patch. I'm adding test for that and also some format changes in order to make flake8 happy: flake8 contrib/gcc-changelog/ contrib/gcc-changelog/git_commit.py:158:59: E502 the backslash is redundant between

Re: [PATCH] contrib/gcc-changelog: Handle Reviewed-{by,on}

2020-05-20 Thread Martin Liška
On 5/20/20 7:53 AM, Frederik Harwath wrote: Martin Liška writes: Hi Martin, On 5/19/20 11:45 AM, Frederik Harwath wrote: Thank you Frederick for the patch. Looking at what I grepped: https://github.com/marxin/gcc-changelog/issues/1#issuecomment-621910248 I get a 404 error when I try to

Re: [PATCH] contrib/gcc-changelog: Handle Reviewed-{by,on}

2020-05-19 Thread Frederik Harwath
Martin Liška writes: Hi Martin, > On 5/19/20 11:45 AM, Frederik Harwath wrote: > Thank you Frederick for the patch. > > Looking at what I grepped: > https://github.com/marxin/gcc-changelog/issues/1#issuecomment-621910248 I get a 404 error when I try to access this URL. The repository also does

Re: [PATCH] contrib/gcc-changelog: Handle Reviewed-{by,on}

2020-05-19 Thread Martin Liška
On 5/19/20 11:45 AM, Frederik Harwath wrote: Hi, the new contrib/gcc-changelog/git_check_commit.py script (which, by the way, is very useful!) does not handle "Reviewed-by" and "Reviewed-on" lines yet and hence it expects those lines to be indented by a tab although those lines are usually not

[PATCH] contrib/gcc-changelog: Handle Reviewed-{by,on}

2020-05-19 Thread Frederik Harwath
wath Date: Tue, 19 May 2020 11:15:28 +0200 Subject: [PATCH] contrib/gcc-changelog: Handle Reviewed-{by,on} git-check-commit.py does not know about "Reviewed-by" and "Reviewed-on" lines and hence it expects those lines which follow the ChangeLog entries to be indented by a t