Re: [PATCH] ipa: Avoid invalid gimple when IPA-CP and IPA-SRA disagree on types (108384)

2023-02-06 Thread Martin Jambor
Hi, On Fri, Feb 03 2023, Bernhard Reutner-Fischer wrote: > On 3 February 2023 12:35:32 CET, Richard Biener via Gcc-patches >> >>I think it's OK as-is given this explanation. >> > > s/derefernce/dereference/ > Thanks for noticing. I am about to commit the following as an obvious fix. Martin A

Re: [PATCH] ipa: Avoid invalid gimple when IPA-CP and IPA-SRA disagree on types (108384)

2023-02-03 Thread Bernhard Reutner-Fischer via Gcc-patches
On 3 February 2023 12:35:32 CET, Richard Biener via Gcc-patches > >I think it's OK as-is given this explanation. > s/derefernce/dereference/ thanks,

Re: [PATCH] ipa: Avoid invalid gimple when IPA-CP and IPA-SRA disagree on types (108384)

2023-02-03 Thread Richard Biener via Gcc-patches
On Fri, Feb 3, 2023 at 10:40 AM Martin Jambor wrote: > > On Fri, Feb 03 2023, Richard Biener wrote: > > On Thu, Feb 2, 2023 at 5:20 PM Martin Jambor wrote: > >> > >> Hi, > >> > >> when the compiled program contains type mismatches between callers and > >> callees when it comes to a parameter,

Re: [PATCH] ipa: Avoid invalid gimple when IPA-CP and IPA-SRA disagree on types (108384)

2023-02-03 Thread Martin Jambor
On Fri, Feb 03 2023, Richard Biener wrote: > On Thu, Feb 2, 2023 at 5:20 PM Martin Jambor wrote: >> >> Hi, >> >> when the compiled program contains type mismatches between callers and >> callees when it comes to a parameter, IPA-CP can try to propagate one >> constant from callers while IPA-SRA

Re: [PATCH] ipa: Avoid invalid gimple when IPA-CP and IPA-SRA disagree on types (108384)

2023-02-02 Thread Richard Biener via Gcc-patches
On Thu, Feb 2, 2023 at 5:20 PM Martin Jambor wrote: > > Hi, > > when the compiled program contains type mismatches between callers and > callees when it comes to a parameter, IPA-CP can try to propagate one > constant from callers while IPA-SRA may try to split a parameter > expecting a value of

[PATCH] ipa: Avoid invalid gimple when IPA-CP and IPA-SRA disagree on types (108384)

2023-02-02 Thread Martin Jambor
Hi, when the compiled program contains type mismatches between callers and callees when it comes to a parameter, IPA-CP can try to propagate one constant from callers while IPA-SRA may try to split a parameter expecting a value of a different size on the same offset. This then currently leads to