Re: [PATCH] treat argp-based mem as frame related in dse

2023-12-21 Thread Hans-Peter Nilsson
> From: Jiufu Guo > Date: Wed, 6 Dec 2023 17:27:58 +0800 > Hi, > > The issue mentioned in PR112525 would be able to be handled by > > updating dse.cc to treat arg_pointer_rtx similarly with frame_pointer_rtx. > >

Re: [PATCH] treat argp-based mem as frame related in dse

2023-12-11 Thread Jeff Law
On 12/11/23 02:26, Jiufu Guo wrote: Hi, Thanks for your quick reply! Jeff Law writes: On 12/10/23 20:07, Jiufu Guo wrote: I'm having a bit of a hard time convincing myself this is correct though. I can't see how rewriting the load to read the source of the prior store is unsafe. If

Re: [PATCH] treat argp-based mem as frame related in dse

2023-12-11 Thread Jiufu Guo
Hi, Thanks for your quick reply! Jeff Law writes: > On 12/10/23 20:07, Jiufu Guo wrote: > > I'm having a bit of a hard time convincing myself this is correct > though. I can't see how rewriting the load to read the source of the > prior store is unsafe. If that fixes a problem,

Re: [PATCH] treat argp-based mem as frame related in dse

2023-12-10 Thread Jeff Law
On 12/10/23 20:07, Jiufu Guo wrote: I'm having a bit of a hard time convincing myself this is correct though. I can't see how rewriting the load to read the source of the prior store is unsafe. If that fixes a problem, then it would seem like we've gone wrong before here -- perhaps failing

Re: [PATCH] treat argp-based mem as frame related in dse

2023-12-10 Thread Jiufu Guo
Hi, Thanks again for your kind review! Jeff Law writes: > On 12/8/23 00:18, Jiufu Guo wrote: >> >> Hi, >> >> Jeff Law writes: >> >>> On 12/6/23 02:27, Jiufu Guo wrote: Hi, The issue mentioned in PR112525 would be able to be handled by updating dse.cc to treat

Re: [PATCH] treat argp-based mem as frame related in dse

2023-12-10 Thread Jeff Law
On 12/8/23 00:18, Jiufu Guo wrote: Hi, Jeff Law writes: On 12/6/23 02:27, Jiufu Guo wrote: Hi, The issue mentioned in PR112525 would be able to be handled by updating dse.cc to treat arg_pointer_rtx similarly with frame_pointer_rtx.

Re: [PATCH] treat argp-based mem as frame related in dse

2023-12-07 Thread Jiufu Guo
Hi, Jeff Law writes: > On 12/6/23 02:27, Jiufu Guo wrote: >> Hi, >> >> The issue mentioned in PR112525 would be able to be handled by >> updating dse.cc to treat arg_pointer_rtx similarly with frame_pointer_rtx. >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30271#c10 also mentioned >> this

Re: [PATCH] treat argp-based mem as frame related in dse

2023-12-07 Thread Jeff Law
On 12/6/23 02:27, Jiufu Guo wrote: Hi, The issue mentioned in PR112525 would be able to be handled by updating dse.cc to treat arg_pointer_rtx similarly with frame_pointer_rtx. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30271#c10 also mentioned this idea.

[PATCH] treat argp-based mem as frame related in dse

2023-12-06 Thread Jiufu Guo
Hi, The issue mentioned in PR112525 would be able to be handled by updating dse.cc to treat arg_pointer_rtx similarly with frame_pointer_rtx. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30271#c10 also mentioned