Robin Dapp writes:
> Hi Richard,
>
>> I think it would be better to fold this into the existing documentation
>> a bit more:
> [..]
>
> done.
>
> Fixed the remaining nits in the attached v5.
>
> Bootstrap and regtest are good on s390x, Power9 and i386.
>
> Regards
> Robin
>
> --
>
>
Hi Richard,
> I think it would be better to fold this into the existing documentation
> a bit more:
[..]
done.
Fixed the remaining nits in the attached v5.
Bootstrap and regtest are good on s390x, Power9 and i386.
Regards
Robin
--
gcc/ChangeLog:
* config/rs6000/vsx.md: Use const0
Robin Dapp writes:
> Hi Richard,
>
> I incorporated all your remarks (sorry for the hunk from a different
> branch) except for this one:
>
>> Think it would be better to make it:
>>
>>if (use_bias_adjusted_len)
>> {
>>gcc_assert (i == 0);
>>
>> But do we need to do
Hi Richard,
I incorporated all your remarks (sorry for the hunk from a different
branch) except for this one:
> Think it would be better to make it:
>
> if (use_bias_adjusted_len)
> {
> gcc_assert (i == 0);
>
> But do we need to do this? Code should only care
Robin Dapp writes:
> Hi Kewen, Richard,
>
> thanks for the comments, I addressed them in the attached v4.
Sorry again for the slow review. I only have some very minor
comments left:
> Bootstrap and regtest are good as before.
>
> Regards
> Robin
>
> diff --git a/gcc/config/rs6000/vsx.md
Hi Kewen, Richard,
thanks for the comments, I addressed them in the attached v4.
Bootstrap and regtest are good as before.
Regards
Robindiff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md
index bf033e31c1c..dc2756f83e9 100644
--- a/gcc/config/rs6000/vsx.md
+++
Hi Robin,
on 2021/11/12 下午5:56, Robin Dapp wrote:
> Hi Kewen and Richard,
>
> the attached v3 addresses the comments to v2, among others:
>
> - Rename to load_store where appropriate.
> - Save the adjusted length as a separate control that is used instead
> of loop_len with a bias != 0 and
Hi Kewen and Richard,
the attached v3 addresses the comments to v2, among others:
- Rename to load_store where appropriate.
- Save the adjusted length as a separate control that is used instead
of loop_len with a bias != 0 and added to the loop header.
- Update the costs to reflect a bias.
Hi Robin,
on 2021/11/3 上午4:16, Robin Dapp wrote:
> Hi,
>
> thanks for the helpful comments. The attached v2 addresses the following
> points from them:
>
> - Save the bias in loop_vinfo and set it once in vect_verify_loop_lens.
> - Add code to handle the bias in
Hi,
thanks for the helpful comments. The attached v2 addresses the following
points from them:
- Save the bias in loop_vinfo and set it once in vect_verify_loop_lens.
- Add code to handle the bias in vect_set_loop_controls_directly.
- Adjust costing.
- Add comments for the new len_load
Robin Dapp writes:
> Hi,
>
> as discussed in
> https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582627.html this
> introduces a bias parameter for the len_load/len_store ifns as well as
> optabs that is meant to distinguish between Power and s390 variants.
> The default is a bias of 0,
Hi Robin,
on 2021/10/28 下午10:44, Robin Dapp wrote:
> Hi,
>
> as discussed in
> https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582627.html this
> introduces a bias parameter for the len_load/len_store ifns as well as
> optabs that is meant to distinguish between Power and s390 variants.
>
Hi,
as discussed in
https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582627.html this
introduces a bias parameter for the len_load/len_store ifns as well as
optabs that is meant to distinguish between Power and s390 variants.
The default is a bias of 0, while in s390's case vll/vstl do not
13 matches
Mail list logo
