Re: [PATCH v1 02/13] aarch64: The aarch64-w64-mingw32 target implements

2024-02-25 Thread Mark Harmstone
On 23/2/24 17:54, Andrew Pinski wrote: There is arm64ec ABI defined for aarch64 windows which is a different ABI from the standard windows aarch64 ABI, though I am not sure if it supported with the patches here. It is documented at

[PATCH v1 02/13] aarch64: The aarch64-w64-mingw32 target implements

2024-02-23 Thread Evgeny Karpov
Hi Martin, Thank you for the clarification regarding the vararg implementation. It is correct. The work is still in progress and will be included in a later patch series. ARM64EC is a separate work, which is outside the scope of the current contribution plan. Regards, Evgeny -Original

[PATCH v1 02/13] aarch64: The aarch64-w64-mingw32 target implements

2024-02-23 Thread Evgeny Karpov
Hi Richard, Thank you for your review! The MS_ABI definition is for the x86/x64 MS ABI, and it's clear that it shouldn't be used on aarch64. The AARCH64_CALLING_ABI_MS definition resolves the issue. It just needs to be properly handled in mingw32.h. The change below is sufficient to resolve

Re: [PATCH v1 02/13] aarch64: The aarch64-w64-mingw32 target implements

2024-02-23 Thread Martin Storsjö
On Fri, 23 Feb 2024, Richard Sandiford wrote: Are there two distinct ABIs for aarch64-*-mingw*? Or are these distinctions ignored on aarch64 and just retained for compatibility? On Windows on AArch64, the calling convention normally matches regular AAPCS64 - so the ms_abi attribute normally

Re: [PATCH v1 02/13] aarch64: The aarch64-w64-mingw32 target implements

2024-02-23 Thread Andrew Pinski
On Fri, Feb 23, 2024 at 9:51 AM Richard Sandiford wrote: > > Evgeny Karpov writes: > > The calling ABI enum definition has been done following a similar > > convention in > >

Re: [PATCH v1 02/13] aarch64: The aarch64-w64-mingw32 target implements

2024-02-23 Thread Richard Sandiford
Evgeny Karpov writes: > The calling ABI enum definition has been done following a similar convention > in > https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/config/i386/i386-opts.h;h=ef2825803b32001b9632769bdff196d1e43d27ba;hb=refs/heads/master#l41 > > MS_ABI is used in gcc/config/i386/mingw32.h

[PATCH v1 02/13] aarch64: The aarch64-w64-mingw32 target implements

2024-02-23 Thread Evgeny Karpov
The calling ABI enum definition has been done following a similar convention in https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/config/i386/i386-opts.h;h=ef2825803b32001b9632769bdff196d1e43d27ba;hb=refs/heads/master#l41 MS_ABI is used in gcc/config/i386/mingw32.h and gcc/config/i386/winnt-d.cc

Re: [PATCH v1 02/13] aarch64: The aarch64-w64-mingw32 target implements

2024-02-22 Thread Richard Earnshaw (lists)
On 21/02/2024 18:26, Evgeny Karpov wrote: > +/* Available call ABIs. */ +enum calling_abi +{ + AARCH64_EABI = 0, + MS_ABI = 1 +}; + The convention in this file seems to be that all enum types to start with aarch64. Also, the enumeration values should start with the name of the enumeration

[PATCH v1 02/13] aarch64: The aarch64-w64-mingw32 target implements

2024-02-21 Thread Evgeny Karpov
From 5cab07f01f66ba162b7d542e1a61c96f49942331 Mon Sep 17 00:00:00 2001 From: Zac Walker Date: Tue, 20 Feb 2024 15:32:08 +0100 Subject: [PATCH v1 02/13] aarch64: The aarch64-w64-mingw32 target implements the MS ABI Two ABIs for aarch64 have been defined for different platforms. gcc/ChangeLog