nzhang ; Liu, Hongtao
Subject: Re: [PATCH v2] DSE: Bugfix ICE after allow vector type in
get_stored_val
On 3/22/24 11:45 PM, Li, Pan2 wrote:
> Thanks Jeff for comments.
>
>> As Richi noted using validate_subreg here isn't great. Does it work to
>> factor out t
On 3/22/24 11:45 PM, Li, Pan2 wrote:
Thanks Jeff for comments.
As Richi noted using validate_subreg here isn't great. Does it work to
factor out this code from extract_low_bits
if (!int_mode_for_mode (src_mode).exists (_int_mode)
|| !int_mode_for_mode (mode).exists (_mode))
...@gmail.com;
Wang, Yanzhang ; Liu, Hongtao
Subject: RE: [PATCH v2] DSE: Bugfix ICE after allow vector type in
get_stored_val
Kindly ping for this ice.
Pan
-Original Message-
From: Li, Pan2
Sent: Saturday, March 23, 2024 1:45 PM
To: Jeff Law ; Robin Dapp ;
gcc-patches@gcc.gnu.org
Cc
: RE: [PATCH v2] DSE: Bugfix ICE after allow vector type in
get_stored_val
Kindly ping for this ice.
Pan
-Original Message-
From: Li, Pan2
Sent: Saturday, March 23, 2024 1:45 PM
To: Jeff Law ; Robin Dapp ;
gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com
ract_low_bits (read_mode, store_mode,
Pan
-Original Message-
From: Jeff Law
Sent: Saturday, March 23, 2024 2:54 AM
To: Li, Pan2 ; Robin Dapp ;
gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; richard.guent...@gmail.com;
Wang, Yanzhang ; Liu, Hongtao
Subject:
al Message-
From: Jeff Law
Sent: Saturday, March 23, 2024 2:54 AM
To: Li, Pan2 ; Robin Dapp ;
gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; richard.guent...@gmail.com;
Wang, Yanzhang ; Liu, Hongtao
Subject: Re: [PATCH v2] DSE: Bugfix ICE after allow vector type in
get_store
On 3/4/24 11:22 PM, Li, Pan2 wrote:
Thanks Jeff for comments.
But in the case of a vector modes, we can usually reinterpret the
underlying bits in whatever mode we want and do any of the usual
operations on those bits.
Yes, I think that is why we can allow vector mode in get_stored_val if
Subject: RE: [PATCH v2] DSE: Bugfix ICE after allow vector type in
get_stored_val
Hi Jeff,
Is there any suggestion(s) for how to fix this ICE in the reasonable approach?
Thanks a lot.
Pan
-Original Message-
From: Li, Pan2
Sent: Tuesday, March 5, 2024 2:23 PM
To: Jeff Law ; Robin Dapp
; richard.guent...@gmail.com;
Wang, Yanzhang ; Liu, Hongtao
Subject: RE: [PATCH v2] DSE: Bugfix ICE after allow vector type in
get_stored_val
Thanks Jeff for comments.
> But in the case of a vector modes, we can usually reinterpret the
> underlying bits in whatever mode we want and do any of the
ard.guent...@gmail.com;
Wang, Yanzhang ; Liu, Hongtao
Subject: Re: [PATCH v2] DSE: Bugfix ICE after allow vector type in
get_stored_val
On 2/29/24 06:28, Robin Dapp wrote:
> On 2/29/24 02:38, Li, Pan2 wrote:
>>> So it's going to check if V2SF can be tied to DI and V4QI with SI. I
>&g
On 2/29/24 06:28, Robin Dapp wrote:
On 2/29/24 02:38, Li, Pan2 wrote:
So it's going to check if V2SF can be tied to DI and V4QI with SI. I
suspect those are going to fail for RISC-V as those aren't tieable.
Yes, you are right. Different REG_CLASS are not allowed to be tieable in RISC-V.
Robin Dapp
Sent: Thursday, February 29, 2024 9:29 PM
To: Li, Pan2 ; Jeff Law ;
gcc-patches@gcc.gnu.org
Cc: rdapp@gmail.com; juzhe.zh...@rivai.ai; kito.ch...@gmail.com;
richard.guent...@gmail.com; Wang, Yanzhang ; Liu,
Hongtao
Subject: Re: [PATCH v2] DSE: Bugfix ICE after allow vector ty
On 2/29/24 02:38, Li, Pan2 wrote:
>> So it's going to check if V2SF can be tied to DI and V4QI with SI. I
>> suspect those are going to fail for RISC-V as those aren't tieable.
>
> Yes, you are right. Different REG_CLASS are not allowed to be tieable in
> RISC-V.
>
> static bool
>
ail.com;
Wang, Yanzhang ; rdapp@gmail.com; Liu, Hongtao
Subject: Re: [PATCH v2] DSE: Bugfix ICE after allow vector type in
get_stored_val
On 2/27/24 21:51, Li, Pan2 wrote:
>>if (!targetm.modes_tieable_p (src_int_mode, src_mode))
>> return NULL_RTX;
>>if (!targetm
On 2/27/24 21:51, Li, Pan2 wrote:
if (!targetm.modes_tieable_p (src_int_mode, src_mode))
return NULL_RTX;
if (!targetm.modes_tieable_p (int_mode, mode))
return NULL_RTX;
Yes, will return NULL_RTX for in the first if, given src_int_mode is E_DImode
while src_mode is
ail.com; Liu, Hongtao
Subject: RE: [PATCH v2] DSE: Bugfix ICE after allow vector type in
get_stored_val
> Pan, can you confirm what path we take through extract_low_bits?
Thanks Jeff for comments, will have a try soon and keep you posted.
Pan
-Original Message-
From: Jeff Law
.ai; kito.ch...@gmail.com; richard.guent...@gmail.com;
Wang, Yanzhang ; rdapp@gmail.com; Liu, Hongtao
Subject: Re: [PATCH v2] DSE: Bugfix ICE after allow vector type in
get_stored_val
On 2/26/24 07:22, pan2...@intel.com wrote:
> From: Pan Li
>
> We allowed vector type for get_stored_v
On 2/26/24 07:22, pan2...@intel.com wrote:
From: Pan Li
We allowed vector type for get_stored_val when read is less than or
equal to store in previous. Unfortunately, we missed to adjust the
validate_subreg part accordingly. When the vector type's size is
less than vector register, it
On Mon, Feb 26, 2024 at 3:22 PM wrote:
>
> From: Pan Li
>
> We allowed vector type for get_stored_val when read is less than or
> equal to store in previous. Unfortunately, we missed to adjust the
> validate_subreg part accordingly. When the vector type's size is
> less than vector register,
From: Pan Li
We allowed vector type for get_stored_val when read is less than or
equal to store in previous. Unfortunately, we missed to adjust the
validate_subreg part accordingly. When the vector type's size is
less than vector register, it will be considered as invalid in the
20 matches
Mail list logo
