Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Manos Anagnostakis
No problem! I'll send a follow up with the requested changes. Thanks for the input! Manos. On Thu, Sep 28, 2023 at 4:42 PM Richard Sandiford wrote: > Manos Anagnostakis writes: > > Hey Richard, > > > > Thanks for taking the time to review this, but it has been commited since > > yesterday

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Richard Sandiford
Manos Anagnostakis writes: > Hey Richard, > > Thanks for taking the time to review this, but it has been commited since > yesterday after getting reviewed by Kyrill and Tamar. > > Discussions: > https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631285.html >

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Manos Anagnostakis
Sure, I will attend to this. Manos. On Thu, Sep 28, 2023 at 4:37 PM Philipp Tomsich wrote: > Manos, > > Please submit a follow-on patch implementing the requested > improvements of the code structure (as this reduces the maintenance > burden). > > Thanks, > Philipp. > > > On Thu, 28 Sept 2023

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Philipp Tomsich
Manos, Please submit a follow-on patch implementing the requested improvements of the code structure (as this reduces the maintenance burden). Thanks, Philipp. On Thu, 28 Sept 2023 at 15:33, Manos Anagnostakis wrote: > > Hey Richard, > > Thanks for taking the time to review this, but it has

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Manos Anagnostakis
Hey Richard, Thanks for taking the time to review this, but it has been commited since yesterday after getting reviewed by Kyrill and Tamar. Discussions: https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631285.html https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631300.html

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Richard Sandiford
Thanks for the patch and sorry for the slow review. Manos Anagnostakis writes: > This patch implements the following TODO in gcc/config/aarch64/aarch64.cc > to provide the requested behaviour for handling ldp and stp: > > /* Allow the tuning structure to disable LDP instruction formation >

[PING] [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-22 Thread Manos Anagnostakis
Kind ping for reviewing this patch. It's tested and does not cause regressions: https://patchwork.sourceware.org/project/gcc/patch/20230828143744.7574-1-manos.anagnosta...@vrull.eu/ Thank you in advance! On Mon, Aug 28, 2023 at 5:37 PM Manos Anagnostakis < manos.anagnosta...@vrull.eu> wrote: >

[PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-08-28 Thread Manos Anagnostakis
This patch implements the following TODO in gcc/config/aarch64/aarch64.cc to provide the requested behaviour for handling ldp and stp: /* Allow the tuning structure to disable LDP instruction formation from combining instructions (e.g., in peephole2). TODO: Implement fine-grained