Re: [Patch] libgcov.c re-factoring

2014-01-08 Thread Teresa Johnson
On Mon, Jan 6, 2014 at 9:49 AM, Teresa Johnson tejohn...@google.com wrote: On Sun, Jan 5, 2014 at 12:08 PM, Jan Hubicka hubi...@ucw.cz wrote: 2014-01-03 Rong Xu x...@google.com * gcc/gcov-io.c (gcov_var): Move from gcov-io.h. (gcov_position): Ditto. (gcov_is_error):

Re: [Patch] libgcov.c re-factoring

2014-01-08 Thread Jan Hubicka
Actually, I tried changing these two, but gcc_checking_assert is undefined in libgcov.a. Ok to commit without this change? OK. incrementally can you please define gcov_nonruntime_assert that will wind into gcc_assert for code within gcc/coverage tools and into nothing for libgcov runtime and

Re: [Patch] libgcov.c re-factoring

2014-01-08 Thread Teresa Johnson
On Wed, Jan 8, 2014 at 6:34 AM, Jan Hubicka hubi...@ucw.cz wrote: Actually, I tried changing these two, but gcc_checking_assert is undefined in libgcov.a. Ok to commit without this change? OK. incrementally can you please define gcov_nonruntime_assert that will wind into gcc_assert for code

Re: [Patch] libgcov.c re-factoring

2014-01-07 Thread Andrew MacLeod
On 01/07/2014 06:47 PM, Xinliang David Li wrote: A related question. I have not followed the header file restructuring discussion. Is there a documentation on header file structure and how they are organized? In a new .c file, simply including gimple.h would require many rounds of iterations to

Re: [Patch] libgcov.c re-factoring

2014-01-07 Thread Xinliang David Li
On Tue, Jan 7, 2014 at 7:42 PM, Andrew MacLeod amacl...@redhat.com wrote: On 01/07/2014 06:47 PM, Xinliang David Li wrote: A related question. I have not followed the header file restructuring discussion. Is there a documentation on header file structure and how they are organized? In a new

Re: [Patch] libgcov.c re-factoring

2014-01-06 Thread Andrew MacLeod
On 12/22/2013 01:27 PM, Jan Hubicka wrote: I believe when the code was created by moving it from elsehwre, the copyright should say original date of gcov-io.h. + +#include tconfig.h +#include tsystem.h +#include coretypes.h +#include tm.h +#include libgcc_tm.h I would really like

Re: [Patch] libgcov.c re-factoring

2014-01-06 Thread Jan Hubicka
On 12/22/2013 01:27 PM, Jan Hubicka wrote: I believe when the code was created by moving it from elsehwre, the copyright should say original date of gcov-io.h. + +#include tconfig.h +#include tsystem.h +#include coretypes.h +#include tm.h +#include libgcc_tm.h I would really

Re: [Patch] libgcov.c re-factoring

2014-01-06 Thread Andrew MacLeod
On 01/06/2014 09:37 AM, Jan Hubicka wrote: On 12/22/2013 01:27 PM, Jan Hubicka wrote: I believe when the code was created by moving it from elsehwre, the copyright should say original date of gcov-io.h. + +#include tconfig.h +#include tsystem.h +#include coretypes.h +#include tm.h +#include

Re: [Patch] libgcov.c re-factoring

2014-01-06 Thread Teresa Johnson
On Sun, Jan 5, 2014 at 12:08 PM, Jan Hubicka hubi...@ucw.cz wrote: 2014-01-03 Rong Xu x...@google.com * gcc/gcov-io.c (gcov_var): Move from gcov-io.h. (gcov_position): Ditto. (gcov_is_error): Ditto. (gcov_rewrite): Ditto. * gcc/gcov-io.h: Refactor.

Re: [Patch] libgcov.c re-factoring

2014-01-05 Thread Jan Hubicka
2014-01-03 Rong Xu x...@google.com * gcc/gcov-io.c (gcov_var): Move from gcov-io.h. (gcov_position): Ditto. (gcov_is_error): Ditto. (gcov_rewrite): Ditto. * gcc/gcov-io.h: Refactor. Move gcov_var to gcov-io.h, and libgcov only part to

Re: [Patch] libgcov.c re-factoring

2014-01-03 Thread Teresa Johnson
On Sun, Dec 22, 2013 at 10:27 AM, Jan Hubicka hubi...@ucw.cz wrote: On Tue, Dec 17, 2013 at 7:48 AM, Teresa Johnson tejohn...@google.com wrote: On Mon, Dec 16, 2013 at 2:48 PM, Xinliang David Li davi...@google.com wrote: Ok -- gcov_write_counter and gcov_write_tag_length are qualified as

Re: [Patch] libgcov.c re-factoring

2014-01-03 Thread Joseph S. Myers
On Fri, 3 Jan 2014, Teresa Johnson wrote: Index: libgcc/libgcov.h === --- libgcc/libgcov.h(revision 0) +++ libgcc/libgcov.h(revision 0) @@ -0,0 +1,224 @@ +/* Header file for libgcov-*.c. + Copyright (C) 1996-2013

Re: [Patch] libgcov.c re-factoring

2014-01-03 Thread Teresa Johnson
On Fri, Jan 3, 2014 at 2:49 PM, Joseph S. Myers jos...@codesourcery.com wrote: On Fri, 3 Jan 2014, Teresa Johnson wrote: Index: libgcc/libgcov.h === --- libgcc/libgcov.h(revision 0) +++ libgcc/libgcov.h(revision 0) @@

Re: [Patch] libgcov.c re-factoring

2013-12-22 Thread Jan Hubicka
On Tue, Dec 17, 2013 at 7:48 AM, Teresa Johnson tejohn...@google.com wrote: On Mon, Dec 16, 2013 at 2:48 PM, Xinliang David Li davi...@google.com wrote: Ok -- gcov_write_counter and gcov_write_tag_length are qualified as low level primitives for basic gcov format and probably should be

[Patch] libgcov.c re-factoring

2013-12-20 Thread Teresa Johnson
On Tue, Dec 17, 2013 at 7:48 AM, Teresa Johnson tejohn...@google.com wrote: On Mon, Dec 16, 2013 at 2:48 PM, Xinliang David Li davi...@google.com wrote: Ok -- gcov_write_counter and gcov_write_tag_length are qualified as low level primitives for basic gcov format and probably should be kept in