Re: [committed] libstdc++: Add GDB printers for types

2023-09-28 Thread Jonathan Wakely
On Thu, 28 Sept 2023, 18:37 Tom Tromey, wrote: > Jonathan> The changes made by black seem reasonable, though I prefer it > Jonathan> with -S to disable string-normalization. It also needs an > Jonathan> option to use 79 as the maximum line length. > > I've got some patches I'm about to send. > >

Re: [committed] libstdc++: Add GDB printers for types

2023-09-28 Thread Tom Tromey
Jonathan> The changes made by black seem reasonable, though I prefer it Jonathan> with -S to disable string-normalization. It also needs an Jonathan> option to use 79 as the maximum line length. I've got some patches I'm about to send. I made a pyproject.toml to auto-configure black (and isort),

Re: [committed] libstdc++: Add GDB printers for types

2023-09-28 Thread Jonathan Wakely
On Wed, 27 Sept 2023 at 20:57, Jonathan Wakely wrote: > > > > On Wed, 27 Sept 2023, 18:25 Tom Tromey via Libstdc++, < libstd...@gcc.gnu.org> wrote: >> >> >> I have fixes for most of the issues that are worth fixing (I didn't >> >> bother with line lengths -- FWIW in gdb we just run 'black' and

Re: [committed] libstdc++: Add GDB printers for types

2023-09-27 Thread Jonathan Wakely
On Wed, 27 Sept 2023, 18:25 Tom Tromey via Libstdc++, wrote: > >> I have fixes for most of the issues that are worth fixing (I didn't > >> bother with line lengths -- FWIW in gdb we just run 'black' and don't > >> worry about these details), > > Jonathan> I used autopep8 and committed the result

Re: [committed] libstdc++: Add GDB printers for types

2023-09-27 Thread Tom Tromey
>> I have fixes for most of the issues that are worth fixing (I didn't >> bother with line lengths -- FWIW in gdb we just run 'black' and don't >> worry about these details), Jonathan> I used autopep8 and committed the result as Jonathan> e08559271b2d797f658579ac8610dbf5e58bcfd8 so the line

Re: [committed] libstdc++: Add GDB printers for types

2023-09-27 Thread Jonathan Wakely
On Wed, 27 Sept 2023 at 16:37, Tom Tromey wrote: > > > Jonathan Wakely via Gcc-patches writes: > > Replying to a quite old email... > > I ran a Python linter on the libstdc++ pretty-printers. > > I have fixes for most of the issues that are worth fixing (I didn't > bother with line lengths

Re: [committed] libstdc++: Add GDB printers for types

2023-09-27 Thread Tom Tromey
> Jonathan Wakely via Gcc-patches writes: Replying to a quite old email... I ran a Python linter on the libstdc++ pretty-printers. I have fixes for most of the issues that are worth fixing (I didn't bother with line lengths -- FWIW in gdb we just run 'black' and don't worry about these

[committed] libstdc++: Add GDB printers for types

2022-12-22 Thread Jonathan Wakely via Gcc-patches
These should really have tests for the new types, but I've been using them heavily for a few weeks and they work well. I would rather get them committed now and add tests later. Tested x86_64-linux. Pushed to trunk. -- >8 -- libstdc++-v3/ChangeLog: * python/libstdcxx/v6/printers.py