Re: Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

Hi, Kito & Jeff Due to National Day reasons, I was unable to reply to the email in a timely manner. Thank you for making the necessary changes to this patch. For the introduction of this bug, I will also carefully summarize my experience and lessons to avoid the recurrence of such problems.

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

On 10/2/23 20:38, Kito Cheng wrote: Proposed fix, and verified with "mawk" and "gawk -P" (gawk with posix mode) on my linux also some other report it work on freebsd, just wait review :) https://gcc.gnu.org/pipermail/gcc-patches/2023-October/631785.html OK jeff

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

The patch works on AIX. I have Gawk installed, but it is a very old release before multi-dimensional array support was added. Thanks, David On Mon, Oct 2, 2023 at 10:38 PM Kito Cheng wrote: > Proposed fix, and verified with "mawk" and "gawk -P" (gawk with posix > mode) on my linux also some

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

Proposed fix, and verified with "mawk" and "gawk -P" (gawk with posix mode) on my linux also some other report it work on freebsd, just wait review :) https://gcc.gnu.org/pipermail/gcc-patches/2023-October/631785.html On Tue, Oct 3, 2023 at 2:07 AM Jeff Law wrote: > > > > On 10/2/23 12:03,

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

On 10/2/23 12:03, David Edelsohn wrote: On Mon, Oct 2, 2023 at 1:59 PM Jeff Law > wrote: On 10/2/23 11:20, David Edelsohn wrote: > Wang, > > The AWK portions of this patch broke bootstrap on AIX. > > Also, the AWK portions are

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

On Mon, Oct 2, 2023 at 1:59 PM Jeff Law wrote: > > > On 10/2/23 11:20, David Edelsohn wrote: > > Wang, > > > > The AWK portions of this patch broke bootstrap on AIX. > > > > Also, the AWK portions are common code, not RISC-V specific. I don't > > see anywhere that the common portions of the

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

On 10/2/23 11:20, David Edelsohn wrote: Wang, The AWK portions of this patch broke bootstrap on AIX. Also, the AWK portions are common code, not RISC-V specific.  I don't see anywhere that the common portions of the patch were reviewed or approved by anyone with authority to approve the

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

Wang, The AWK portions of this patch broke bootstrap on AIX. Also, the AWK portions are common code, not RISC-V specific. I don't see anywhere that the common portions of the patch were reviewed or approved by anyone with authority to approve the changes to the AWK files. This patch should not

Re: Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

Thanks reminder, I should rebase again. -- Feng Wang >Hi, > >I will need to notify you that x_riscv_xventana_subext, >MASK_XVENTANACONDOPS and TARGET_XVENTANACONDOPS are added (I think you >want to rewrite those definitions like the rest).  Also, be careful not >to remove

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

Hi, I will need to notify you that x_riscv_xventana_subext, MASK_XVENTANACONDOPS and TARGET_XVENTANACONDOPS are added (I think you want to rewrite those definitions like the rest). Also, be careful not to remove TARGET_ZICOND_LIKE. Thanks, Tsukasa On 2023/09/06 11:02, Feng Wang wrote: > This

Re: Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

I saw RVC has MASK_RVC and TARGET_RVC in options.h? On Wed, Sep 6, 2023 at 2:39 PM Feng Wang wrote: > > According to the doc, take“Mask(VECTOR_ELEN_32) > Var(riscv_vector_elen_flags)”as example, > it just generates the OPTION_MASK_VECTOR_ELEN_32, will not generate > MASK_VECTOR_ELEN_32 >

Re: Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

According to the doc, take“Mask(VECTOR_ELEN_32)     Var(riscv_vector_elen_flags)”as example, it just generates the OPTION_MASK_VECTOR_ELEN_32, will not generate MASK_VECTOR_ELEN_32 and TARGET_VECTOR_ELEN_32.  Do you want to use "MASK(name) Var(other_flags)" to generate the MASK and TARGET

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

Reading the manual again, it seems I missed something in the manual before, the MASK syntax already says we can specify Var to select the variable other than target_flags, but I tried that not work when we only declare Mask with Var (e.g. "Mask(VECTOR_ELEN_32) Var(riscv_vector_elen_flags)" still