Re: [PATCH] Fix up -march=native handling under KVM (PR target/61570)

2014-06-20 Thread H.J. Lu
On Fri, Jun 20, 2014 at 2:42 PM, Jakub Jelinek ja...@redhat.com wrote: Hi! As mentioned in the PR, some? KVM versions disable some CPU flags, supposedly so that it can be migrated to any other x86-64 hw. Thus, it announces only sse2 and lm, but already not sse3, ssse3 nor 3dnow, and

Re: [PATCH] Fix up -march=native handling under KVM (PR target/61570)

2014-06-23 Thread H.J. Lu
. This looks OK to me. Thanks, Uros. This is what I checked in. Thanks. -- H.J. --- Index: ChangeLog === --- ChangeLog (revision 211900) +++ ChangeLog (working copy) @@ -1,3 +1,9 @@ +2014-06-23 H.J. Lu hongjiu...@intel.com

Re: [PATCH] Fix up -march=native handling under KVM (PR target/61570)

2014-06-24 Thread H.J. Lu
On Mon, Jun 23, 2014 at 11:51 PM, Uros Bizjak ubiz...@gmail.com wrote: On Mon, Jun 23, 2014 at 6:29 PM, H.J. Lu hjl.to...@gmail.com wrote: --- gcc/config/i386/driver-i386.c.jj2014-05-14 14:45:54.0 +0200 +++ gcc/config/i386/driver-i386.c 2014-06-20 18:59:57.805006358

PATCH: PR libgcc/61685: Strange check in bid128_fma.c - rounding_correction()

2014-07-22 Thread H.J. Lu
Hi, This patch from Marius removes the redundant tests. Tested on Linux/x86-64 without regressions. I will check it in tomorrow. Thanks. H.J. -- diff --git a/libgcc/config/libbid/ChangeLog b/libgcc/config/libbid/ChangeLog index 9405a3a..8ec7468 100644 --- a/libgcc/config/libbid/ChangeLog +++

Re: [PATCH] Update libstdc++ baseline_symbols.txt for {i?86,x86_64,s390,s390x,ppc,ppc64}-linux

2014-07-23 Thread H.J. Lu
in this for x32 after testing. Thanks. -- H.J. -- diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 219f794..f1eda06 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,3 +1,6 @@ +2014-07-23 H.J. Lu hongjiu...@intel.com + + * config/abi/post/x86_64-linux-gnu

PATCH: PR bootstrap/61914: [4.10 Regression] wide-int change breaks bootstrap

2014-07-28 Thread H.J. Lu
H.J. Lu hongjiu...@intel.com PR bootstrap/61914 * gengtype.c (strtoken): New function. (create_user_defined_type): Replace strtok with strtoken. diff --git a/gcc/gengtype.c b/gcc/gengtype.c index ffe3f94..e66941b 100644 --- a/gcc/gengtype.c +++ b/gcc/gengtype.c @@ -569,6

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-11 Thread H.J. Lu
On Mon, Nov 10, 2014 at 11:42 AM, H.J. Lu hjl.to...@gmail.com wrote: On Mon, Nov 10, 2014 at 5:44 AM, Richard Biener richard.guent...@gmail.com wrote: On Mon, Nov 10, 2014 at 2:43 PM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Nov 10, 2014 at 05:32:32AM -0800, H.J. Lu wrote: On Mon, Nov 10

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-11 Thread H.J. Lu
On Tue, Nov 11, 2014 at 10:49 AM, Andi Kleen a...@firstfloor.org wrote: Joseph Myers jos...@codesourcery.com writes: On Tue, 11 Nov 2014, Ilya Enkovich wrote: Hi, This patch integrates MPX runtime library into GCC source tree. MPX runtime is responsible for initialization of MPX feature

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-11 Thread H.J. Lu
On Tue, Nov 11, 2014 at 1:01 PM, Andi Kleen a...@firstfloor.org wrote: It is similar to libsanitizer. Put it in glibc isn't going to work well for MPX. Can you explain it more please? Are you suggesting putting MPX run-time in glibc? Will we have 2 glibc, one with MPX run-time and one

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-11 Thread H.J. Lu
On Tue, Nov 11, 2014 at 1:33 PM, Joseph Myers jos...@codesourcery.com wrote: On Tue, 11 Nov 2014, Andi Kleen wrote: On Tue, Nov 11, 2014 at 01:04:42PM -0800, H.J. Lu wrote: On Tue, Nov 11, 2014 at 1:01 PM, Andi Kleen a...@firstfloor.org wrote: It is similar to libsanitizer. Put

Re: [PATCHv2] Don't expand string/memory builtins if ASan is enabled.

2014-11-11 Thread H.J. Lu
On Tue, Oct 28, 2014 at 1:21 AM, Maxim Ostapenko m.ostape...@partner.samsung.com wrote: The code which identifies interceptors seems to be duplicated in expand_builtin. What about factoring this out to some is_asan_intercepted() in asan.h? I agree. Fixed this. BTW, when you handle a

Re: Track dynamic type changes

2014-11-11 Thread H.J. Lu
On Sun, Oct 5, 2014 at 9:34 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, this patch makes ipa_polymorphic_call_context::get_dynamic_type to track if vptr has changed in between function entry and polymorphic call. The patch also add logic skipping if (a==0) checks in multiple inheritance so I

PATCH: PR testsuite/63830: c-c++-common/asan/strlen-overflow-1.c fails on x32

2014-11-11 Thread H.J. Lu
Hi, This patch updates c-c++-common/asan/strlen-overflow-1.c to avoid tail call on x32. Tested on Linux/x86-64/ia32/x32. OK to install? Thanks. H.J. --- 2014-11-11 H.J. Lu hongjiu...@intel.com PR testsuite/63830 * c-c++-common/asan/strlen-overflow-1.c (main): Avoid tail

Re: [PATCH] Fix dump scan in test devirt-40.C

2014-11-11 Thread H.J. Lu
On Tue, Nov 4, 2014 at 7:54 AM, Jiong Wang jiong.w...@arm.com wrote: On 04/11/14 15:51, Paolo Carlini wrote: Hi, On 11/04/2014 04:37 PM, Martin Jambor wrote: Hi, since revision 216728, testsuite/g++.dg/ipa/devirt-40.C is failing because although the tested-for devirtualization does

PATCH: PR target/63833: REAL_PIC_OFFSET_TABLE_REGNUM is wrong for x86-64

2014-11-12 Thread H.J. Lu
-bit large model. OK to install? Thanks. H.J. --- 2014-11-12 H.J. Lu hongjiu...@intel.com PR target/63833 * config/i386/i386.h (REAL_PIC_OFFSET_TABLE_REGNUM): Use R15_REG for 64-bit. * config/i386/rdos64.h (REAL_PIC_OFFSET_TABLE_REGNUM): Removed. diff --git

Re: [PATCHv5][Kasan] Allow to override Asan shadow offset from command line

2014-11-12 Thread H.J. Lu
On Wed, Nov 5, 2014 at 6:50 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hello, On 24 Oct 17:56, Yury Gribov wrote: ... +const struct test_data_t test_data[] = { + { STRTOL, -0x8000, 0, -0x8000L, 0 }, ... + switch (test_data[i].fun) + { + case STRTOL: +

PATCH: PR tree-optimization/63828: [5 Regression] g++.dg/ipa/devirt-47.C fails for x32

2014-11-12 Thread H.J. Lu
-12 H.J. Lu hongjiu...@intel.com PR tree-optimization/63828 * ipa-polymorphic-call.c (possible_placement_new): Check POINTER_SIZE, instead of BITS_PER_WORD, for pointer size. diff --git a/gcc/ipa-polymorphic-call.c b/gcc/ipa-polymorphic-call.c index 33dd1a8..30b5db2 100644

Re: [PATCH][17/n] Merge from match-and-simplify, plus/minus association patterns

2014-11-12 Thread H.J. Lu
On Tue, Nov 11, 2014 at 5:13 AM, Richard Biener rguent...@suse.de wrote: This merges patterns from associate_plusminus and adjusts them with details from their fold-const.c pendants. It also fixes missing flag_sanitize checks on negate contraction on the way. This shows places where folds

Re: [PATCH][17/n] Merge from match-and-simplify, plus/minus association patterns

2014-11-12 Thread H.J. Lu
On Wed, Nov 12, 2014 at 9:55 AM, H.J. Lu hjl.to...@gmail.com wrote: On Tue, Nov 11, 2014 at 5:13 AM, Richard Biener rguent...@suse.de wrote: This merges patterns from associate_plusminus and adjusts them with details from their fold-const.c pendants. It also fixes missing flag_sanitize

PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread H.J. Lu
thunk with random value in hardcoded PIC register. After r216154, compiler crashes. This patch sets PIC register to %r11 and initialize it. Tested on Linux/x86-64. OK for trunk and backport to 4.8/4.9 branches? Thanks. H.J. --- gcc/ 2014-11-12 H.J. Lu hongjiu...@intel.com PR

Re: PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread H.J. Lu
On Wed, Nov 12, 2014 at 1:02 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 12, 2014 at 12:43:17PM -0800, H.J. Lu wrote: @@ -42686,8 +42692,12 @@ x86_output_mi_thunk (FILE *file, tree, HOST_WIDE_INT delta, else { if (ix86_cmodel == CM_LARGE_PIC SYMBOLIC_CONST (fnaddr

Re: PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread H.J. Lu
On Wed, Nov 12, 2014 at 1:39 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 12, 2014 at 01:11:40PM -0800, H.J. Lu wrote: On Wed, Nov 12, 2014 at 1:02 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 12, 2014 at 12:43:17PM -0800, H.J. Lu wrote: @@ -42686,8 +42692,12

Re: PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread H.J. Lu
On Wed, Nov 12, 2014 at 2:00 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 12, 2014 at 01:51:01PM -0800, H.J. Lu wrote: So, all in all, SET_REGNO sounds inappropriate to me, everywhere else gen_raw_REG or gen_rtx_REG is used instead, so IMNSHO you should do the same

Re: [PATCH][12/n] Merge from match-and-simplify, pointer-plus patterns and forwprop re-org

2014-11-12 Thread H.J. Lu
On Fri, Nov 7, 2014 at 12:53 AM, Richard Biener rguent...@suse.de wrote: This interleaves stmt folding and manual simplifications done in forwprop into a single loop over all basic-blocks. It somewhat complicates things as we need to make sure the lattice stays valid when releasing SSA names

Re: [RTL, Patch] Int div by constant compilation enhancement

2014-11-12 Thread H.J. Lu
On Mon, Nov 3, 2014 at 9:01 AM, Alex Velenko alex.vele...@arm.com wrote: Hi, This patch adds a mid-end check to catch division by constant case and optimize it to generate one shift, instead of two. A testacase to check the correct codegeneration for aarch64 is added. This check is not made

Re: Updated LRA rematerialization patch has been committed

2014-11-12 Thread H.J. Lu
On Wed, Nov 12, 2014 at 7:08 PM, Vladimir Makarov vmaka...@redhat.com wrote: After submitting LRA rematerialization patch, I got a lot of feedback. Some people reported performance degradation and pointed me out the most important problem which looks like p0 - p1 + p2

Re: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

2014-11-13 Thread H.J. Lu
On Wed, Nov 5, 2014 at 7:17 AM, Zamyatin, Igor igor.zamya...@intel.com wrote: Hi! Following patch (moving initialization of pic_offset_table_rtx earlier) fixes failures for asan tests on 32 bits in PIC mode mentioned here - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63534#c48

PATCH: PR gas/17598: R_X86_64_GOTPLT64 relocation isn't tested

2014-11-13 Thread H.J. Lu
/ChangeLog @@ -1,3 +1,10 @@ +2014-11-13 H.J. Lu hongjiu...@intel.com + + PR gas/17598 + * elf64-x86-64.c (elf_x86_64_check_relocs): Treat + R_X86_64_GOTPLT64 the same as R_X86_64_GOT64. + (elf_x86_64_relocate_section): Likewise. + 2014-11-13 Nick Clifton ni...@redhat.com

Re: PATCH: PR gas/17598: R_X86_64_GOTPLT64 relocation isn't tested

2014-11-13 Thread H.J. Lu
On Thu, Nov 13, 2014 at 11:13 AM, H.J. Lu hongjiu...@intel.com wrote: Hi, R_X86_64_GOTPLT64 isn't necessary and R_X86_64_GOT64 should be used instead. I checked in this patch to add assembler support for @gotplt, but treat R_X86_64_GOTPLT64 the same R_X86_64_GOT64. There should

Re: [PATCH 3/5] IPA ICF pass

2014-11-13 Thread H.J. Lu
On Wed, Oct 15, 2014 at 10:03 AM, Martin Liška mli...@suse.cz wrote: Hello There's final version of the patch I'm going to commit tomorrow in the morning (CEST). Thank you Honza for the review. Martin This caused: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63856 -- H.J.

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-13 Thread H.J. Lu
On Tue, Nov 11, 2014 at 8:02 AM, H.J. Lu hjl.to...@gmail.com wrote: On Mon, Nov 10, 2014 at 11:42 AM, H.J. Lu hjl.to...@gmail.com wrote: On Mon, Nov 10, 2014 at 5:44 AM, Richard Biener richard.guent...@gmail.com wrote: On Mon, Nov 10, 2014 at 2:43 PM, Jakub Jelinek ja...@redhat.com wrote

Re: [Android] Enable ifuncs on Android

2014-11-13 Thread H.J. Lu
On Thu, Nov 13, 2014 at 8:27 PM, Andrew Hsieh andrewhs...@google.com wrote: What about overloading the existing option -mbionic ? -mbionic=21 and above enable ifunc (so NDK can help enforce it) On Fri, Nov 14, 2014 at 11:51 AM, enh e...@google.com wrote: On Thu, Nov 13, 2014 at 5:12 PM, Jeff

Re: [Android] Enable ifuncs on Android

2014-11-13 Thread H.J. Lu
On Thu, Nov 13, 2014 at 9:36 AM, Jeff Law l...@redhat.com wrote: On 11/12/14 03:02, Alexander Ivchenko wrote: Hi, Bionic - Android libc - supports indirect functions right now, but they are disabled in gcc; We cannot do the configure-time check for that, because there is only one version

Re: [Android] Enable ifuncs on Android

2014-11-13 Thread H.J. Lu
On Thu, Nov 13, 2014 at 8:46 PM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Nov 13, 2014 at 9:36 AM, Jeff Law l...@redhat.com wrote: On 11/12/14 03:02, Alexander Ivchenko wrote: Hi, Bionic - Android libc - supports indirect functions right now, but they are disabled in gcc; We cannot do

Re: [Android] Enable ifuncs on Android

2014-11-13 Thread H.J. Lu
On Thu, Nov 13, 2014 at 8:59 PM, Jeff Law l...@redhat.com wrote: On 11/13/14 21:46, H.J. Lu wrote: Hi Jeff, I believe the patch is correct. Not all glibcs support IFUNC. It doesn't mean we should disable IFUNC for all glibcs. By default, we do a configure time check for IFUNC. We DO

PATCH: Don't assume modern glibc for x86 Android targets

2014-11-13 Thread H.J. Lu
for i686-linux-android and x86_64-linux-android. OK for trunk? Thanks. H.J. 2014-11-13 H.J. Lu hongjiu...@intel.com * config.gcc (default_gnu_indirect_function): Don't assume modern glibc for i[34567]86-*-linux* and x86_64-*-linux* when targeting Android. diff --git

Re: PATCH: Don't assume modern glibc for x86 Android targets

2014-11-14 Thread H.J. Lu
On Thu, Nov 13, 2014 at 09:32:07PM -0800, H.J. Lu wrote: For i[34567]86-*-linux* and x86_64-*-linux* targets, config.gcc assumes modern glibc and set default_gnu_indirect_function to yes. That is wrong for i[34567]86-*-linux-android* and x86_64-*-linux-android* targets. This patch fixes

Re: PATCH: Don't assume modern glibc for x86 Android targets

2014-11-14 Thread H.J. Lu
On Fri, Nov 14, 2014 at 7:10 AM, Alexander Ivchenko aivch...@gmail.com wrote: should we also change this comment in gcc/configure? --enable-gnu-indirect-function enable the use of the @gnu_indirect_function to glibc systems That will be a

Re: PATCH: Don't assume modern glibc for x86 Android targets

2014-11-14 Thread H.J. Lu
On Fri, Nov 14, 2014 at 7:51 AM, Uros Bizjak ubiz...@gmail.com wrote: On Fri, Nov 14, 2014 at 3:38 PM, H.J. Lu hongjiu...@intel.com wrote: On Thu, Nov 13, 2014 at 09:32:07PM -0800, H.J. Lu wrote: For i[34567]86-*-linux* and x86_64-*-linux* targets, config.gcc assumes modern glibc and set

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-14 Thread H.J. Lu
On Fri, Nov 14, 2014 at 8:07 AM, Ilya Verbin iver...@gmail.com wrote: Resending to gcc-patches@gcc.gnu.org Hi, This patch fixes recent regressions in libgomp testsuite: https://gcc.gnu.org/ml/gcc-regression/2014-11/msg00343.html They are reproducible only with ld from trunk, ld 2.24 works

Re: [Android] Enable ifuncs on Android

2014-11-14 Thread H.J. Lu
On Thu, Nov 13, 2014 at 8:59 PM, Jeff Law l...@redhat.com wrote: On 11/13/14 21:46, H.J. Lu wrote: Hi Jeff, I believe the patch is correct. Not all glibcs support IFUNC. It doesn't mean we should disable IFUNC for all glibcs. By default, we do a configure time check for IFUNC. We DO

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-14 Thread H.J. Lu
On Fri, Nov 14, 2014 at 8:51 AM, Ilya Verbin iver...@gmail.com wrote: On 14 Nov 08:46, H.J. Lu wrote: What happens when -flto is used on command line? Will we generate both LTO IR and offload IR? Right. I'm not sure whether we should make slim objects in case of LTO + offload IR

Re: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

2014-11-14 Thread H.J. Lu
On Fri, Nov 14, 2014 at 8:59 AM, Zamyatin, Igor igor.zamya...@intel.com wrote: ChangeLog: 2014-10-30 Igor Zamyatin igor.zamya...@intel.com * function.c (assign_parms): Move init of pic_offset_table_rtx from here to... * cfgexpand.c (expand_used_vars): ...here.

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-14 Thread H.J. Lu
On Fri, Nov 14, 2014 at 9:08 AM, Ilya Verbin iver...@gmail.com wrote: On 14 Nov 09:01, H.J. Lu wrote: On Fri, Nov 14, 2014 at 8:51 AM, Ilya Verbin iver...@gmail.com wrote: On 14 Nov 08:46, H.J. Lu wrote: What happens when -flto is used on command line? Will we generate both LTO IR

Re: Type inheritance graph analysis speculative devirtualization, part 7/7 (speculative devirtualizatoin)

2014-11-14 Thread H.J. Lu
On Sun, Sep 1, 2013 at 6:57 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, this patch implement speculative devirtualization. It is a trivial pass that asks for targets of every polymorphic call in a program and if the list contains one likely target, it produces an speculative call. No context

Re: patch switching on LRA remat

2014-11-15 Thread H.J. Lu
On Fri, Nov 14, 2014 at 12:07 PM, Vladimir Makarov vmaka...@redhat.com wrote: The LRA rematerialization patch I've submitted about day ago broke H.J.'s 32-bit bootstrap. So I switched off the rematerialization right away. The set for bootstrapping used by H.J. was very useful. I've fixed

PATCH: PR bootstrap/63888: [5 Regression] bootstrap failed when configured with -with-build-config=bootstrap-asan --disable-werror

2014-11-15 Thread H.J. Lu
set ASAN_OPTIONS=detect_odr_violation=0 SUMMARY: AddressSanitizer: odr-violation: global 'CSWTCH.2819' at /export/gnu/import/git/sources/gcc/gcc/tree-vrp.c:4056:7 ==14370==ABORTING H.J. --- 2014-11-15 H.J. Lu hongjiu...@intel.com PR bootstrap/63888 * bootstrap-asan.mk

Re: patch switching on LRA remat

2014-11-15 Thread H.J. Lu
On Sat, Nov 15, 2014 at 9:07 AM, Vladimir Makarov vmaka...@redhat.com wrote: On 2014-11-15 9:58 AM, H.J. Lu wrote: On Fri, Nov 14, 2014 at 12:07 PM, Vladimir Makarov vmaka...@redhat.com wrote: The LRA rematerialization patch I've submitted about day ago broke H.J.'s 32-bit bootstrap. So

Re: [committed,testsuite] Not run gcc.target/i386/sibcall-1.c on PIC targets

2014-11-15 Thread H.J. Lu
On Sat, Nov 15, 2014 at 11:46 AM, FX fxcoud...@gmail.com wrote: Don’t run gcc.target/i386/sibcall-1.c on PIC targets. 2014-11-15 Francois-Xavier Coudert fxcoud...@gcc.gnu.org PR target/60104 * gcc.target/i386/sibcall-1.c: Don't run on pic targets. Index:

Re: [committed,testsuite] Not run gcc.target/i386/sibcall-1.c on PIC targets

2014-11-15 Thread H.J. Lu
On Sat, Nov 15, 2014 at 12:22 PM, FX fxcoud...@gmail.com wrote: This looks wrong. This test should pass for 64-bit or ia32 nonpic. It was Kai’s original testcase, so I don’t want to modify it too much, other than make it skip where it clearly fails. Original bug report was filed against

Re: [PATCH] Fix gimple_fold_stmt_to_constant regression

2014-11-15 Thread H.J. Lu
On Fri, Nov 14, 2014 at 4:39 AM, Richard Biener rguent...@suse.de wrote: Following up https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01233.html and fixing the regressions this caused as soon as I removed the dispatch to fold_unary (and more regressions it would have caused if I managed to

Re: [PATCH] Add testcase for PR 63894

2014-11-17 Thread H.J. Lu
A +{ + void *operator new(unsigned long, int); This failed on ILP32 targets. I checked in this patch to fix it: Index: ChangeLog === --- ChangeLog (revision 217653) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2014-11-17 H.J. Lu

Re: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4 (fix s390 build)

2014-11-17 Thread H.J. Lu
On Wed, Nov 12, 2014 at 11:49 PM, Zhenqiang Chen zhenqiang.c...@arm.com wrote: -Original Message- From: Richard Henderson [mailto:r...@redhat.com] Sent: Thursday, November 06, 2014 4:23 PM To: Zhenqiang Chen; 'Jan-Benedict Glaw'; Hartmut Penner; Ulrich Weigand; Andreas Krebbel Cc:

Re: [PATCH] Add memory barriers to xbegin/xend/xabort

2014-11-17 Thread H.J. Lu
On Wed, Oct 29, 2014 at 11:07 PM, Andi Kleen a...@linux.intel.com wrote: Hmm, can't the insns themselves properly clobber/use memory? The transactions don't really use the memory. They just guard it, like a lock. So the intrinsic doesn't know what memory is used inside the transaction, but

Re: [PATCH] Add memory barriers to xbegin/xend/xabort

2014-11-17 Thread H.J. Lu
On Mon, Nov 17, 2014 at 12:36 PM, Andi Kleen a...@firstfloor.org wrote: H.J. Lu hjl.to...@gmail.com writes: On Wed, Oct 29, 2014 at 11:07 PM, Andi Kleen a...@linux.intel.com wrote: Hmm, can't the insns themselves properly clobber/use memory? The transactions don't really use the memory

Re: Stream out default optimization nodes

2014-11-18 Thread H.J. Lu
On Mon, Nov 17, 2014 at 10:38 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, this patch makes us to store default optimization node same way as we stream target node. This means that command line options given at compile time prevail those given at linktime. Previously we sort of combined both.

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-18 Thread H.J. Lu
On Fri, Nov 14, 2014 at 2:19 AM, Richard Biener richard.guent...@gmail.com wrote: On Fri, Nov 14, 2014 at 12:15 AM, H.J. Lu hjl.to...@gmail.com wrote: On Tue, Nov 11, 2014 at 8:02 AM, H.J. Lu hjl.to...@gmail.com wrote: On Mon, Nov 10, 2014 at 11:42 AM, H.J. Lu hjl.to...@gmail.com wrote: On Mon

Re: Stream out default optimization nodes

2014-11-18 Thread H.J. Lu
On Tue, Nov 18, 2014 at 9:27 AM, Jan Hubicka hubi...@ucw.cz wrote: https://gcc.gnu.org/ml/gcc-regression/2014-11/msg00473.html /export/gnu/import/git/gcc-test-profiled/bld/./prev-gcc/xg++ -B/export/gnu/import/git/gcc-test-profiled/bld/./prev-gcc/ -B/usr/5.0.0/x86_64-unknown-linux-gnu/bin/

Re: [PATCH] Simple improvement for predicate computation in if-convert phase.

2014-11-18 Thread H.J. Lu
On Fri, Oct 17, 2014 at 6:08 AM, Yuri Rumyantsev ysrum...@gmail.com wrote: Jeff, I prepared another patch that includes test-case as you requested. Below are answers on your questions. First, for the benefit of anyone trying to understand what you're doing, defining what cd equivalent

Re: Stream out default optimization nodes

2014-11-19 Thread H.J. Lu
On Tue, Nov 18, 2014 at 9:29 AM, Jan Hubicka hubi...@ucw.cz wrote: On Tue, Nov 18, 2014 at 9:27 AM, Jan Hubicka hubi...@ucw.cz wrote: https://gcc.gnu.org/ml/gcc-regression/2014-11/msg00473.html /export/gnu/import/git/gcc-test-profiled/bld/./prev-gcc/xg++

Re: Drop target_option_node reconstruction logic.

2014-11-19 Thread H.J. Lu
On Fri, Nov 14, 2014 at 11:13 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, this patch kills lto's code to rebuilt DECL_FUNCTION_SPECIFIC_TARGET from target attributes. This code was never complete and it should be no-op now when we save tehe target nodes. It also makes

Re: Avoid applying inline plan for all functions ahead of late compilation

2014-11-19 Thread H.J. Lu
On Sat, Nov 15, 2014 at 11:15 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, late in GCC 4.9 development we broke the feature that ltrans stages do not read all functions in ahead. This is because of late IPA passes that do not like to see functions without IPA transformations applied. I was

Re: [PATCH 3/9] fibonacci_heap is used for bb-reoder purpose.

2014-11-19 Thread H.J. Lu
On Wed, Nov 12, 2014 at 5:45 PM, mliska mli...@suse.cz wrote: gcc/ChangeLog: 2014-11-13 Martin Liska mli...@suse.cz * bb-reorder.c (mark_bb_visited): New fibonacci_heap is used. (find_traces): Likewise. (find_traces_1_round): Likewise. This caused:

Re: Drop target_option_node reconstruction logic.

2014-11-19 Thread H.J. Lu
On Wed, Nov 19, 2014 at 10:11 AM, Jan Hubicka hubi...@ucw.cz wrote: On Fri, Nov 14, 2014 at 11:13 AM, Jan Hubicka hubi...@ucw.cz wrote: nz Hi, this patch kills lto's code to rebuilt DECL_FUNCTION_SPECIFIC_TARGET from target attributes. This code was never complete and it should be

Re: [COMMITTED 1/3] Make TARGET_STATIC_CHAIN allow a function type

2014-11-19 Thread H.J. Lu
On Wed, Nov 19, 2014 at 10:04 AM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 19, 2014 at 03:58:50PM +0100, Richard Henderson wrote: As opposed to always being a decl. This is a prerequisite to allowing the static chain to be loaded for indirect calls. * targhooks.c

Re: [PATCH/IPA] Fix ipa-polymorphic-call when size of Pmode is not the size of pointers in user code

2014-11-19 Thread H.J. Lu
On Wed, Nov 19, 2014 at 4:54 PM, Andrew Pinski pins...@gmail.com wrote: Hi, For ILP32 on AARCH64, we have ptr_mode != Pmode (we have ptr_mode being SImode while Pmode is DImode and POINTER_SIZE is 32). This breaks ipa-polymorphic-call assumption that Pmode is the correct mode for pointers.

Re: [PATCH/IPA] Fix ipa-polymorphic-call when size of Pmode is not the size of pointers in user code

2014-11-19 Thread H.J. Lu
On Wed, Nov 19, 2014 at 5:23 PM, Andrew Pinski pins...@gmail.com wrote: On Wed, Nov 19, 2014 at 5:11 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Nov 19, 2014 at 4:54 PM, Andrew Pinski pins...@gmail.com wrote: Hi, For ILP32 on AARCH64, we have ptr_mode != Pmode (we have ptr_mode being

Re: [PATCH/IPA] Fix ipa-polymorphic-call when size of Pmode is not the size of pointers in user code

2014-11-19 Thread H.J. Lu
On Wed, Nov 19, 2014 at 5:36 PM, Andrew Pinski pins...@gmail.com wrote: On Wed, Nov 19, 2014 at 5:35 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Nov 19, 2014 at 5:23 PM, Andrew Pinski pins...@gmail.com wrote: On Wed, Nov 19, 2014 at 5:11 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Nov 19

Re: [PATCH/IPA] Fix ipa-polymorphic-call when size of Pmode is not the size of pointers in user code

2014-11-19 Thread H.J. Lu
On Wed, Nov 19, 2014 at 5:39 PM, Andrew Pinski pins...@gmail.com wrote: On Wed, Nov 19, 2014 at 5:37 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Nov 19, 2014 at 5:36 PM, Andrew Pinski pins...@gmail.com wrote: On Wed, Nov 19, 2014 at 5:35 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Nov 19

Re: [PATCH/IPA] Fix ipa-polymorphic-call when size of Pmode is not the size of pointers in user code

2014-11-19 Thread H.J. Lu
On Wed, Nov 19, 2014 at 5:55 PM, Andrew Pinski pins...@gmail.com wrote: On Wed, Nov 19, 2014 at 5:53 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Nov 19, 2014 at 5:39 PM, Andrew Pinski pins...@gmail.com wrote: On Wed, Nov 19, 2014 at 5:37 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Nov 19

Re: [PATCH, ifcvt] Fix PR63917

2014-11-20 Thread H.J. Lu
On Thu, Nov 20, 2014 at 1:48 AM, Zhenqiang Chen zhenqiang.c...@arm.com wrote: Hi, r217646 enhances ifcvt to handle cbranchcc4 instruction. But ifcvt does not strictly check the dependence before moving instructions before IF. Then some instructions, which clobber CC, are inserted before the

Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-21 Thread H.J. Lu
On Fri, Nov 21, 2014 at 1:08 PM, Ilya Verbin iver...@gmail.com wrote: On 21 Nov 2014, at 23:36, Jakub Jelinek ja...@redhat.com wrote: On Fri, Nov 21, 2014 at 11:19:26PM +0300, Ilya Verbin wrote: Hi, '#pragma omp critical (name)' can be placed in the function, marked with '#pragma omp

Re: Fix vectorizer conditions on updating alignment

2014-11-22 Thread H.J. Lu
On Thu, Jun 12, 2014 at 3:14 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, while updating vect_can_force_dr_alignment_p for section API I noticed the predicate is bit confused about when it can update the alignment. We need to check that decl_binds_to_current_def_p and in case we compile a

Re: Localize symbols used only from comdat groups

2014-11-23 Thread H.J. Lu
On Sun, May 18, 2014 at 4:56 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, this patch adds simple IPA pass that brings symbols used only from comdat groups into the groups. This prevents dead code in cases where the comdat group is replaced by a copy from different unit. The patch saves about

Re: [Patch, Fortran] Remove gfc_fatal_error_1

2014-11-24 Thread H.J. Lu
On Sun, Nov 23, 2014 at 12:21 PM, Tobias Burnus bur...@net-b.de wrote: This patch depends on Manuel's %L patch. It converts the remaining fatal error calls to the common diagnostic infrastructure and retires (removes) the old gfc_fatal_error_1. I will build and regtest it after Manuel's

Re: [PATCH] Improve i?86 address delegitimization after 32-bit pic changes (PR target/63542)

2014-11-24 Thread H.J. Lu
On Tue, Oct 21, 2014 at 9:03 AM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Sep 29, 2014 at 01:08:56PM +0200, Jakub Jelinek wrote: I wonder if during/after reload we just couldn't look at ORIGINAL_REGNO of hard regs if ix86_use_pseudo_pic_reg. Or is that the other case, where you don't

Re: Track dynamic type changes

2014-11-24 Thread H.J. Lu
On Sun, Oct 5, 2014 at 9:34 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, this patch makes ipa_polymorphic_call_context::get_dynamic_type to track if vptr has changed in between function entry and polymorphic call. The patch also add logic skipping if (a==0) checks in multiple inheritance so I

Re: Pushing recent libtool fix to binutils-gdb and newlib/libgloss

2014-11-24 Thread H.J. Lu
Done: https://sourceware.org/ml/binutils/2014-11/msg00318.html On Mon, Nov 24, 2014 at 9:04 AM, FX fxcoud...@gmail.com wrote: *ping* Didn’t get any response to my question so far… Thanks everyone for the comments and review. Committed as r217366 I cannot push the change to binutils-gdb

Re: [PATCH] Fix dump scan in test devirt-40.C

2014-11-24 Thread H.J. Lu
On Mon, Nov 24, 2014 at 10:41 AM, Paolo Carlini paolo.carl...@oracle.com wrote: Hi again, On 11/24/2014 07:33 PM, Paolo Carlini wrote: Hi, On 11/12/2014 03:02 AM, H.J. Lu wrote: I am checking in this. Looks like devirt-42.C is failing again and reverting your tweak would fix

Re: [PATCH 9/9] ipa-inline uses sreal for as fibonacci_heap template argument.

2014-11-24 Thread H.J. Lu
On Thu, Nov 13, 2014 at 12:10 PM, mliska mli...@suse.cz wrote: gcc/ChangeLog: 2014-11-13 Martin Liska mli...@suse.cz * ipa-inline.c (edge_badness): long is replaced by sreal as fibonacci_heap template type. (update_edge_key): Likewise.

Re: patch to fix PR63897

2014-11-24 Thread H.J. Lu
On Fri, Nov 21, 2014 at 1:32 PM, Vladimir Makarov vmaka...@redhat.com wrote: The following patch fixes PR63897. The details can be found on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63897 The patch was successfully bootstrapped and tested on x86 and x86-64. Committed as rev. 217947.

PATCH: PR rtl-optimization/64037: Miscompilation with -Os and enum class : char parameter

2014-11-25 Thread H.J. Lu
Hi, The enclosed testcase fails on x86 when compiled with -Os since we pass a byte parameter with a byte load in caller and read it as an int in callee. The reason it only shows up with -Os is x86 backend encodes a byte load with an int load if -O isn't used. When a byte load is used, the upper

Re: PATCH: PR rtl-optimization/64037: Miscompilation with -Os and enum class : char parameter

2014-11-25 Thread H.J. Lu
On Tue, Nov 25, 2014 at 7:01 AM, Richard Biener richard.guent...@gmail.com wrote: On Tue, Nov 25, 2014 at 1:57 PM, H.J. Lu hongjiu...@intel.com wrote: Hi, The enclosed testcase fails on x86 when compiled with -Os since we pass a byte parameter with a byte load in caller and read it as an int

Re: PATCH: PR rtl-optimization/64037: Miscompilation with -Os and enum class : char parameter

2014-11-25 Thread H.J. Lu
On Tue, Nov 25, 2014 at 7:04 AM, Richard Biener richard.guent...@gmail.com wrote: On Tue, Nov 25, 2014 at 4:01 PM, Richard Biener richard.guent...@gmail.com wrote: On Tue, Nov 25, 2014 at 1:57 PM, H.J. Lu hongjiu...@intel.com wrote: Hi, The enclosed testcase fails on x86 when compiled

Re: patch to fix PR63527

2014-11-25 Thread H.J. Lu
checked in this testcase. Thanks. -- H.J. --- Index: ChangeLog === --- ChangeLog (revision 218060) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2014-11-25 H.J. Lu hongjiu...@intel.com + + PR target/63527 + * gcc.target/i386/pr63527

Re: patch to fix PR63527

2014-11-25 Thread H.J. Lu
On Tue, Nov 25, 2014 at 12:54 PM, H.J. Lu hjl.to...@gmail.com wrote: On Tue, Nov 25, 2014 at 12:22 PM, Vladimir Makarov vmaka...@redhat.com wrote: The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63527 The patch was tested and bootstrapped on x86/x86-64. Committed

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 1/5] Builtin codes and decls

2014-11-25 Thread H.J. Lu
On Thu, Nov 6, 2014 at 3:48 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This is the first patch in a series to enable builtin function calls instrumentation by Poitner Bounds Checker. Previously builtins instrumentation was disabled in checker because it allowed two function calls

Re: More weakref fixes

2014-11-25 Thread H.J. Lu
On Fri, Aug 30, 2013 at 8:54 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, this patch fixes gcc.dg/tree-ssa/attr-alias.c on x86-64 target. The problem here is that we attempt to create local alias since we consider weakref of test() to be overwritable and at the same time available. The change

Re: [PATCH] Fix PR lto/64075

2014-11-26 Thread H.J. Lu
On Wed, Nov 26, 2014 at 1:35 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes LTO streamers which were not adjusted when function_code field was extended up to 12 bits. OK for trunk after bootstrap and check? Thanks, Ilya -- gcc/ 2014-11-26 Ilya Enkovich

Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes GCC generates UNPREDICTABLE STR with Rn = Rt for arm

2014-11-26 Thread H.J. Lu
On Wed, Nov 26, 2014 at 4:07 AM, Renlin Li renlin...@arm.com wrote: On 20/11/14 16:17, Renlin Li wrote: Hi all, This is a backport for gcc-4_9-branch of the patch [PR63762]GCC generates UNPREDICTABLE STR with Rn = Rt for arm posted in:

Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes GCC generates UNPREDICTABLE STR with Rn = Rt for arm

2014-11-26 Thread H.J. Lu
On Wed, Nov 26, 2014 at 10:09 AM, Renlin Li renlin...@arm.com wrote: On 26/11/14 12:16, H.J. Lu wrote: On Wed, Nov 26, 2014 at 4:07 AM, Renlin Li renlin...@arm.com wrote: On 20/11/14 16:17, Renlin Li wrote: Hi all, This is a backport for gcc-4_9-branch of the patch [PR63762]GCC generates

Re: patch to fix PR63897

2014-11-26 Thread H.J. Lu
On Mon, Nov 24, 2014 at 4:23 PM, H.J. Lu hjl.to...@gmail.com wrote: On Fri, Nov 21, 2014 at 1:32 PM, Vladimir Makarov vmaka...@redhat.com wrote: The following patch fixes PR63897. The details can be found on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63897 The patch was successfully

Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes GCC generates UNPREDICTABLE STR with Rn = Rt for arm

2014-11-27 Thread H.J. Lu
On Thu, Nov 27, 2014 at 7:32 AM, Renlin Li renlin...@arm.com wrote: On 26/11/14 18:12, H.J. Lu wrote: On Wed, Nov 26, 2014 at 10:09 AM, Renlin Li renlin...@arm.com wrote: On 26/11/14 12:16, H.J. Lu wrote: On Wed, Nov 26, 2014 at 4:07 AM, Renlin Li renlin...@arm.com wrote: On 20/11/14 16

Re: [patch c++]: Fix PR/53904

2014-11-27 Thread H.J. Lu
On Wed, Nov 26, 2014 at 9:52 AM, Kai Tietz ktiet...@googlemail.com wrote: Ok. Adjusted patch attached. Nevertheless we should use here unsigned HWI instead of possible truncation to signed int. I admit that it is unlikely to have more then 2^31 elements, but well Ok for apply with

Re: PATCH: PR target/63833: REAL_PIC_OFFSET_TABLE_REGNUM is wrong for x86-64

2014-11-27 Thread H.J. Lu
On Wed, Nov 12, 2014 at 6:53 AM, H.J. Lu hongjiu...@intel.com wrote: We have been using the wrong register to hold GOT in 64-bit large model, which is used by the large model PLT. The only reason we haven't run into any problem is linker doesn't support the large model PLT. I am looking

Re: [RFC PATCH, i386]: Prefer %ebx in set_got patterns

2014-11-27 Thread H.J. Lu
On Thu, Nov 27, 2014 at 3:19 AM, Uros Bizjak ubiz...@gmail.com wrote: Hello! Attached patch helps RA to choose the most appropriate PIC register by changing the register preference for set_got patterns. Using this patch, there should really be a reason for RA to avoid ABI mandated hard PIC

Re: [COMMITTED][PATCH, 2/2] shrink wrap a function with a single loop: split live_edge

2014-09-26 Thread H.J. Lu
On Thu, Sep 25, 2014 at 9:43 AM, Jiong Wang jiong.w...@arm.com wrote: On 25/09/14 17:24, Jeff Law wrote: On 09/25/14 09:04, Jiong Wang wrote: new patch updated. pass bootstrap and no regression, both check-gcc and check-g++, on the x86. OK for trunk? thanks. gcc/ *

Re: [COMMITTED][PATCH, 2/2] shrink wrap a function with a single loop: split live_edge

2014-09-26 Thread H.J. Lu
On Fri, Sep 26, 2014 at 8:14 AM, Jiong Wang jiong.w...@arm.com wrote: On 26/09/14 16:05, H.J. Lu wrote: On Thu, Sep 25, 2014 at 9:43 AM, Jiong Wang jiong.w...@arm.com wrote: On 25/09/14 17:24, Jeff Law wrote: On 09/25/14 09:04, Jiong Wang wrote: new patch updated. pass bootstrap

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread H.J. Lu
On Tue, Sep 30, 2014 at 9:47 AM, Evgeny Stupachenko evstu...@gmail.com wrote: Hi, Patch resubmitted from https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01400.html The patch fix PR62128 and gcc.target/i386/pr52252-atom.c in core-avx2 make check. The test in pr62128 is exactly TEST 22 from

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread H.J. Lu
On Wed, Oct 1, 2014 at 8:29 AM, Teresa Johnson tejohn...@google.com wrote: I got the preprocessed source. With the aarch64 cross-compiler I built I am able to reproduce the ICE. Looking at it now. It may also cause: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63432 -- H.J.

  1   2   3   4   5   6   7   8   9   10   >