Hi,
+1 (binding)
It’s fine that the JSON files are missing ASF headers
I checked:
- incubating in name
- signature and hashes are fine
- DISCLAIMER exists
- LICENSE and NOTICE are good
- no unexpected binary files
- all source files have ASF headers
- didn’t compile from source
Thanks,
Justin
On Thu, Jun 17, 2021 at 9:52 PM Xun Liu wrote:
> Hi, Johnson
>
> I have checked the following items:
>
> - Incubating in name
> - NOTICE is fine
> - DISCLAIMER exists
> - All links are valid
> - No unexpected JS files
>
> BUT, This file does not have ASF headers, Please fixed it.
>
>
+1 from me
On Thu, Jun 17, 2021 at 2:42 AM Gedd Johnson wrote:
> Hi Folks,
>
> Please VOTE on the Apache Flagon UserALE.js 2.2.0 Release Candidate #3.
>
> A VOTE was carried out on dev@flagon with the following results:
>
> [ 4 ] +1, let's get it released!!! (+2 (IPMC/Binding) +2 PPMC)
> [ 0 ]
hi, Johnson
> Thanks for taking a look into this. The files mentioned are in JSON format
> which does not allow for comments. As far as we know, the ASF header is
not
> able to be included in this file type. See the linked example from the
> package.json file in Apache Airflow
>
Hi,
+1 from me (binding, carrying over my vote).
I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked checksums
- Code compiles and tests successfully run
Kind Regards,
Furkan KAMACI
On Fri, Jun 18,
Hello Liu!
Thanks for taking a look into this. The files mentioned are in JSON format
which does not allow for comments. As far as we know, the ASF header is not
able to be included in this file type. See the linked example from the
package.json file in Apache Airflow
Hi, Johnson
I have checked the following items:
- Incubating in name
- NOTICE is fine
- DISCLAIMER exists
- All links are valid
- No unexpected JS files
BUT, This file does not have ASF headers, Please fixed it.
https://github.com/apache/incubator-flagon-useralejs/blob/master/package-lock.json
Hi Folks,
Please VOTE on the Apache Flagon UserALE.js 2.2.0 Release Candidate #3.
A VOTE was carried out on dev@flagon with the following results:
[ 4 ] +1, let's get it released!!! (+2 (IPMC/Binding) +2 PPMC)
[ 0 ] +/-0, fine, but consider to fix few issues before...
[ 0 ] -1, nope, because...
