Re: A license check tool offered by Apache SkyWalking Community

2022-08-24 Thread Justin Mclean
Hi, > In terms of binary dependency, if those “dependencies used by our > dependencies” (usually called transitive dependencies) are not mentioned in > the using dependencies, we can also detect and list the transitive > dependencies in our license file as they are finally bundled in our

Re: A license check tool offered by Apache SkyWalking Community

2022-08-24 Thread kezhenxu94
Hi Justin > In my experience dependancies can also include other differently licensed 3rd > party code and can fail to mention it. In terms of binary dependency, if those “dependencies used by our dependencies” (usually called transitive dependencies) are not mentioned in the using

Re: A license check tool offered by Apache SkyWalking Community

2022-08-24 Thread kezhenxu94
Hi Vladimir Sitnikov thanks for sharing!Yes overriding a dependencies license is important when the tool cannot identify it, and we have this feature too > 18. Declare the dependency licenses which cannot be identified by this tool.apache/skywalking-eyes: A full-featured license tool to check and

Re: A license check tool offered by Apache SkyWalking Community

2022-08-24 Thread Justin Mclean
Hi, In my experience dependancies can also include other differently licensed 3rd party code and can fail to mention it. Kind Regards, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional

Re: A license check tool offered by Apache SkyWalking Community

2022-08-24 Thread Vladimir Sitnikov
I have a similar tool in form of a Gradle plugin: https://github.com/vlsi/vlsi-release-plugins/blob/45865c3186a7ecc0d30b1f88c2f31160b5e1b13a/plugins/license-gather-plugin/README.md It searches for LICENSE-like files in dependencies, checks if the license is A-B-X compatible, and generates the

Re: A license check tool offered by Apache SkyWalking Community

2022-08-24 Thread kezhenxu94
We have this https://github.com/apache/skywalking-eyes#check-dependencies-licenses to check license compatibility, now we only offer compatibility matrix with Apache license 2.0 > On Aug 24, 2022, at 14:01, Sheng Wu wrote: > > AFAIK, we haven't done this. But in theory, we could introduce

Re: A license check tool offered by Apache SkyWalking Community

2022-08-24 Thread Sheng Wu
AFAIK, we haven't done this. But in theory, we could introduce Apache Catalog A/B/X to support the compatibility check. If you want to help the project to support this, submit an issue here, https://github.com/apache/skywalking/issues. Sheng Wu 吴晟 Twitter, wusheng1108 Xiaofeng 于2022年8月24日周三

Re: A license check tool offered by Apache SkyWalking Community

2022-08-23 Thread Xiaofeng
Hi, Will checking license compatible be a feature in the future? Regards, Xiaofeng Justin Mclean 于 2022年8月23日周二 16:13写道: > Hi, > > So taking a quick look at a SkyWalking release [1] I can see a couple of > minor issues with LICNSE and NOTICE. You may want to fix these. > > Hints: > Is

Re: A license check tool offered by Apache SkyWalking Community

2022-08-23 Thread Justin Mclean
Hi, So taking a quick look at a SkyWalking release [1] I can see a couple of minor issues with LICNSE and NOTICE. You may want to fix these. Hints: Is OpenCensus mentioned in LICENSE? Does prometheus client_model have a NOTICE file? Does mavin-wrapper have a NOTICE file? Also there is a

Re: A license check tool offered by Apache SkyWalking Community

2022-08-23 Thread Sheng Wu
Justin Mclean 于2022年8月23日周二 15:50写道: > > Hi, > > Also remember that it’s only code that ends up in the release and not all > dependancies that impact the LICENSE and NOTICE files. Agree. The tool would not be perfect, it just reduces the workload from a manual dependencies analysis. Sheng Wu

Re: A license check tool offered by Apache SkyWalking Community

2022-08-23 Thread Sheng Wu
Yu Xiao 于2022年8月23日周二 15:44写道: > > Hi > > It is very good. > > Will the following features be available in the future : > > Comparison of license files with dependencies (e.g. license files with > missing some). It is available if you directly use GHA. SkyWalking uses this - GHA

Re: A license check tool offered by Apache SkyWalking Community

2022-08-23 Thread Justin Mclean
Hi, Also remember that it’s only code that ends up in the release and not all dependancies that impact the LICENSE and NOTICE files. Kind Regards, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For

Re: A license check tool offered by Apache SkyWalking Community

2022-08-23 Thread Justin Mclean
Hi, Automated tools are a great help and can reduce the time required for this work, but please remember they will not find every issues. I’ve see this time and time again in incubating projects. Kind Regards, Justin - To

Re: A license check tool offered by Apache SkyWalking Community

2022-08-23 Thread Yu Xiao
Hi It is very good. Will the following features be available in the future : Comparison of license files with dependencies (e.g. license files with missing some). Best wishes! Yu Xiao Apache ShenYu Sheng Wu 于2022年8月23日周二 15:00写道: > > Hi podlings > > Apache SkyWalking graduated from the

A license check tool offered by Apache SkyWalking Community

2022-08-23 Thread Sheng Wu
Hi podlings Apache SkyWalking graduated from the incubator years ago, but we still remember we were struggling to keep licenses of dependencies well organized and listed correctly. So, SkyWalking PMC/Committer worked with the community starting to build a tool to help with the license header and