Sorry that the title is wrong(Should be rc03, not rc02).
I will start a new thread for the vote
--
此致！Best Regards
陈明雨 Mingyu Chen
Email:
chenmin...@apache.org
At 2022-04-09 14:05:52, "陈明雨" wrote:
>Hello Incubator Community:
>
>
>Please review and vote on Apache Doris 1.0.0-incubating-rc03
+1 (binding)
I checked:
- incubating is in the name
- LICENSE and NOTICE (maybe update the year to 2022 there) files are
there and look good
- DISCLAIMER is there
- ASF header is present in code source
- hash and signature look good
Thanks,
Regards
JB
On Mon, Mar 28, 2022 at 4:00 AM 陈明雨 wrote:
Hi,
I add some comments in PR,
Another suggestion is that the release-note should not be in the form
of a Github issue,
because it can be modified. The common practice is to include a
release-note file in the released package.
陈明雨 于2022年4月2日周六 10:08写道：
>
> Hi Kris,
> Thanks for your review.
>
Hi Kris,
Thanks for your review.
Indeed I missed the NOTICE file for binary release. The NOTICE.txt you have
seen is just for source release.
For binary package, I have added new NOTICE for it, please help to review:
https://github.com/apache/incubator-doris/pull/8813
And if that is OK, I will
Calvin Kirs 于2022年4月1日周五 22:57写道：
>
> Hi,
> + 0 (binding)
> I only checked source packages.
>
> - incubating in the name
> - LICENSE, NOTICE, DISCLAIMER are there and look good
> - hash and signature look good
>
> I have some questions about binary packages, which is why I chose +0.
>
> I checked
Hi,
+ 0 (binding)
I only checked source packages.
- incubating in the name
- LICENSE, NOTICE, DISCLAIMER are there and look good
- hash and signature look good
I have some questions about binary packages, which is why I chose +0.
I checked the corresponding binary package, but the dependencies
+1 (not binding)
I checked
- LICENSE and NOTICE files exist
- DISCLAIMER file exist
- Include the word incubating in the release file name.
- Signatures and hashes are fine
Suggest update the Notice year of
`apache-doris-1.0.0-incubating-src.tar.gz` to 2018-2022 in the next release.
陈明雨
+1 (binding)
I checked:
- incubating in the name
- LICENSE, NOTICE, DISCLAIMER are there and look good
- hash and signature look good
Regards
JB
On Mon, Mar 28, 2022 at 4:00 AM 陈明雨 wrote:
>
> Hellp Incubator Community:
>
>
> Please review and vote on Apache Doris 1.0.0-incubating-rc02 release.
+1（binding）
I checked:
All the download links work.
The License and Notice file in the source kit are good to me.
There is no binary in the source release kit.
We have the incubating disclarm in the source file.
I checked the Licenses and Notice file of 3 convenience binaries.
It looks like they
