arc land changes author

2014-10-29 Thread Joachim Breitner
Hi, I was just about to apply a DR by David. First I ran $ arc patch D390 which put me on a feature branch. Then I reworded the commit with $ git commit --amend and then I tried to land it with $ arc land Luckily I also passed --hold... It even asked me if I want to land the commit although I

RE: Is USE_REPORT_PRELUDE still useful?

2014-10-29 Thread Simon Peyton Jones
Adding core-libraries, whose bailiwick this is. Simon From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of David Feuer Sent: 29 October 2014 00:24 To: ghc-devs Subject: Is USE_REPORT_PRELUDE still useful? A lot of code in GHC.List and perhaps elsewhere compiles differently

Re: Is USE_REPORT_PRELUDE still useful?

2014-10-29 Thread Malcolm Wallace
On 29 Oct 2014, at 00:24, David Feuer wrote: A lot of code in GHC.List and perhaps elsewhere compiles differently depending on whether USE_REPORT_PRELUDE is defined. Not all code differing from the Prelude implementation. Furthermore, I don't know to what extent, if any, such code

Re: GHC on Windows (extended/broad discussion)

2014-10-29 Thread Phyx
Hi All, Sorry for the late reply, I need to adjust my mail filtering rules to let these mails go to my inbox as well. I have also taken a few passes through the windows trac and there are a lot of issues with someone assigned to them but with no activity so a while on them. I was also wondering

Re: GHC on Windows (extended/broad discussion)

2014-10-29 Thread Herbert Valerio Riedel
On 2014-10-29 at 10:59:18 +0100, Phyx wrote: [...] The Win32 package for example, is dreadfully lacking in maintainership. While we merge patches, it would be great to see a Windows developer spearhead and clean it up A while back I was looking at adding some functionality to this package,

Re: GHC on Windows (extended/broad discussion)

2014-10-29 Thread Gintautas Miliauskas
By the way, regarding that repository, could someone merge my pull request https://github.com/haskell/win32/pull/27? In general, it's a bit frustrating how a lot of the patches in the Phabricator queue seem to take a while to get noticed. Don't take it personally, I'm just sharing my impressions,

Re: GHC on Windows (extended/broad discussion)

2014-10-29 Thread Herbert Valerio Riedel
On Wed, Oct 29, 2014 at 12:36 PM, Gintautas Miliauskas gintau...@miliauskas.lt wrote: By the way, regarding that repository, could someone merge my pull request https://github.com/haskell/win32/pull/27? ​The problem here is that the official maintainer according to​

RE: GHC on Windows (extended/broad discussion)

2014-10-29 Thread Simon Peyton Jones
I bet Bryan would willingly cede maintainership of Win32. I’m copying him. Bryan? From: Herbert Valerio Riedel [mailto:hvrie...@gmail.com] Sent: 29 October 2014 12:47 To: Gintautas Miliauskas Cc: Phyx; Simon Peyton Jones; kyra; ghc-devs@haskell.org Subject: Re: GHC on Windows (extended/broad

Re: [core libraries] RE: Is USE_REPORT_PRELUDE still useful?

2014-10-29 Thread Edward Kmett
I could definitely see moving the code to comments. Sent from my iPad On Oct 29, 2014, at 4:45 AM, Simon Peyton Jones simo...@microsoft.com wrote: Adding core-libraries, whose bailiwick this is. Simon From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of David Feuer Sent:

Re: Is USE_REPORT_PRELUDE still useful?

2014-10-29 Thread Edward Kmett
Ack! That -is- a somewhat scary invisible backdoor dependency. :/ We ripped out a lot of unused and untestable ifdefs for other compilers from base a couple of years back, I'd be curious if this was already affected. Any idea where the code for the report generation lies? -Edward On Oct 29,

emailing to Trac?

2014-10-29 Thread Richard Eisenberg
Hi devs, There's a feature I've wanted for some time, and I don't see a good reason not to ask: Is it possible to email comments into Trac? My commute involves a ~40 minute train ride, which I generally can use productively despite no connection. One of the biggest annoyances, though, is that

Re: emailing to Trac?

2014-10-29 Thread Edward Z. Yang
I guess maybe we could install this plugin: https://oss.trac.surfsara.nl/email2trac Edward Excerpts from Richard Eisenberg's message of 2014-10-29 08:52:01 -0700: Hi devs, There's a feature I've wanted for some time, and I don't see a good reason not to ask: Is it possible to email

File Header Pragmas in Lexer

2014-10-29 Thread Alan Kim Zimmerman
As part of my ongoing efforts to round-trip source code, I have bumped into an issue around file header pragmas, e.g. {-# LANGUAGE PatternSynonyms #-} {-# Language DeriveFoldable #-} {-# options_ghc -w #-} In normal mode, when not called from headerInfo, the file header pragmas are

Re: File Header Pragmas in Lexer

2014-10-29 Thread Alan Kim Zimmerman
Ok, to answer my own question, I changed nested_comment to nested_comment :: P (RealLocated Token) - Action nested_comment cont span buf len = do input - getInput go (reverse $ lexemeToString buf len) (1::Int) input It now starts off with the already lexed part. On Wed, Oct

Re: GHC on Windows (extended/broad discussion)

2014-10-29 Thread Gintautas Miliauskas
No need to cede maintainership, but I found it to be good practice to have additional people with commit rights to facilitate prompt submission of cleanups and minor changes that do not have architectural impact. On Wed, Oct 29, 2014 at 2:13 PM, Simon Peyton Jones simo...@microsoft.com wrote:

Re: Windows build broken in Linker.c

2014-10-29 Thread Gintautas Miliauskas
https://phabricator.haskell.org/D400 On Mon, Oct 27, 2014 at 1:34 PM, Gintautas Miliauskas gintau...@miliauskas.lt wrote: FYI, after the fix ghc builds again on Windows 32-bit, but validate.sh fails: rts\Linker.c: In function 'allocateImageAndTrampolines': rts\Linker.c:3657:31:

Re: Windows build broken in Linker.c

2014-10-29 Thread Austin Seipp
Sorry about this; merged - 208a0c207c1001da0fe63e9640e2a7e0e11c4aff (I actually only built the RTS to fix that build failure... I didn't ./validate with -Wall enabled. I'm to blame here!) On Wed, Oct 29, 2014 at 5:36 PM, Gintautas Miliauskas gintau...@miliauskas.lt wrote:

Re: Automating GHC build for Windows

2014-10-29 Thread Páli Gábor János
2014-10-28 21:49 GMT+01:00 Gintautas Miliauskas gintau...@miliauskas.lt: Can you try running the offending command with -v to see which step breaks? I have tried it, even together with building the GHC sources with a recent toolchain, but I did not get much forward. I tried running it locally