Re: Backporting srcLoc to the GHC 7.10 branch

2015-07-15 Thread Ben Gamari
Michael Snoyman mich...@snoyman.com writes: Hi Simon, We had a small pow-wow over here. We're already providing relevant customers with a custom-built GHC, and only using this feature internally to their codebases, so it's not a necessity to get this into upstream GHC 7.10. It would be nice

Re: Backporting srcLoc to the GHC 7.10 branch

2015-07-15 Thread Ben Gamari
Ben Gamari b...@smart-cactus.org writes: Michael Snoyman mich...@snoyman.com writes: Hi Simon, We had a small pow-wow over here. We're already providing relevant customers with a custom-built GHC, and only using this feature internally to their codebases, so it's not a necessity to get

RE: Backporting srcLoc to the GHC 7.10 branch

2015-07-13 Thread Simon Peyton Jones
[mailto:ghc-devs-boun...@haskell.org] On Behalf Of | | Mateusz Kowalczyk | | Sent: 06 July 2015 17:40 | | To: ghc-devs@haskell.org | | Subject: Re: Backporting srcLoc to the GHC 7.10 branch | | | | On 04/20/2015 05:29 PM, Niklas Hambüchen wrote: | | Hello everybody, | | | | I'm glad

Re: Backporting srcLoc to the GHC 7.10 branch

2015-07-13 Thread Michael Snoyman
- | | From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of | | Mateusz Kowalczyk | | Sent: 06 July 2015 17:40 | | To: ghc-devs@haskell.org | | Subject: Re: Backporting srcLoc to the GHC 7.10 branch | | | | On 04/20/2015 05:29 PM, Niklas Hambüchen wrote

Re: Backporting srcLoc to the GHC 7.10 branch

2015-07-13 Thread Michael Snoyman
; ghc-devs@haskell.org *Cc:* Mark Lentczner *Subject:* Re: Backporting srcLoc to the GHC 7.10 branch Hi Simon, We had a small pow-wow over here. We're already providing relevant customers with a custom-built GHC, and only using this feature internally to their codebases, so it's

RE: Backporting srcLoc to the GHC 7.10 branch

2015-07-13 Thread Simon Peyton Jones
; Mateusz Kowalczyk; ghc-devs@haskell.org Cc: Mark Lentczner Subject: Re: Backporting srcLoc to the GHC 7.10 branch Hi Simon, We had a small pow-wow over here. We're already providing relevant customers with a custom-built GHC, and only using this feature internally to their codebases, so it's

Re: Backporting srcLoc to the GHC 7.10 branch

2015-07-11 Thread Mateusz Kowalczyk
. Noted, thanks. Thanks Simon | -Original Message- | From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Mateusz | Kowalczyk | Sent: 06 July 2015 17:40 | To: ghc-devs@haskell.org | Subject: Re: Backporting srcLoc to the GHC 7.10 branch | | On 04/20/2015 05:29

RE: Backporting srcLoc to the GHC 7.10 branch

2015-07-08 Thread Simon Peyton Jones
2015 17:40 | To: ghc-devs@haskell.org | Subject: Re: Backporting srcLoc to the GHC 7.10 branch | | On 04/20/2015 05:29 PM, Niklas Hambüchen wrote: | Hello everybody, | | I'm glad to announce that I performed the suggested backporting as part | of | my work for FP Complete! | | With the help

Re: Backporting srcLoc to the GHC 7.10 branch

2015-07-06 Thread Mateusz Kowalczyk
On 04/20/2015 05:29 PM, Niklas Hambüchen wrote: Hello everybody, I'm glad to announce that I performed the suggested backporting as part of my work for FP Complete! With the help of Eric (thanks for your support in #ghc!) we now have this patch for 7.10 and 7.8. As promised, here are

Re: Backporting srcLoc to the GHC 7.10 branch

2015-04-21 Thread RodLogic
Hi Niklas, Fyi: what about assert? Afaik, there is special treatment in the compiler for the assert that could be replaced by this (?). On Tuesday, April 21, 2015, Niklas Hambüchen m...@nh2.me wrote: Yes, I do have work in progress on using this feature in `error` and `undefined`. I will

Re: Backporting srcLoc to the GHC 7.10 branch

2015-04-21 Thread Niklas Hambüchen
On 22/04/15 01:33, Niklas Hambüchen wrote: I will upload that as a Phabricator Diff soon, and mention the URL here. Here it is: https://phabricator.haskell.org/D861 ___ ghc-devs mailing list ghc-devs@haskell.org

Re: Backporting srcLoc to the GHC 7.10 branch

2015-04-21 Thread Niklas Hambüchen
On 22/04/15 02:42, RodLogic wrote: Fyi: what about assert? Afaik, there is special treatment in the compiler for the assert that could be replaced by this (?). Yes, replacing the custom code for `assert` was also on Eric's plan, see the comment he just made:

Re: Backporting srcLoc to the GHC 7.10 branch

2015-04-21 Thread Niklas Hambüchen
Yes, I do have work in progress on using this feature in `error` and `undefined`. I will upload that as a Phabricator Diff soon, and mention the URL here. Niklas On 21/04/15 02:07, Greg Weber wrote: Thanks a lot! Is there any plan to make error or other partial functions in the base libraries

Re: Backporting srcLoc to the GHC 7.10 branch

2015-04-20 Thread Greg Weber
Thanks a lot! Is there any plan to make error or other partial functions in the base libraries use this feature? On Mon, Apr 20, 2015 at 9:29 AM, Niklas Hambüchen m...@nh2.me wrote: Hello everybody, I'm glad to announce that I performed the suggested backporting as part of my work for FP

Re: Backporting srcLoc to the GHC 7.10 branch

2015-04-20 Thread Niklas Hambüchen
Hello everybody, I'm glad to announce that I performed the suggested backporting as part of my work for FP Complete! With the help of Eric (thanks for your support in #ghc!) we now have this patch for 7.10 and 7.8. As promised, here are the commits: *

Re: Backporting srcLoc to the GHC 7.10 branch

2015-03-24 Thread Michael Snoyman
Thanks for the feedback everyone. If/when we decide to backport the patch, we'll be sure to make the commit available for others interested in running a custom build of GHC. And thank you for the offer of help Eric, it's much appreciated :) On Mon, Mar 23, 2015 at 8:14 PM Eric Seidel

RE: Backporting srcLoc to the GHC 7.10 branch

2015-03-23 Thread Simon Peyton Jones
Subject: Backporting srcLoc to the GHC 7.10 branch It looks like the srcLoc change[1] is something that some of our (FP Complete's) customers would be quite interested in getting access to sooner rather than later. Would there be any possibility of getting that patch merged into the 7.10 branch

Re: Backporting srcLoc to the GHC 7.10 branch

2015-03-23 Thread Austin Seipp
Hi Michael, I actually tried to adopt this patch into 7.10, because I thought it was needed for another dependent patch we wanted. Unfortunately, the backtrace-via-implicit-params patch seems to depend on some prior work by Simon PJ in the typechecker (-fwarn-redundant-constraints, a rather large

Re: Backporting srcLoc to the GHC 7.10 branch

2015-03-23 Thread Eric Seidel
IIRC the patch doesn't directly depend on -fwarn-redundant-constraints, but I think I ran into some merge conflicts that had to be resolved. I agree with Austin that backporting it should be doable, and would be happy to help if there's interest. Also, I still mean to submit a follow-on patch