Re: ok to do reformatting commits?

2015-11-25 Thread Manuel M T Chakravarty
I used to be a 80 chars kind of guy, but working with Simon on the type checker, I did get into the habit of using 120. It has stuck with me. Especially in Haskell, there is a lot of value in that additional space, especially if you like to have descriptive identifiers. (In statement-oriented

Re: [GHC] #11028: Refactor ConDecl

2015-11-25 Thread Alan & Kim Zimmerman
As I wrote that I came to the same conclusion, but decided to leave the rest in case. On Thu, Nov 26, 2015 at 12:25 AM, GHC wrote: > #11028: Refactor ConDecl > -+- > Reporter: simonpj

Re: Remove deprecated quasiquote syntax

2015-11-25 Thread Michael Snoyman
I think I'm the one who requested that the backwards compatibility be added back in. I have no objection to removing it at this point. On Wed, Nov 25, 2015 at 2:11 PM, Matthew Pickering < matthewtpicker...@gmail.com> wrote: > The [$qq| quasiquote syntax has been deprecated since around 2010. > >

RE: Remove deprecated quasiquote syntax

2015-11-25 Thread Simon Peyton Jones
I'm all for it, if the broader community (e.g. the developers of those packages) are ok. Simon | -Original Message- | From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of | Matthew Pickering | Sent: 25 November 2015 12:12 | To: GHC developers |

Remove deprecated quasiquote syntax

2015-11-25 Thread Matthew Pickering
The [$qq| quasiquote syntax has been deprecated since around 2010. Is there any objection to removing the backwards compatibility now? I counted 216 uses of it on hackage in a handful of packages, some in comments. http://lpaste.net/145938 Here is the commit which deprecated it -

RE: ok to do reformatting commits?

2015-11-25 Thread Simon Peyton Jones
I don’t have a strong view but like Richard I find 80 chars limiting. I agree that we should resolve this and write down the result on the coding style page Simon | -Original Message- | From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of | Richard Eisenberg | Sent: 25

Re: [GHC] #11028: Refactor ConDecl

2015-11-25 Thread Alan & Kim Zimmerman
I just pushed to wip/T11028 It is very much a work in progress, working through to sort out the compiler errors, in the simplest way at the moment. On Wed, Nov 25, 2015 at 3:06 PM, GHC wrote: > #11028: Refactor ConDecl >

Re: ok to do reformatting commits?

2015-11-25 Thread Ömer Sinan Ağacan
2015-11-24 22:14 GMT-05:00 Evan Laforge : > Would anyone mind if I went and wrapped a bunch of files, say > typecheck/*.hs? This seems simpler than either constant hassling from > arc or coming up with more elaborate rules for arc. I would have to > make some formatting