Re: FW: [Diffusion] [Build Failed] rGHC52b02e66025f: Comments only (isIrrefutablePat)

2015-12-02 Thread Ben Gamari
Simon Peyton Jones writes: > Haddock is a constant mystery. > > I added five lines of comments to GHC's source code, and one of the > Haddock performance tests fails (see below). That's all the patch > contains. > Don't worry, I think it's niteria's patch that is to blame

FW: [Diffusion] [Build Failed] rGHC52b02e66025f: Comments only (isIrrefutablePat)

2015-12-02 Thread Simon Peyton Jones
Haddock is a constant mystery. I added five lines of comments to GHC's source code, and one of the Haddock performance tests fails (see below). That's all the patch contains. I am reluctant to fix it by deleting the comments! Simon -Original Message- From:

The GHC 8.0 feature freeze is coming

2015-12-02 Thread Ben Gamari
tl;dr: feature freeze is imminent; get any remaining patches in ASAP. Hello all, The GHC 8.0 release cycle is quickly approaching its conclusion. While there are a few patches still outstanding (most notably the no-kinds branch to which we owe the major version number bump), most everything

Re: ok to do reformatting commits?

2015-12-02 Thread Ömer Sinan Ağacan
2015-11-24 22:14 GMT-05:00 Evan Laforge : > When I was doing a recent patch, I was annoyed by lint errors about >>80 lines when I was just conforming to the existing style. I just wanted to mention that I've been using --nolint flag of arc diff lately and it's really great. It