Re: StgCase - are LiveVars and SRT fields going to be used?

2016-02-06 Thread Ömer Sinan Ağacan
I submitted https://phabricator.haskell.org/D1889 which hopefully fixes this properly. 2016-02-05 21:50 GMT-05:00 Ömer Sinan Ağacan : > Simon, I broke the debug build with that commit. I actually validated locally > before committing, but apparently the default validate

Re: StgCase - are LiveVars and SRT fields going to be used?

2016-02-05 Thread Ömer Sinan Ağacan
Simon, I broke the debug build with that commit. I actually validated locally before committing, but apparently the default validate settings doesn't define DEBUG, so the new assertion implementation was not tested. (Why validate doesn't define DEBUG by default???) The fastest way to reproduce

RE: StgCase - are LiveVars and SRT fields going to be used?

2016-02-01 Thread Simon Peyton Jones
Those fields are dead, now that the Cmm pass deals with it. We left it in while making the transition, but they can go now. Go ahead! (Lots of code should disappear along with them!) Simon | -Original Message- | From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Ömer

StgCase - are LiveVars and SRT fields going to be used?

2016-02-01 Thread Ömer Sinan Ağacan
Hi all, This is how case expression in STG currently defined: | StgCase (GenStgExpr bndr occ) (GenStgLiveVars occ) (GenStgLiveVars occ) bndr SRT AltType [GenStgAlt bndr occ] The GenStgLiveVars and SRT fields are never used anywhere in

Re: StgCase - are LiveVars and SRT fields going to be used?

2016-02-01 Thread Ömer Sinan Ağacan
https://phabricator.haskell.org/D1880 2016-02-01 18:04 GMT-05:00 Simon Peyton Jones : > Those fields are dead, now that the Cmm pass deals with it. We left it in > while making the transition, but they can go now. Go ahead! > > (Lots of code should disappear along with