Re: ok to do reformatting commits?

2015-12-02 Thread Ömer Sinan Ağacan
2015-11-24 22:14 GMT-05:00 Evan Laforge : > When I was doing a recent patch, I was annoyed by lint errors about >>80 lines when I was just conforming to the existing style. I just wanted to mention that I've been using --nolint flag of arc diff lately and it's really great. It

Re: ok to do reformatting commits?

2015-11-25 Thread Manuel M T Chakravarty
t; style page > > Simon > > | -Original Message- > | From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of > | Richard Eisenberg > | Sent: 25 November 2015 03:23 > | To: Evan Laforge <qdun...@gmail.com> > | Cc: ghc-devs@haskell.org > | Subject: Re: ok to

RE: ok to do reformatting commits?

2015-11-25 Thread Simon Peyton Jones
November 2015 03:23 | To: Evan Laforge <qdun...@gmail.com> | Cc: ghc-devs@haskell.org | Subject: Re: ok to do reformatting commits? | | Thanks for volunteering to do this work, but I'm afraid now is a | terrible time to do it. I know of three significant patches that are |

Re: ok to do reformatting commits?

2015-11-25 Thread Ömer Sinan Ağacan
2015-11-24 22:14 GMT-05:00 Evan Laforge : > Would anyone mind if I went and wrapped a bunch of files, say > typecheck/*.hs? This seems simpler than either constant hassling from > arc or coming up with more elaborate rules for arc. I would have to > make some formatting

ok to do reformatting commits?

2015-11-24 Thread Evan Laforge
When I was doing a recent patch, I was annoyed by lint errors about >80 lines when I was just conforming to the existing style. To avoid cluttering my commit with unrelated changes, I decided to fix the lints in a formatting-only commit afterwards. Looking in the archives, I see there was some

Re: ok to do reformatting commits?

2015-11-24 Thread Richard Eisenberg
Thanks for volunteering to do this work, but I'm afraid now is a terrible time to do it. I know of three significant patches that are about to be committed, and your reformatting would cause quite a few merge conflicts. If there is a lull between a feature freeze and a ghc-8.0 fork, that would

Re: ok to do reformatting commits?

2015-11-24 Thread Evan Laforge
On Tue, Nov 24, 2015 at 7:23 PM, Richard Eisenberg wrote: > Thanks for volunteering to do this work, but I'm afraid now is a terrible > time to do it. I know of three significant patches that are about to be > committed, and your reformatting would cause quite a few merge