Re: too many lines too long

We have such a thing: https://ghc.haskell.org/trac/ghc/wiki/Commentary/CodingStyle I don't think its widely consulted or respected, though. Richard On Nov 17, 2015, at 5:19 AM, Simon Marlow wrote: > On 13/11/2015 15:01, Jan Stolarek wrote: >> My view on this is: >> >>

Re: too many lines too long

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 17/11/15 15:15, Richard Eisenberg wrote: > We have such a thing: > https://ghc.haskell.org/trac/ghc/wiki/Commentary/CodingStyle > > I don't think its widely consulted or respected, though. There are several issues here. (Get rid of tabs v.

Re: too many lines too long

Could you add your comment to the ticket I've created? https://ghc.haskell.org/trac/ghc/ticket/11082 As for case conventions: The parts of GHC I play in have a fairly reliable convention: underscores for local things (both local variables and non-exported helper functions) and camel case for

Re: too many lines too long

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 FWIW, I agree with Austin on this. On 09/11/15 23:51, Richard Eisenberg wrote: > I know I'm not the only one who still routinely uses 80-column > buffers. My preferences are 78 > 74 > 80 > less than 80 > *. I don't feel strongly about any =<80

Re: too many lines too long

I don't really have a strong opinion on what gets decided here. But, I might take the blog post with some salt. I write some Scala for work, and despite not being a fan of long lines, I find myself writing them in Scala (and our code base has many), because it is often difficult to break a single

Re: too many lines too long

Lots of good replies in this thread. I just wanted to follow up on my suggestion from earlier and give some insight as to why I suggested this: The _only_ reason I really suggested a hard enforcement is because, roughly speaking, maintaining code is roughly ~infinitely more expensive than

Re: too many lines too long

r 2015 21:03 > To: ghc-devs Devs <ghc-devs@haskell.org> > Subject: too many lines too long > > Hi devs, > > We seem to be uncommitted to the ideal of 80-character lines. Almost every > patch on Phab I look through has a bunch of "line too long" lint erro

RE: too many lines too long

Simon Peyton Jones writes: > In my view 80 chars is too short. It was justified in the days of > 80-column CRTs, but that just isn't a restriction any more. I > routinely edit in a much wider window. > As far as a hard length limit is concerned I am with Simon here. 80

Re: too many lines too long

On Mon, Nov 9, 2015 at 11:51 PM, Richard Eisenberg wrote: > At both school and at home I can fit 3 80-character buffers side by > side, at a comfortable font size. Going up (even to 85 cols) would > mean losing a buffer. (Or straining my eyes.) Of course I can deal > with

Re: too many lines too long

For me, a huge reason why the line length errors are annoying is because there will often be some existing line which is 80+, and I just need to change one word in it. Well, now that's a line length error. Now, I *could* refactor the line so that it's less than 80. But this (1) fluffs up the

Re: too many lines too long

I agree that being forceful about the 80-col limit would solve my problem. But I really dislike the idea. There will always be long-running patches. Volunteers can't be relied on to have time available to continue their work right away. And so I think this decision would increase barriers to

Re: too many lines too long

Something like this might be possible. It'd just require implementing a new arcanist linter, I think, and enabling it in .arclint In general I really sympathize with this. The problem 90% of people hit is that they touch a line that was *already* over 80 columns, so 'arc lint' warns them and gets

Re: too many lines too long

I also dislike the idea of automatically rejecting such code. I agree with Austin's argument that the contribution barrier is already too high and Richard's arguments, but in addition to those, I think it wouldn't be fair because some patches of people with push access won't be subject to the

Re: too many lines too long

Hi, I’d like to state a differing opinion: I don’t think highly of such a hard rule. A line should have the length that is most natural to it. Patches should be easy to review. Developers time is spent better than re-shuffling code to be short and still nicely formatted and aligned. I might be

too many lines too long

Hi devs, We seem to be uncommitted to the ideal of 80-character lines. Almost every patch on Phab I look through has a bunch of "line too long" lint errors. No one seems to do much about these. And Phab's very very loud indication of a lint error makes reviewing the code harder. I like the

RE: too many lines too long

[mailto:ghc-devs-boun...@haskell.org] On Behalf Of Richard Eisenberg Sent: 09 November 2015 21:03 To: ghc-devs Devs <ghc-devs@haskell.org> Subject: too many lines too long Hi devs, We seem to be uncommitted to the ideal of 80-character lines. Almost every patch on Phab I look through has a

Re: too many lines too long

[mailto:ghc-devs-boun...@haskell.org] On Behalf Of Richard > Eisenberg > Sent: 09 November 2015 21:03 > To: ghc-devs Devs <ghc-devs@haskell.org> > Subject: too many lines too long > > Hi devs, > > We seem to be uncommitted to the ideal of 80-character lines. Almost e