Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-29 Thread Stefan Beller
On Fri, Apr 29, 2016 at 4:05 PM, David Turner wrote: > On Tue, 2016-04-26 at 20:59 -0700, Stefan Beller wrote: >> On Mon, Apr 25, 2016 at 3:10 PM, Stefan Beller >> wrote: >> > On Mon, Apr 25, 2016 at 9:44 AM, David Turner < >> >

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-29 Thread David Turner
On Tue, 2016-04-26 at 20:59 -0700, Stefan Beller wrote: > On Mon, Apr 25, 2016 at 3:10 PM, Stefan Beller > wrote: > > On Mon, Apr 25, 2016 at 9:44 AM, David Turner < > > dtur...@twopensource.com> wrote: > > > On Wed, 2016-04-20 at 16:57 -0400, Jeff King wrote: > > > > On Wed,

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-27 Thread Junio C Hamano
Jeff King writes: > If the plan is something like: > > 1. v2 exists, but client/server don't know when they should use it. > > 2. smart-http grows an extra parameter for the client to say "hey, I > know v2" > > 3. Other protocols get some manual v2 support (e.g., client

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-26 Thread Jeff King
On Tue, Apr 26, 2016 at 08:59:22PM -0700, Stefan Beller wrote: > > Maybe we can do a mix of 2 and 4: > > > >1) HTTP grows more extensions; other protocols stagnate for now. > >2) Come up with a backwards-incompatible protocol v2, foccussed on > >capabilities negotiation phase,

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-26 Thread Stefan Beller
On Mon, Apr 25, 2016 at 3:10 PM, Stefan Beller wrote: > On Mon, Apr 25, 2016 at 9:44 AM, David Turner > wrote: >> On Wed, 2016-04-20 at 16:57 -0400, Jeff King wrote: >>> On Wed, Apr 20, 2016 at 04:46:55PM -0400, David Turner wrote: >>> >>> > As you

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-25 Thread Stefan Beller
On Mon, Apr 25, 2016 at 9:44 AM, David Turner wrote: > On Wed, 2016-04-20 at 16:57 -0400, Jeff King wrote: >> On Wed, Apr 20, 2016 at 04:46:55PM -0400, David Turner wrote: >> >> > As you note, it appears that git-daemon does sort-of have support >> > for >> > extra args

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-25 Thread David Turner
On Wed, 2016-04-20 at 16:57 -0400, Jeff King wrote: > On Wed, Apr 20, 2016 at 04:46:55PM -0400, David Turner wrote: > > > As you note, it appears that git-daemon does sort-of have support > > for > > extra args -- see parse_host_arg. So it wouldn't be hard to add > > something here.

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-20 Thread Jeff King
On Wed, Apr 20, 2016 at 04:46:55PM -0400, David Turner wrote: > As you note, it appears that git-daemon does sort-of have support for > extra args -- see parse_host_arg. So it wouldn't be hard to add > something here. Unfortunately, current versions of git die on unknown > args. So this change

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-20 Thread David Turner
On Tue, 2016-04-19 at 21:17 -0400, Jeff King wrote: > On Tue, Apr 19, 2016 at 07:43:11PM -0400, David Turner wrote: > > > On Tue, 2016-04-19 at 19:22 -0400, Jeff King wrote: > > > You can find previous discussion on the list, but I think the > > > options > > > basically are: > > > > > > 1.

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-19 Thread Jeff King
On Tue, Apr 19, 2016 at 07:43:11PM -0400, David Turner wrote: > On Tue, 2016-04-19 at 19:22 -0400, Jeff King wrote: > > You can find previous discussion on the list, but I think the options > > basically are: > > > > 1. Something like v2, where the client gets a chance to speak > > before > >

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-19 Thread David Turner
On Tue, 2016-04-19 at 19:22 -0400, Jeff King wrote: > You can find previous discussion on the list, but I think the options > basically are: > > 1. Something like v2, where the client gets a chance to speak > before > the advertisement. > > 2. Some out-of-band way of getting values from

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-19 Thread Jeff King
On Tue, Apr 19, 2016 at 05:40:01PM -0400, David Turner wrote: > > I dunno, I am a bit negative on bringing new features to Git-over > > -HTTP > > (which is already less efficient than the other protocols!) without > > any > > plan for supporting them in the other protocols. > > Interesting --

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-19 Thread David Turner
On Tue, 2016-04-19 at 03:14 -0400, Jeff King wrote: > On Mon, Apr 18, 2016 at 11:45:54AM -0700, Junio C Hamano wrote: > > > David Turner writes: > > > > > Add parameters for a list of refspecs to > > > transport_get_remote_refs and > > > get_refs_list. These

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-19 Thread David Turner
On Mon, 2016-04-18 at 11:45 -0700, Junio C Hamano wrote: > David Turner writes: > > > Add parameters for a list of refspecs to transport_get_remote_refs > > and > > get_refs_list. These parameters are presently unused -- soon, we > > will > > use them to implement

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-19 Thread Stefan Beller
On Tue, Apr 19, 2016 at 12:14 AM, Jeff King wrote: > On Mon, Apr 18, 2016 at 11:45:54AM -0700, Junio C Hamano wrote: > >> David Turner writes: >> >> > Add parameters for a list of refspecs to transport_get_remote_refs and >> > get_refs_list. These

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-19 Thread Jeff King
On Mon, Apr 18, 2016 at 11:45:54AM -0700, Junio C Hamano wrote: > David Turner writes: > > > Add parameters for a list of refspecs to transport_get_remote_refs and > > get_refs_list. These parameters are presently unused -- soon, we will > > use them to implement

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-18 Thread Junio C Hamano
David Turner writes: > Add parameters for a list of refspecs to transport_get_remote_refs and > get_refs_list. These parameters are presently unused -- soon, we will > use them to implement fetches which only learn about a subset of refs. > > Signed-off-by: David

[PATCH/RFC 4/6] transport: add refspec list parameters to functions

2016-04-15 Thread David Turner
Add parameters for a list of refspecs to transport_get_remote_refs and get_refs_list. These parameters are presently unused -- soon, we will use them to implement fetches which only learn about a subset of refs. Signed-off-by: David Turner --- builtin/clone.c | 2