[PATCH v2 2/3] diffcore-pickaxe: remove fill_one()

2013-04-04 Thread Simon Ruderich
From: Jeff King p...@peff.net fill_one is _almost_ identical to just calling fill_textconv; the exception is that for the !DIFF_FILE_VALID case, fill_textconv gives us an empty buffer rather than a NULL one. Signed-off-by: Simon Ruderich si...@ruderich.org --- On Thu, Apr 04, 2013 at 01:49:42PM

Re: [PATCH v2 2/3] diffcore-pickaxe: remove fill_one()

2013-04-04 Thread Jeff King
On Thu, Apr 04, 2013 at 10:21:08PM +0200, Simon Ruderich wrote: From: Jeff King p...@peff.net fill_one is _almost_ identical to just calling fill_textconv; the exception is that for the !DIFF_FILE_VALID case, fill_textconv gives us an empty buffer rather than a NULL one. Signed-off-by:

Re: [PATCH v2 2/3] diffcore-pickaxe: remove fill_one()

2013-04-04 Thread Junio C Hamano
Jeff King p...@peff.net writes: Thanks. The whole series looks good to me. I think Junio's proposed cleanup is a good direction, too, but I don't mind if that comes on top. I'll send out a three-patch follow-up shortly. -- To unsubscribe from this list: send the line unsubscribe git in the