Re: [PATCH v5 06/15] index-helper: add --detach

2016-04-25 Thread David Turner
On Wed, 2016-04-20 at 06:50 +0700, Duy Nguyen wrote: > On Wed, Apr 20, 2016 at 6:28 AM, David Turner < > dtur...@twopensource.com> wrote: > > @@ -317,6 +320,8 @@ int main(int argc, char **argv) > > if (fd < 0) > > die_errno(_("could not set up index-helper > > socket")); >

Re: [PATCH v5 06/15] index-helper: add --detach

2016-04-20 Thread Duy Nguyen
On Wed, Apr 20, 2016 at 8:04 AM, David Turner wrote: > On Wed, 2016-04-20 at 06:50 +0700, Duy Nguyen wrote: >> On Wed, Apr 20, 2016 at 6:28 AM, David Turner < >> dtur...@twopensource.com> wrote: >> > @@ -317,6 +320,8 @@ int main(int argc, char **argv) >> > if (fd

Re: [PATCH v5 06/15] index-helper: add --detach

2016-04-19 Thread David Turner
On Wed, 2016-04-20 at 06:50 +0700, Duy Nguyen wrote: > On Wed, Apr 20, 2016 at 6:28 AM, David Turner < > dtur...@twopensource.com> wrote: > > @@ -317,6 +320,8 @@ int main(int argc, char **argv) > > if (fd < 0) > > die_errno(_("could not set up index-helper > > socket")); >

Re: [PATCH v5 06/15] index-helper: add --detach

2016-04-19 Thread Duy Nguyen
On Wed, Apr 20, 2016 at 6:28 AM, David Turner wrote: > @@ -317,6 +320,8 @@ int main(int argc, char **argv) > if (fd < 0) > die_errno(_("could not set up index-helper socket")); > > + if (detach && daemonize()) > +

[PATCH v5 06/15] index-helper: add --detach

2016-04-19 Thread David Turner
From: Nguyễn Thái Ngọc Duy We detach after creating and opening the socket, because otherwise we might return control to the shell before index-helper is ready to accept commands. This might lead to flaky tests. Signed-off-by: Nguyễn Thái Ngọc Duy