Re: [Gluster-devel] Question on merging zfs snapshot support into the mainline glusterfs

Hi Avra, I checked the comment, the series of patches, (There are nine patches) for which I've posted for a review below. They've all the necessary makefiles to compile. Would you want me to consolidate all'em and post them as a single patch? (I thought that would be a little confusing, since

Re: [Gluster-devel] [Gluster-Maintainers] GlusterFS-3.7.16 release approaching

On Mon, Oct 03, 2016 at 05:54:26PM +0530, Kaushal M wrote: > I had to rebase 15602. But all 3 are merged now. Commit 55c92db (+1 > for release-notes) will be 3.7.16. Great, thanks! > I'm at the airport right now travelling to Berlin for the Summit. I'll > be running tests as I travel. I hope to

Re: [Gluster-devel] [Gluster-Maintainers] GlusterFS-3.7.16 release approaching

I had to rebase 15602. But all 3 are merged now. Commit 55c92db (+1 for release-notes) will be 3.7.16. I'm at the airport right now travelling to Berlin for the Summit. I'll be running tests as I travel. I hope to have 3.7.16 tagged when I reach Berlin early tomorrow morning. ~kaushal On Sun,

Re: [Gluster-devel] New commands for supporting add/remove brick and rebalance on tiered volume

Yes. this sounds better than having two separate commands for each tier. If i don't get any other better solution will go with this one. Thanks Atin. - Original Message - > From: "Atin Mukherjee" > To: "Hari Gowtham" > Cc: "gluster-devel"

Re: [Gluster-devel] New commands for supporting add/remove brick and rebalance on tiered volume

Hari, I think you misunderstood my statement, probably I shouldn't have mentioned existing semantics. One eg here should clarify it, so this is what I propose: gluster v tier remove-brick tier-type hot start Note that my request was to add an argument i.e tier-type here. On Monday 3 October

Re: [Gluster-devel] Question on merging zfs snapshot support into the mainline glusterfs

Hi Sriram, I posted a comment into the first patch. It doesn't compile by itself. We need to update the respective makefiles to be able to compile it. Then we can introduce the tabular structure in the same patch to have the framework set for the zfs snapshots. Thanks. Regards, Avra On

Re: [Gluster-devel] New commands for supporting add/remove brick and rebalance on tiered volume

Hi Atin, Yes, we can do it. the existing semantics need some changes because of the attach tier command (gluster volume tier attach ...) the parsing has to be changed to accommodate the attach tier command. if used as I mentioned then we can use the functions of attach tier generic for adding

Re: [Gluster-devel] [Gluster-Maintainers] 'Reviewd-by' tag for commits

On Mon, Oct 3, 2016 at 12:17 PM, Joe Julian wrote: > If you get credit for +1, shouldn't you also get credit for -1? It seems > to me that catching a fault is at least as valuable if not more so. > Yes when I said review it could be either +1/-1/+2 > > On October 3,

Re: [Gluster-devel] New commands for supporting add/remove brick and rebalance on tiered volume

On Mon, Oct 3, 2016 at 12:21 PM, Hari Gowtham wrote: > Hi, > > The current add and remove brick commands aren't sufficient to support > add/remove brick on tiered volumes.So the commands need minor changes > like mentioning which tier we are doing the operation on. So in

[Gluster-devel] New commands for supporting add/remove brick and rebalance on tiered volume

Hi, The current add and remove brick commands aren't sufficient to support add/remove brick on tiered volumes.So the commands need minor changes like mentioning which tier we are doing the operation on. So in order to specify the tier on which we are performing the changes, I thought of using

Re: [Gluster-devel] [Gluster-Maintainers] 'Reviewd-by' tag for commits

If you get credit for +1, shouldn't you also get credit for -1? It seems to me that catching a fault is at least as valuable if not more so. On October 3, 2016 3:58:32 AM GMT+02:00, Pranith Kumar Karampuri wrote: >On Mon, Oct 3, 2016 at 7:23 AM, Ravishankar N