Re: [Gluster-devel] a link issue maybe introduced in a bug fix " Don't let NFS cache stat after writes"

Hi, I suppose the zero filled attr is for performance consider to NFS, but for fuse, it will lead issue such like hard LINK FOP, So I suggest could we add 2 attr field in the endof "struct iatt {", such like ia_fuse_nlink, ia_fuse_ctime, And in function gf_zero_fill_stat , saved the ia_nlink,

Re: [Gluster-devel] a link issue maybe introduced in a bug fix " Don't let NFS cache stat after writes"

On 25 Jan 2018 8:43 am, "Lian, George (NSB - CN/Hangzhou)" < george.l...@nokia-sbell.com> wrote: Hi, I suppose the zero filled attr is for performance consider to NFS, but for fuse, it will lead issue such like hard LINK FOP, So I suggest could we add 2 attr field in the endof "struct iatt {",

Re: [Gluster-devel] a link issue maybe introduced in a bug fix " Don't let NFS cache stat after writes"

Hi, Pranith Kumar, Can you tell me while need set buf->ia_nlink to “0”in function gf_zero_fill_stat(), which API or Application will care it? If I remove this line and also update corresponding in function gf_is_zero_filled_stat, The issue seems gone, but I can’t confirm will lead to other

Re: [Gluster-devel] Regression tests time

On Wed, Jan 24, 2018 at 3:11 PM, Jeff Darcy wrote: > > > > On Tue, Jan 23, 2018, at 12:58 PM, Xavi Hernandez wrote: > > I've made some experiments [1] with the time that centos regression takes > to complete. After some changes the time taken to run a full regression has >

Re: [Gluster-devel] a link issue maybe introduced in a bug fix " Don't let NFS cache stat after writes"

On 01/10/2018 07:07 AM, Pranith Kumar Karampuri wrote: > When stat is "zero filled", understanding is that the higher layer > protocol doesn't send stat value to the kernel and a separate lookup is > sent by the kernel to get the latest stat value. In which protocol are > you seeing this issue?

Re: [Gluster-devel] Regression tests time

On Tue, Jan 23, 2018, at 12:58 PM, Xavi Hernandez wrote: > I've made some experiments [1] with the time that centos regression > takes to complete. After some changes the time taken to run a full > regression has dropped between 2.5 and 3.5 hours (depending on the run > time of 2 tests, see

Re: [Gluster-devel] a link issue maybe introduced in a bug fix " Don't let NFS cache stat after writes"

On Wed, Jan 24, 2018 at 02:24:06PM +0530, Pranith Kumar Karampuri wrote: > hi, >In the same commit you mentioned earlier, there was this code > earlier: > -/* Returns 1 if the stat seems to be filled with zeroes. */ > -int > -nfs_zero_filled_stat (struct iatt *buf) > -{ > -if

Re: [Gluster-devel] a link issue maybe introduced in a bug fix " Don't let NFS cache stat after writes"

So I suppose ctime is enough to consider it whether a good iatt or not. And why we also include ia_nlink in function gf_zero_fill_stat and gf_is_zero_filled_stat ? From my investigation, if set ia_nlink to 0, if kernel read the attr with flag RCU, kernel will check the ia_nlink field, when do

Re: [Gluster-devel] Rawhide RPM builds failing

On Wed, Jan 24, 2018 at 02:53:40PM +0530, Nigel Babu wrote: > More details: https://build.gluster.org/job/rpm-rawhide/1182/ With the changes for bug 1536186 it works fine for me. One patch still needs to get merged though. The error in the root.log of the job looks unrelated, it may have been

Re: [Gluster-devel] Rawhide RPM builds failing

More details: https://build.gluster.org/job/rpm-rawhide/1182/ On Wed, Jan 24, 2018 at 2:03 PM, Niels de Vos wrote: > On Wed, Jan 24, 2018 at 09:14:51AM +0530, Nigel Babu wrote: > > Hello folks, > > > > Our rawhide rpm builds seem to be failing with what looks like a specfile

Re: [Gluster-devel] a link issue maybe introduced in a bug fix " Don't let NFS cache stat after writes"

On Wed, Jan 24, 2018 at 2:24 PM, Pranith Kumar Karampuri < pkara...@redhat.com> wrote: > hi, >In the same commit you mentioned earlier, there was this code > earlier: > -/* Returns 1 if the stat seems to be filled with zeroes. */ > -int > -nfs_zero_filled_stat (struct iatt *buf) > -{ > -

Re: [Gluster-devel] a link issue maybe introduced in a bug fix " Don't let NFS cache stat after writes"

hi, In the same commit you mentioned earlier, there was this code earlier: -/* Returns 1 if the stat seems to be filled with zeroes. */ -int -nfs_zero_filled_stat (struct iatt *buf) -{ -if (!buf) -return 1; - -/* Do not use st_dev because it is transformed to

Re: [Gluster-devel] Rawhide RPM builds failing

On Wed, Jan 24, 2018 at 09:14:51AM +0530, Nigel Babu wrote: > Hello folks, > > Our rawhide rpm builds seem to be failing with what looks like a specfile > issue. It's worth looking into this now before F28 is released in May. Do you have more details? The errors from a build.log from mock would

Re: [Gluster-devel] a link issue maybe introduced in a bug fix " Don't let NFS cache stat after writes"

If ctime is zero, no xlator should consider it as a good iatt. The fact that this is happening means some xlator is not doing proper checks in code. We need to find what that xlator is and fix it. Internet in our new office is not working so I'm not able to have call today with you guys. What I