Re: [Gluster-devel] readdir() harmful in threaded code

2016-07-23 Thread Pranith Kumar Karampuri
On Sat, Jul 23, 2016 at 8:02 PM, Emmanuel Dreyfus wrote: > Pranith Kumar Karampuri wrote: > > > So should we do readdir() with external locks for everything instead? > > readdir() with a per-directory lock is safe. However, it may come with a > performance

Re: [Gluster-devel] 3.7 regressions on NetBSD

2016-07-23 Thread Pranith Kumar Karampuri
Thanks Atin On Sat, Jul 23, 2016 at 7:29 PM, Atin Mukherjee wrote: > > > On Saturday 23 July 2016, Pranith Kumar Karampuri > wrote: > >> If someone could give +1 on 3.7 backport >> http://review.gluster.org/#/c/14991, I can merge the patch. Then we can

Re: [Gluster-devel] readdir() harmful in threaded code

2016-07-23 Thread Emmanuel Dreyfus
Pranith Kumar Karampuri wrote: > So should we do readdir() with external locks for everything instead? readdir() with a per-directory lock is safe. However, it may come with a performance hit in some scenarios, since two threads cannot read the same directory at once. But I

Re: [Gluster-devel] 3.7 regressions on NetBSD

2016-07-23 Thread Atin Mukherjee
On Saturday 23 July 2016, Pranith Kumar Karampuri wrote: > If someone could give +1 on 3.7 backport > http://review.gluster.org/#/c/14991, I can merge the patch. Then we can > start rebasing may be? > Merged! > > On Sat, Jul 23, 2016 at 12:23 PM, Atin Mukherjee

Re: [Gluster-devel] 3.7 regressions on NetBSD

2016-07-23 Thread Pranith Kumar Karampuri
If someone could give +1 on 3.7 backport http://review.gluster.org/#/c/14991, I can merge the patch. Then we can start rebasing may be? On Sat, Jul 23, 2016 at 12:23 PM, Atin Mukherjee wrote: > AFAIK, an explicit rebase is required. > > > On Saturday 23 July 2016, Pranith

Re: [Gluster-devel] readdir() harmful in threaded code

2016-07-23 Thread Pranith Kumar Karampuri
Emmanuel, I procrastinated too long on this :-/, It is July already :-(. I just looked at the man page in Linux and it is a bit confusing, so I am not sure how to go ahead. For readdir_r(), I see: DESCRIPTION This function is deprecated; use readdir(3) instead. The

Re: [Gluster-devel] 3.7 regressions on NetBSD

2016-07-23 Thread Atin Mukherjee
AFAIK, an explicit rebase is required. On Saturday 23 July 2016, Pranith Kumar Karampuri wrote: > > > On Sat, Jul 23, 2016 at 10:17 AM, Nithya Balachandran > wrote: > >> >> >> On Sat, Jul 23, 2016

Re: [Gluster-devel] 3.7 regressions on NetBSD

2016-07-23 Thread Pranith Kumar Karampuri
On Sat, Jul 23, 2016 at 10:17 AM, Nithya Balachandran wrote: > > > On Sat, Jul 23, 2016 at 9:45 AM, Nithya Balachandran > wrote: > >> >> >> On Fri, Jul 22, 2016 at 9:07 PM, Pranith Kumar Karampuri < >> pkara...@redhat.com> wrote: >> >>> >>> >>> On Fri,