Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2016-01-11 Thread Michael Adam
On 2016-01-08 at 12:03 +0530, Raghavendra Talur wrote: > Top posting, this is a very old thread. > > Keeping in view the recent NetBSD problems and the number of bugs creeping > in, I suggest we do these things right now: > > a. Change the gerrit merge type to fast forward only. > As explained

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2016-01-11 Thread Raghavendra Talur
On Jan 12, 2016 2:50 AM, "Niels de Vos" wrote: > > On Fri, Jan 08, 2016 at 12:46:09PM +0530, Raghavendra Talur wrote: > > On Fri, Jan 8, 2016 at 12:28 PM, Kaushal M wrote: > > > > > On Fri, Jan 8, 2016 at 12:10 PM, Kaushal M wrote: >

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2016-01-11 Thread Emmanuel Dreyfus
Niels de Vos wrote: > How would we handle patches that get sent by maintainers? Most > developers that do code reviews will only +1 those changes. Those will > never get automatically regression tested then. I dont think a > maintainer should +2 their own patch immediately

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2016-01-11 Thread Raghavendra Talur
On Jan 12, 2016 3:44 AM, "Michael Adam" wrote: > > On 2016-01-08 at 12:03 +0530, Raghavendra Talur wrote: > > Top posting, this is a very old thread. > > > > Keeping in view the recent NetBSD problems and the number of bugs creeping > > in, I suggest we do these things right now:

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2016-01-11 Thread Raghavendra Gowdappa
- Original Message - > From: "Raghavendra Talur" <rta...@redhat.com> > To: "Michael Adam" <ob...@samba.org> > Cc: "Gluster Devel" <gluster-devel@gluster.org> > Sent: Tuesday, January 12, 2016 8:46:05 AM > Subject: Re:

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2016-01-11 Thread Niels de Vos
On Fri, Jan 08, 2016 at 12:46:09PM +0530, Raghavendra Talur wrote: > On Fri, Jan 8, 2016 at 12:28 PM, Kaushal M wrote: > > > On Fri, Jan 8, 2016 at 12:10 PM, Kaushal M wrote: > > > On Fri, Jan 8, 2016 at 12:03 PM, Raghavendra Talur >

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2016-01-07 Thread Raghavendra Talur
AM, Raghavendra Gowdappa > > <rgowd...@redhat.com> wrote: > > > > > > > > > - Original Message - > > >> From: "Raghavendra Talur" <rta...@redhat.com> > > >> To: "Gluster Devel" <gluster-devel@gluster.org&g

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2016-01-07 Thread Kaushal M
On Fri, Jan 8, 2016 at 12:10 PM, Kaushal M wrote: > On Fri, Jan 8, 2016 at 12:03 PM, Raghavendra Talur wrote: >> Top posting, this is a very old thread. >> >> Keeping in view the recent NetBSD problems and the number of bugs creeping >> in, I suggest we do

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2016-01-07 Thread Raghavendra Talur
On Fri, Jan 8, 2016 at 12:28 PM, Kaushal M wrote: > On Fri, Jan 8, 2016 at 12:10 PM, Kaushal M wrote: > > On Fri, Jan 8, 2016 at 12:03 PM, Raghavendra Talur > wrote: > >> Top posting, this is a very old thread. > >> > >> Keeping in

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2016-01-07 Thread Kaushal M
On Fri, Jan 8, 2016 at 12:03 PM, Raghavendra Talur wrote: > Top posting, this is a very old thread. > > Keeping in view the recent NetBSD problems and the number of bugs creeping > in, I suggest we do these things right now: > > a. Change the gerrit merge type to fast forward

[Gluster-devel] Gerrit review, submit type and Jenkins testing

2015-11-09 Thread Raghavendra Talur
Hi, While trying to understand how our gerrit+jenkins setup works, I realized of a possibility of allowing bugs to get in. Currently, our gerrit is setup to have cherry-pick as the submit type. Now consider a case where: Dev1 sends a commit B with parent commit A(A is already merged). Dev2

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2015-11-09 Thread Atin Mukherjee
"Raghavendra Talur" <rta...@redhat.com> > >> To: "Gluster Devel" <gluster-devel@gluster.org> > >> Sent: Tuesday, November 10, 2015 3:10:34 AM > >> Subject: [Gluster-devel] Gerrit review, submit type and Jenkins testing > >> >

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2015-11-09 Thread Kaushal M
Tuesday, November 10, 2015 3:10:34 AM >> Subject: [Gluster-devel] Gerrit review, submit type and Jenkins testing >> >> Hi, >> >> While trying to understand how our gerrit+jenkins setup works, I realized of >> a possibility of allowing bugs to get in. >> >>

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2015-11-09 Thread Atin Mukherjee
On 11/10/2015 03:10 AM, Raghavendra Talur wrote: > Hi, > > While trying to understand how our gerrit+jenkins setup works, I > realized of a possibility of allowing bugs to get in. > > Currently, our gerrit is setup to have cherry-pick as the submit type. > Now consider a case where: > > Dev1

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2015-11-09 Thread Kaushal M
On Tue, Nov 10, 2015 at 3:10 AM, Raghavendra Talur wrote: > Hi, > > While trying to understand how our gerrit+jenkins setup works, I realized of > a possibility of allowing bugs to get in. > > Currently, our gerrit is setup to have cherry-pick as the submit type. Now > consider

Re: [Gluster-devel] Gerrit review, submit type and Jenkins testing

2015-11-09 Thread Raghavendra Gowdappa
- Original Message - > From: "Raghavendra Talur" <rta...@redhat.com> > To: "Gluster Devel" <gluster-devel@gluster.org> > Sent: Tuesday, November 10, 2015 3:10:34 AM > Subject: [Gluster-devel] Gerrit review, submit type and Jenkins testing >