[Gluster-infra] [Bug 1564149] Agree upon a coding standard, and automate check for this in smoke

2018-04-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1564149 --- Comment #28 from Xavi Hernandez --- (In reply to Aravinda VK from comment #27) > I prefer Right(`AlignEscapedNewlines=Right`), since Patch will have minimum > number of lines change on modification. For example, > >

[Gluster-infra] [Bug 1564149] Agree upon a coding standard, and automate check for this in smoke

2018-04-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1564149 --- Comment #27 from Aravinda VK --- (In reply to Xavi Hernandez from comment #19) > I made a mistake on one of the proposed values: > > AlignEscapedNewLinesLeft=false > > What I wanted to propose was to set it to

[Gluster-infra] [Bug 1564149] Agree upon a coding standard, and automate check for this in smoke

2018-04-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1564149 --- Comment #25 from Xavi Hernandez --- I don't want to start any battle. It was requested to create pull requests with the proposed changes and that's what I've done. I've not hidden that some of the changes are

[Gluster-infra] [Bug 1564149] Agree upon a coding standard, and automate check for this in smoke

2018-04-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1564149 --- Comment #23 from Xavi Hernandez --- The change will also include some of the controversial options: IndentCaseLabels=true SpaceBeforeParens=ControlStatements What should we do with them ? -- You are receiving this

[Gluster-infra] [Bug 1564149] Agree upon a coding standard, and automate check for this in smoke

2018-04-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1564149 --- Comment #22 from Xavi Hernandez --- Some issues I've seen: * Some initializations are formatted like this: char gfid_local[GF_UUID_BUF_SIZE] = { 0, }; I've tried to change

[Gluster-infra] [Bug 1564149] Agree upon a coding standard, and automate check for this in smoke

2018-04-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1564149 --- Comment #21 from Jeff Darcy --- The feedback so far has been strongly positive, but one issue has been raised. As Xavi mentioned, the PointerAlignment doesn't seem to work properly on lines affected by AlignConsecutive*.

[Gluster-infra] [Bug 1570161] New mailing list: t...@gluster.org

2018-04-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1570161 --- Comment #1 from Amye Scavarda --- Editing to add: Archives are private, not that the list should be invisible. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug