Re: Outdated libtool creates trouble on macOS

2023-08-28 Thread Torbjörn Granlund
Marc Glisse writes: Do you think we could increase AC_PREREQ to 2.70 (or even 2.71), which would allow a couple more cleanups? I don't think we want to support users rerunning autoconf with an older version than the one we use to generate the tarballs. Sure. Being compatible with older

Re: Outdated libtool creates trouble on macOS

2023-08-28 Thread Marc Glisse
On Sun, 27 Aug 2023, Torbjörn Granlund wrote: We have been using the default shell.gmplib.org autotools tools for a week now, for generating the public snapshots and the nightbuild snapshots. Things look good. Do you think we could increase AC_PREREQ to 2.70 (or even 2.71), which would

Re: Outdated libtool creates trouble on macOS

2023-08-27 Thread Torbjörn Granlund
Marc Glisse writes: It looks recent enough that the piece of code causing trouble on macOS has been modified. I think we can go with that, we can always upgrade again later if needed. We have been using the default shell.gmplib.org autotools tools for a week now, for generating the public

Re: Outdated libtool creates trouble on macOS

2023-08-22 Thread Marc Glisse
On Tue, 22 Aug 2023, Torbjörn Granlund wrote: Are the autotools and (just installed) libtool on shell adequate? They are the most recent pre-packaged with FreeBSD. It looks recent enough that the piece of code causing trouble on macOS has been modified. I think we can go with that, we can

Re: Outdated libtool creates trouble on macOS

2023-08-22 Thread Torbjörn Granlund
Marc Glisse writes: If I run .bootstrap now on shell (freebsd 12.2) after removing /home/gmp/usr/bin from my PATH so I get the tools from /usr/local/bin, I have a number of errors, but I think that's just because libtool is not installed. It is now. Torbjörn, I think we could start

Re: Outdated libtool creates trouble on macOS

2023-08-22 Thread Marc Glisse
On Mon, 21 Aug 2023, Marc Glisse wrote: On Mon, 21 Aug 2023, Marc Glisse wrote: because SED is used before it is set. I guess AC_PROG_SED might help, but since all the uses of SED are introduced by autotools, it feels like a bug that they don't add it automatically. Ah, that normally

Re: Outdated libtool creates trouble on macOS

2023-08-22 Thread Marc Glisse
On Mon, 21 Aug 2023, Marc Glisse wrote: I am a bit confused why this change makes ylwrap appear in am__DIST_COMMON in Makefile.in, but that seems benign enough. Actually, it is running .bootstrap a second time that makes it appear. Not great that it isn't perfectly idempotent, but not too

Re: Outdated libtool creates trouble on macOS

2023-08-21 Thread FX Coudert
> Ah, that normally happens as part of LT_INIT, and what is broken is that we > use some other libtool autoconf macro before LT_INIT. We should move things > so GMP_PROG_NM (or at least LT_PATH_NM) is after LT_INIT. I was just arriving at the same conclusion, from my own testing. FX

Re: Outdated libtool creates trouble on macOS

2023-08-21 Thread Marc Glisse
On Mon, 21 Aug 2023, Marc Glisse wrote: because SED is used before it is set. I guess AC_PROG_SED might help, but since all the uses of SED are introduced by autotools, it feels like a bug that they don't add it automatically. Ah, that normally happens as part of LT_INIT, and what is broken

Re: Outdated libtool creates trouble on macOS

2023-08-21 Thread Marc Glisse
On Mon, 31 Jul 2023, FX Coudert wrote: Hopefully this makes gmp future-proof for at least 10 years in terms of autoconf/automake :) I pushed most of your changes (the windows one will have to wait a bit), thanks. There should not be any regressions with the old autotools. But note that if

Re: Outdated libtool creates trouble on macOS

2023-08-21 Thread Marc Glisse
On Mon, 31 Jul 2023, FX Coudert wrote: warning: The macro `AC_PROG_CC_C99' is obsolete. This one is only obsolete in autoconf 2.70+, so I am keeping it for now. -- Marc Glisse ___ gmp-bugs mailing list gmp-bugs@gmplib.org

Re: Outdated libtool creates trouble on macOS

2023-08-21 Thread Marc Glisse
On Sun, 30 Jul 2023, FX Coudert wrote: PS: second patchlet, to deal with these two macros: warning: The macro `AC_HEADER_STDC' is obsolete. warning: The macro `AC_HEADER_TIME' is obsolete. I am a bit confused why this change makes ylwrap appear in am__DIST_COMMON in Makefile.in, but that

Re: Outdated libtool creates trouble on macOS

2023-07-31 Thread Niels Möller
FX Coudert writes: > From the generated files, it seems OK: the only effect is a change in > the position of some code. Still, it needs to be tested on Windows, > and I don’t have access to such machines. One option to get a kind of windows testing is to cross compile, ./configure

Re: Outdated libtool creates trouble on macOS

2023-07-31 Thread FX Coudert
OK, final patch. This was the most painful, because I hate autoconf quoting, way too many brackets and parentheses. But the patch silences the remaining warnings about AC_TRY_COMPILE, AC_TRY_LINK, and AC_TRY_RUN. And it is verified to be a no-op in terms of the generated configure file (except

Re: Outdated libtool creates trouble on macOS

2023-07-31 Thread FX Coudert
Fifth batch, fixing the following: warning: back quotes and double quotes must not be escaped in: $as_me:${as_lineno-$LINENO}: WARNING: the \"none\" host is obsolete, use --disable-assembly warning: back quotes and double quotes must not be escaped in: $as_me: WARNING: the \"none\" host is

Re: Outdated libtool creates trouble on macOS

2023-07-31 Thread FX Coudert
> No problem, I’ll continue to post small batches of changes here when I get > some time. Fourth patch in the series, dealing with win32 DLL’s. You said you had issues with this before, I implemented the changes recommended by the manual (and did not use autoupdate, which is not always

Re: Outdated libtool creates trouble on macOS

2023-07-31 Thread FX Coudert
> Yes. But probably not this week for me, my holidays are just starting :-) No problem, I’ll continue to post small batches of changes here when I get some time. Third batch of changes, dealing with the following: warning: The macro `AC_CHECK_LIBM' is obsolete. warning: The macro

Re: Outdated libtool creates trouble on macOS

2023-07-30 Thread Marc Glisse
On Sun, 30 Jul 2023, FX Coudert wrote: Attached is a diff that fixes most of the warnings. It does three things: - raise autoconf requirement to 2.69 (released in 2012, and what you already use currently for production of the tarballs) - replaces AC_FD_CC with AS_MESSAGE_LOG_FD, its new name

Re: Outdated libtool creates trouble on macOS

2023-07-30 Thread Torbjörn Granlund
FX Coudert writes: PS: second patchlet, to deal with these two macros: > warning: The macro `AC_HEADER_STDC' is obsolete. > warning: The macro `AC_HEADER_TIME' is obsolete. If you, Marc, can take a look at those proposed changes, I think they should be applied to the head gmp repo, not

Re: Outdated libtool creates trouble on macOS

2023-07-30 Thread Torbjörn Granlund
FX Coudert writes: One other question: our Linux builder, which is running from Github Actions, fails to download from gmplib.org I thought only the mercurial repo was firewalled, is that not the case? Github is firewalled off in its entirety. The firewall cannot inspect packets to make

Re: Outdated libtool creates trouble on macOS

2023-07-30 Thread FX Coudert
PS: second patchlet, to deal with these two macros: > warning: The macro `AC_HEADER_STDC' is obsolete. > warning: The macro `AC_HEADER_TIME' is obsolete. time.diff Description: Binary data ___ gmp-bugs mailing list gmp-bugs@gmplib.org

Re: Outdated libtool creates trouble on macOS

2023-07-30 Thread FX Coudert
> First, a large number of warnings can be a bit scary. Attached is a diff that fixes most of the warnings. It does three things: - raise autoconf requirement to 2.69 (released in 2012, and what you already use currently for production of the tarballs) - replaces AC_FD_CC with

Re: Outdated libtool creates trouble on macOS

2023-07-30 Thread Marc Glisse
On Sun, 30 Jul 2023, FX Coudert wrote: Sorry about that. I knew there were problems with old autotools and quickly tried updating them before the release, but that caused too many problems. What are the problems? Our workaround is to rerun the latest autoreconf, and it emits a lot of

Re: Outdated libtool creates trouble on macOS

2023-07-30 Thread FX Coudert
Hi Marc, > Sorry about that. I knew there were problems with old autotools and quickly > tried updating them before the release, but that caused too many problems. What are the problems? Our workaround is to rerun the latest autoreconf, and it emits a lot of warnings, but it does not create

Re: Outdated libtool creates trouble on macOS

2023-07-30 Thread Marc Glisse
On Sun, 30 Jul 2023, FX Coudert wrote: Compilation of newly released GMP 6.3.0 on macOS (both Intel and ARM) leads to wrongly compiled libraries, with a flat namespace. This is generally avoided (and enforced by various build tools) on macOS since many OS versions, because it can cause

Outdated libtool creates trouble on macOS

2023-07-30 Thread FX Coudert
Hi, Compilation of newly released GMP 6.3.0 on macOS (both Intel and ARM) leads to wrongly compiled libraries, with a flat namespace. This is generally avoided (and enforced by various build tools) on macOS since many OS versions, because it can cause linker errors due to name collisions. The