Re: clang warning about mini-gmp.c when used in Emacs

2022-04-19 Thread Vincent Lefevre
On 2022-04-19 20:16:51 +0200, Niels Möller wrote: > I've always liked gcc -Wall. I think it adheres to its design to warn > only about things that (1) are prone to be errors, and (2) in the case > that they aren't errors, are easy to clarify in a way that makes the > compiler stop warning about

Re: clang warning about mini-gmp.c when used in Emacs

2022-04-19 Thread Marc Glisse
On Tue, 19 Apr 2022, Niels Möller wrote: I've always liked gcc -Wall. I think it adheres to its design to warn only about things that (1) are prone to be errors, and (2) in the case that they aren't errors, are easy to clarify in a way that makes the compiler stop warning about them. That

Re: clang warning about mini-gmp.c when used in Emacs

2022-04-19 Thread Niels Möller
Torbjörn Granlund writes: > The language accepted by -Wall -Werror ain't C. Unfortunately, GMP and > its configure snippets are written in C. I've always liked gcc -Wall. I think it adheres to its design to warn only about things that (1) are prone to be errors, and (2) in the case that they

Re: clang warning about mini-gmp.c when used in Emacs

2022-04-19 Thread Torbjörn Granlund
"Marco Bodrato" writes: gmp$ ./configure CC="gcc -Wall -Werror" [...] configure: error: could not find a working compiler, see config.log for details Yes, you are right... a too fussy compiler is not considered a working compiler by the "configure" script :-) The language accepted

Re: clang warning about mini-gmp.c when used in Emacs

2022-04-19 Thread Marco Bodrato
Ciao, Il Lun, 18 Aprile 2022 9:38 am, Paul Eggert ha scritto: > mini-gmp.c is different from gmp-impl.h, because it's intended to be > used by lots of downstream projects which may use compilers that > gmp-impl.h does not use. This may help to explain why it needs casts > that gmp-impl.h doesn't

Re: clang warning about mini-gmp.c when used in Emacs

2022-04-18 Thread Paul Eggert
On 4/14/22 22:29, Niels Möller wrote: 1. Is the void cast really needed? Yes, I think so. Various compilers complain if a statement 'E;' has an expression E without side effects. The standard way to pacify them is to cast E to void. See, for example,

Re: clang warning about mini-gmp.c when used in Emacs

2022-04-18 Thread Niels Möller
Paul Eggert writes: > Mattias Engdegård reported that the Emacs master source currently > generates the following warning when Emacs is built with mini-gmp.c > under Clang 13: Probably not that compiler specific. Minimal example: #include void foo(void) {int x = 1; assert(x);} No

Re: clang warning about mini-gmp.c when used in Emacs

2022-04-18 Thread Niels Möller
Vincent Lefevre writes: >> 1. Is the void cast really needed? Corresponding macros in gmp-impl.h >> are defined like >> >> #if WANT_ASSERT >> #define ASSERT_CARRY(expr) ASSERT_ALWAYS ((expr) != 0) >> #define ASSERT_NOCARRY(expr) ASSERT_ALWAYS ((expr) == 0) >> #else >> #define

Re: clang warning about mini-gmp.c when used in Emacs

2022-04-15 Thread Vincent Lefevre
On 2022-04-15 07:29:34 +0200, Niels Möller wrote: > I have two minor comments on this proposed fix: > > 1. Is the void cast really needed? Corresponding macros in gmp-impl.h > are defined like > > #if WANT_ASSERT > #define ASSERT_CARRY(expr) ASSERT_ALWAYS ((expr) != 0) > #define

Re: clang warning about mini-gmp.c when used in Emacs

2022-04-14 Thread Niels Möller
Paul Eggert writes: > Mattias Engdegård reported that the Emacs master source currently > generates the following warning when Emacs is built with mini-gmp.c > under Clang 13: > >> In file included from /Users/mattias/emacs/lib/mini-gmp-gnulib.c:47: >> /Users/mattias/emacs/lib/mini-gmp.c:1138:2:

clang warning about mini-gmp.c when used in Emacs

2022-04-14 Thread Paul Eggert
Mattias Engdegård reported that the Emacs master source currently generates the following warning when Emacs is built with mini-gmp.c under Clang 13: In file included from /Users/mattias/emacs/lib/mini-gmp-gnulib.c:47: /Users/mattias/emacs/lib/mini-gmp.c:1138:2: warning: unused variable