Re: major formatted output function bug with %c and the value 0

2024-04-02 Thread Vincent Lefevre
On 2024-03-25 18:13:22 +0100, marco.bodr...@tutanota.com wrote: > Vincent, you did not confirm that this code worked for you, but I > pushed it anyway. > https://gmplib.org/repo/gmp/rev/4ac76064639e Thanks. I'll look at it when I have some time. -- Vincent Lefèvre - Web:

Re: major formatted output function bug with %c and the value 0

2024-03-25 Thread marco . bodrato
Ciao, 18 feb 2024, 12:29 da marco.bodr...@tutanota.com: > 15 dic 2023, 13:26 da vinc...@vinc17.net: > >> Note that there are similar issues in printf/repl-vsnprintf.c, and I >> > > I finally had the time to examine the code and test it. I attach a proposed > patch. > Vincent, you did not

Re: major formatted output function bug with %c and the value 0

2024-02-18 Thread marco . bodrato
Ciao Vincent, 15 dic 2023, 13:26 da vinc...@vinc17.net: > Note that there are similar issues in printf/repl-vsnprintf.c, and I > I finally had the time to examine the code and test it. I attach a proposed patch. I changed the 3 files: printf/doprntf.c, printf/repl-vsnprintf.c,

Re: major formatted output function bug with %c and the value 0

2023-12-15 Thread Vincent Lefevre
Hi, On 2023-12-13 20:03:13 +0100, marco.bodr...@tutanota.com wrote: > It was changed in 2001, probably a workaround, because the comment was > "Don't use sprintf return value (it's a pointer on SunOS 4)" > https://gmplib.org/repo/gmp/rev/0889877bb94a Note that there are similar issues in

Re: major formatted output function bug with %c and the value 0

2023-12-13 Thread marco . bodrato
Ciao, 13 dic 2023, 15:53 da vinc...@vinc17.net: > On 2023-12-03 20:19:10 +0100, Vincent Lefevre wrote: > >> With GMP 6.3.0, the formatted output functions do not handle %c >> with the value 0 correctly. For gmp_sprintf, the return value is >> incorrect. >> > In printf/sprintffuns.c, function

Re: major formatted output function bug with %c and the value 0

2023-12-13 Thread Vincent Lefevre
On 2023-12-03 20:19:10 +0100, Vincent Lefevre wrote: > With GMP 6.3.0, the formatted output functions do not handle %c > with the value 0 correctly. For gmp_sprintf, the return value is > incorrect. In printf/sprintffuns.c, function gmp_sprintf_format(), I suppose that vsprintf (buf, fmt, ap);

major formatted output function bug with %c and the value 0

2023-12-03 Thread Vincent Lefevre
With GMP 6.3.0, the formatted output functions do not handle %c with the value 0 correctly. For gmp_sprintf, the return value is incorrect. For gmp_asprintf and gmp_vasprintf, this is either a buffer overflow (according to the GMP manual: "The block will be the size of the string and