Re: with strict C99 the tests/mpz/convert.c needs #include

2020-11-10 Thread Vincent Lefevre
On 2020-11-09 10:14:37 +0100, Torbjorn Granlund wrote: > Vincent Lefevre writes: > > In the context of the call, the values will always be nonnegative > so that this is OK, but there is a risk that some future developer > might reuse this function in another context, where it would be >

Re: with strict C99 the tests/mpz/convert.c needs #include

2020-11-09 Thread Torbjörn Granlund
Vincent Lefevre writes: In the context of the call, the values will always be nonnegative so that this is OK, but there is a risk that some future developer might reuse this function in another context, where it would be incorrect on platforms with signed char (in particular, there is

Re: with strict C99 the tests/mpz/convert.c needs #include

2020-11-08 Thread Marco Bodrato
Ciao, Il 2020-11-08 00:45 Dennis Clarke ha scritto: However the tests blow up due to : convert.c:143:11: error: implicit declaration of function 'strcasecmp' is invalid in C99 That file will be changed in the next release. Please look if the applied patch fits your needs.

Re: with strict C99 the tests/mpz/convert.c needs #include

2020-11-08 Thread Vincent Lefevre
On 2020-11-07 18:45:52 -0500, Dennis Clarke wrote: > However the tests blow up due to : > > convert.c:143:11: error: implicit declaration of function 'strcasecmp' > is invalid in C99 > > So that is easy to fix. > > ijiraq# diff -u ./tests/mpz/convert.c.orig ./tests/mpz/convert.c > ---

with strict C99 the tests/mpz/convert.c needs #include

2020-11-07 Thread Dennis Clarke
On a somewhat strange machine I was building with llvm/Clang on FreeBSD and this : ijiraq# uname -apKU FreeBSD ijiraq 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r367349: Wed Nov 4 22:48:25 UTC 2020 r...@freebsd-head-riscv64-build.jail.ci.freebsd.org:/usr/obj/usr/src/riscv.riscv64/sys/QEMU riscv