Re: TODO for 5.2

2014-01-02 Thread Marc Glisse
Hello, on my machine, I am getting: doc/gmp.texi:5807: must be after `@deftypefun' to use `@deftypefunx' (that's mpn_sec_minvert_itch) though it looks like it works fine on shell. It is happier if we remove the newline in the middle of the @deftypefun. -- Marc Glisse

Re: Including limits.h in gmp-impl.h

2014-01-02 Thread Marc Glisse
On Thu, 2 Jan 2014, Niels Möller wrote: Marc Glisse marc.gli...@inria.fr writes: I'll also push a patch handling the fact that the standard SHRT_MAX and others don't have type short but int. Can you explain what the problem is? I noticed this change, --- a/gmp-h.in Thu Jan 02 12:28:21

Re: Including limits.h in gmp-impl.h

2014-01-02 Thread Niels Möller
Marc Glisse marc.gli...@inria.fr writes: So, do you agree with the change? Yes. I don't understand why the C spec doesn't define USHORT_MAX the way it does, but we should nevertheless define our constant in the same way as C's USHORT_MAX. (care to add a suitable comment?) I think the comment

Re: [PATCH 01/20] Delete mpn/generic/sizeinbase.c

2014-01-02 Thread Niels Möller
Torbjorn Granlund t...@gmplib.org writes: This makes sense to me. Please apply (and please write documentation!). Done. Not sure about the right interface. Now, the docs says that it is required that n 0 and that the input must be normalized (i.e., top limb non-zero), even though the current