[GNC-dev] GnuCash 3.2 Released

2018-06-24 Thread John Ralls
The GnuCash development team announces GnuCash 3.2, the second release of the 3.x stable release series. Changes Between 3.0 and 3.2, the following bugfixes were accomplished: • Bug 787401 - Test Report System - Report Definition. • Bug 794617 - Can't compile with

Re: [GNC-dev] Widget naming and css

2018-06-24 Thread Geert Janssens
Op zondag 24 juni 2018 22:06:20 CEST schreef Robert Fewell: > I'm OK with 'gnc-class-' and 'gnc-id-' and can make the changes on master > over time. > Could do it on maint but there may be some existing settings that need > changing to align. > > Bob > Master is fine. Thanks! Geert > On 24

Re: [GNC-dev] Slow user interface in 3.x gnucash: Online transaction import painfully slow - with workaround

2018-06-24 Thread John Ralls
> On Jun 24, 2018, at 11:48 AM, Christian Stimming > wrote: > > Dear developers, > > as I'm still in the process of migrating my everyday work from 2.6.x gnucash > to 3.x gnucash, I enountered some places where the user interface is still > quite slow in current 3.x gnucash compared to

Re: [GNC-dev] Widget naming and css

2018-06-24 Thread Robert Fewell
I'm OK with 'gnc-class-' and 'gnc-id-' and can make the changes on master over time. Could do it on maint but there may be some existing settings that need changing to align. Bob On 24 June 2018 at 18:43, Geert Janssens wrote: > Op zondag 24 juni 2018 18:12:19 CEST schreef John Ralls: > > Bob,

[GNC-dev] Slow user interface in 3.x gnucash: Online transaction import painfully slow - with workaround

2018-06-24 Thread Christian Stimming
Dear developers, as I'm still in the process of migrating my everyday work from 2.6.x gnucash to 3.x gnucash, I enountered some places where the user interface is still quite slow in current 3.x gnucash compared to the old one. I've fixed on such issue in the last days, but other remain. One

Re: [GNC-dev] Widget naming and css

2018-06-24 Thread Geert Janssens
Op zondag 24 juni 2018 18:12:19 CEST schreef John Ralls: > Bob, > > Thanks, much clearer. > > Using the prefix gnc-style and gnc-name does clarify the intent, so that’s > good. My only concern from a grepping standpoint is that it mimics the > format for Scheme functions imported from C, but as

Re: [GNC-dev] New balsheet (and P report), API considerations, and (slow?) KVP in Account.cpp

2018-06-24 Thread John Ralls
Chris, OK, I think that’s a good choice. As a general design principle I’d like to see the reports use QofQuery as much as possible--and extend QofQuery as necessary--because that makes it easier to reimplement as database queries. Regards, John Ralls > On Jun 24, 2018, at 2:50 AM,

Re: [GNC-dev] Widget naming and css

2018-06-24 Thread John Ralls
Bob, Thanks, much clearer. Using the prefix gnc-style and gnc-name does clarify the intent, so that’s good. My only concern from a grepping standpoint is that it mimics the format for Scheme functions imported from C, but as long as we don’t have any functions named gnc_style_foo and

Re: [GNC-dev] New balsheet (and P report), API considerations, and (slow?) KVP in Account.cpp

2018-06-24 Thread Christopher Lam
Seeking beta testers. This will not be in v3.2. https://github.com/christopherlam/gnucash/tree/maint-balsheet-pnl Or, anyone with a relatively recent maint can copy the file directly into the build's standard-reports folder:

Re: [GNC-dev] Widget naming and css

2018-06-24 Thread Robert Fewell
Sorry it was not clear, so I will try again. When I was doing the GTK3 migration I added some context styles to various widgets but I now believe some of them should be widget names like the following... GncBusinessPage should really be a widget name and then with associated styles. So as an

Re: [GNC-dev] New balsheet (and P report), API considerations, and (slow?) KVP in Account.cpp

2018-06-24 Thread Christopher Lam
I think I'll forego a noclosing_balance upgrade in C. According to https://bugzilla.gnome.org/show_bug.cgi?id=570042 the "Closing Entries" transactions did not always receive a special KVP-based flag until the commit on https://github.com/Gnucash/gnucash/commit/4b2800145 on datafiles

[GNC-dev] Transaction / Split Action List

2018-06-24 Thread Robert Fewell
Thank you for the feedback, I am going to leave it for now and finish some other things along with the odd bug for now. Bob ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: [GNC-dev] Minor coding style discussion: C++ and comments

2018-06-24 Thread Colin Law
On 23 June 2018 at 23:49, John Ralls wrote: > ... > For the record, I don’t care as long as all comments in a file use the same > style and a single commit is used to convert the comments in a particular > file and that commit has no other changes. I cannot see the point in wasting time