Re: [GNC-dev] Small changes to comment text, mostly in gnucash/import-export/import-main-matcher.h

2021-12-05 Thread Kevin Buckley
On Mon, 6 Dec 2021 at 13:48, Kevin Buckley wrote: > > Only went with the patch by email to save me having to login to GitHub, > as I only maintain a local copy of the maint branch, not one forked to an > identity at GitHub. > > Can I submit via the bugzilla without needing a login on anything?

Re: [GNC-dev] Small changes to comment text, mostly in gnucash/import-export/import-main-matcher.h

2021-12-05 Thread Kevin Buckley
On Sun, 5 Dec 2021 at 22:34, Derek Atkins wrote: > > Hi, > > On Sun, December 5, 2021 8:55 am, D. via gnucash-devel wrote: > > Kevin, > > > > The preferred way to submit changes is through git PRs, not with patch > > files attached to emails to the lists. You'll get better results using > > that

Re: [GNC-dev] Small changes to comment text, mostly in gnucash/import-export/import-main-matcher.h

2021-12-05 Thread John Ralls
Geert, Reviewing and commenting a big patch with several commits touching several files and keeping track of what's been changed between versions via an email conversation isn't attractive to me, nor is trying to keep track of which change-sets have been applied, rejected, or are waiting for

Re: [GNC-dev] Reminder: String Freeze

2021-12-05 Thread John Ralls
And today's the day. The tarball is off to the translation project so please no translatable string changes until after the release on the 19th. Regards, John Ralls > On Dec 2, 2021, at 10:45 AM, Frank H. Ellenberger > wrote: > > Dear contributors, > > I just had a look into

Re: [GNC-dev] Small changes to comment text, mostly in gnucash/import-export/import-main-matcher.h

2021-12-05 Thread Geert Janssens
I actually wonder whether we should reconsider our strategy. We're pretty used to the convenience of github pull requests. But patches by mail are actually the main method offered by git itself. So forcing potential contributors to go manipulate a website in order to get a patch sent is is

Re: [GNC-dev] Small changes to comment text, mostly in gnucash/import-export/import-main-matcher.h

2021-12-05 Thread Derek Atkins
Hi, On Sun, December 5, 2021 8:55 am, D. via gnucash-devel wrote: > Kevin, > > The preferred way to submit changes is through git PRs, not with patch > files attached to emails to the lists. You'll get better results using > that method. I would add that there are two preferred methods: 1)

Re: [GNC-dev] Small changes to comment text, mostly in gnucash/import-export/import-main-matcher.h

2021-12-05 Thread D. via gnucash-devel
Kevin, The preferred way to submit changes is through git PRs, not with patch files attached to emails to the lists. You'll get better results using that method. David T. Original Message From: Kevin Buckley Sent: Sun Dec 05 01:35:12 EST 2021 To: "Frank H. Ellenberger"