Re: [GNC-dev] Deprecate g_type_class_add_private()

2018-12-04 Thread John Ralls
> On Dec 5, 2018, at 5:09 AM, c.holterm...@gmx.de wrote: > > Hi there, > > couldn't stop myself from trying. I did a pull request for > the two c++ files: ;-) I need to dig into it myself, but it looks mostly right from my first look. I’ll put any further comments on the PR. Thanks for

Re: [GNC-dev] Deprecate g_type_class_add_private()

2018-12-04 Thread c . holtermann
Hi there, couldn't stop myself from trying. I did a pull request for the two c++ files: https://github.com/Gnucash/gnucash/pull/439 please have a look at it. regards, Christoph Am 2018-12-04 19:43, schrieb c.holterm...@gmx.de: Hello, well I got a bit curious... Of the cpp files it is

Re: [GNC-dev] Deprecate g_type_class_add_private()

2018-12-04 Thread c . holtermann
Hello, well I got a bit curious... Of the cpp files it is Account.cpp and qofinstance.cpp. Account.cpp seems rather easy to fix: diff --git a/libgnucash/engine/Account.cpp b/libgnucash/engine/Account.cpp index 9b770f24c..eafb1b2fb 100644 --- a/libgnucash/engine/Account.cpp +++

Re: [GNC-dev] Deprecate g_type_class_add_private()

2018-12-04 Thread c . holtermann
John, well that was a misunderstanding. I'd rather stay away from the c++ part for the moment and stick to my selfset python goals to not get lost in multiple tasks. It sounds reasonable to me to not just suppress deprecation warnings as that may eventually break the code. Is there a general

Re: [GNC-dev] Deprecate g_type_class_add_private()

2018-12-04 Thread c . holtermann
John, created a PR https://github.com/Gnucash/gnucash/pull/438 what I don't understand is that -Wno-deprecated-declarations is actually being set one line below. Strange. https://github.com/Gnucash/gnucash/commit/4c87dd05ec8f1da40292f3e2f0004418a573ab89#diff-af3b638bc2a3e6c650974192a53c7291

Re: [GNC-dev] Deprecate g_type_class_add_private()

2018-12-04 Thread John Ralls
Christoph, I meant a PR to replace g_type_class_add_private with G_ADD_PRIVATE. If you just want to get the warning to not error out -Werror-no-deprecated-declarations would be better so that it lets the code compile with the warnings. Eventually someone will get irritated enough with the

Re: [GNC-dev] Deprecate g_type_class_add_private()

2018-12-04 Thread c . holtermann
John, Sure, I can do a pull request. I don't know if the place where I put the flag is the best place. I just put it there and it did the job. regards, Christoph Am 2018-12-04 13:36, schrieb John Ralls: Heh, OK. Emanuel actually committed G_ADD_PRIVATE in May 2013 and it’s in 2.37. Our

Re: [GNC-dev] Deprecate g_type_class_add_private()

2018-12-04 Thread John Ralls
Heh, OK. Emanuel actually committed G_ADD_PRIVATE in May 2013 and it’s in 2.37. Our “old standard”, Ubuntu 14.04, has 2.40 so we can go ahead and change over in maint. Would you like to make a PR? Regards, John Ralls > On Dec 4, 2018, at 9:03 PM, c.holterm...@gmx.de wrote: > > Hello, > >

Re: [GNC-dev] Deprecate g_type_class_add_private()

2018-12-04 Thread c . holtermann
Hello, compiling is possible for me when adding -Wno-deprecated-declarations to CMAKE_CXX_FLAGS. regards, Christoph Holtermann diff --git a/CMakeLists.txt b/CMakeLists.txt index b2fcffb17..343808974 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -572,7 +572,7 @@ set(CMAKE_CXX_FLAGS

[GNC-dev] Deprecate g_type_class_add_private()

2018-12-04 Thread c . holtermann
Hello, I just tried to compile gnucash on OpenSuse Tumbleweed and ran into this error: [ 20%] Building CXX object libgnucash/engine/CMakeFiles/gncmod-engine.dir/Account.cpp.o /usr/local/src/gnucash/gnucash-git-fork-c.holtermann/libgnucash/engine/Account.cpp: In function ‘void