Re: [GNC-dev] Make of 3.3-181

2018-12-25 Thread John Ralls
> On Dec 24, 2018, at 3:23 PM, Frank H. Ellenberger > wrote: > > > > Am 24.12.18 um 22:10 schrieb John Ralls: >> >> >>> On Dec 24, 2018, at 9:44 AM, Frank H. Ellenberger >>> wrote: >>> >>> >>> >>> Am 24.12.18 um 18:30 schrieb John Ralls: Agreed in principle, but in this case

Re: [GNC-dev] Make of 3.3-181

2018-12-24 Thread Christopher Lam
There is still a strong argument to clean up these reports... They are generally messy, lots of duplicate code, impose new translatable strings; they use localised C API such as xaccAccountGetTaxUSCode (even taxtxf-de_DE.scm calls it), are poorly tested. I have not touched any of them

Re: [GNC-dev] Make of 3.3-181

2018-12-24 Thread Frank H. Ellenberger
Am 24.12.18 um 22:10 schrieb John Ralls: > > >> On Dec 24, 2018, at 9:44 AM, Frank H. Ellenberger >> wrote: >> >> >> >> Am 24.12.18 um 18:30 schrieb John Ralls: >>> Agreed in principle, but in this case ISTM it would make more sense to just >>> remove them. >> >> Then all books based on

Re: [GNC-dev] Make of 3.3-181

2018-12-24 Thread John Ralls
> On Dec 24, 2018, at 9:44 AM, Frank H. Ellenberger > wrote: > > > > Am 24.12.18 um 18:30 schrieb John Ralls: >> Agreed in principle, but in this case ISTM it would make more sense to just >> remove them. > > Then all books based on SKR04 will crash. That was the reason, it became >

Re: [GNC-dev] Make of 3.3-181

2018-12-24 Thread Stephen M. Butler
On 12/24/18 1:35 AM, Geert Janssens wrote: Op maandag 24 december 2018 02:33:39 CET schreef Frank H. Ellenberger: I would suspect either the change of locale-specific-tax from an option to the default behaviour in configure was not completely ported to cmake or it was not applied if the

Re: [GNC-dev] Make of 3.3-181

2018-12-24 Thread Frank H. Ellenberger
Am 24.12.18 um 18:30 schrieb John Ralls: > Agreed in principle, but in this case ISTM it would make more sense to just > remove them. Then all books based on SKR04 will crash. That was the reason, it became default. > de_DE.scm hasn’t been substantively maintained since it was first committed

Re: [GNC-dev] Make of 3.3-181

2018-12-24 Thread John Ralls
> On Dec 24, 2018, at 1:35 AM, Geert Janssens > wrote: > > Op maandag 24 december 2018 02:33:39 CET schreef Frank H. Ellenberger: >> I would suspect >> >> either the change of locale-specific-tax from an option to the default >> behaviour in configure was not completely ported to cmake >>

Re: [GNC-dev] Make of 3.3-181

2018-12-24 Thread Geert Janssens
Op maandag 24 december 2018 02:33:39 CET schreef Frank H. Ellenberger: > I would suspect > > either the change of locale-specific-tax from an option to the default > behaviour in configure was not completely ported to cmake > > or it was not applied if the locale was C. > > Frank As far as I

Re: [GNC-dev] Make of 3.3-181

2018-12-23 Thread Frank H. Ellenberger
I would suspect either the change of locale-specific-tax from an option to the default behaviour in configure was not completely ported to cmake or it was not applied if the locale was C. Frank Am 24.12.18 um 02:12 schrieb c.holterm...@gmx.de: > For me it is > * 02:10:26  WARN Could not

Re: [GNC-dev] Make of 3.3-181

2018-12-23 Thread c . holtermann
For me it is * 02:10:26 WARN Could not locate module gnucash/tax/us interface v.0 wrote `/home/christoph/oldhome_moved/Computer/src/gnucash/gnucash-git-fork-c.holtermann/lib64/gnucash/scm/ccache/2.2/gnucash/report/locale-specific/us.go' I'm in germany and no compile issues with the de_DE

[GNC-dev] Make of 3.3-181

2018-12-23 Thread Stephen M. Butler
I just did a git pull and then build of of the maint branch.  Saw this slide past during the make step. [ 92%] Generating ../../../../lib/gnucash/scm/ccache/2.0/gnucash/report/locale-specific/de_DE.go (process:16634): gnc.module-WARNING **: 13:49:35.430: Could not locate module