Re: [GNC-dev] Python code formatter - black

2020-07-11 Thread John Ralls
Not much of a comparison. I thought it interesting that the author complained of black reducing vertical space and I complained of it increasing it. I suppose it has a toggle: If a statement will fit on a line put it on a line otherwise add parentheses and break on every comma.

Re: [GNC-dev] Python code formatter - black

2020-07-11 Thread c . holtermann
Ok, I'll have a look at different ones. Try them on my commits and on the way maybe we'll agree on one (with certain settings) for the whole python codebase. Black is basically not configurable. Here's one article comparing black, yapf, autopep8 but not pylint:

Re: [GNC-dev] Python code formatter - black

2020-07-07 Thread John Ralls
PyLint is the granddaddy and semi-official python formatter and linter. Lots of Python projects require a PyLint check with a minimum score to merge commits. Regards, John Ralls > On Jul 7, 2020, at 9:23 AM, c.holterm...@gmx.de wrote: > > I looked around and liked black but I haven't compared

Re: [GNC-dev] Python code formatter - black

2020-07-07 Thread c . holtermann
I looked around and liked black but I haven't compared it to PyLint. Do you like that one better? Regards, Christoph Holtermann Am 2020-07-07 17:06, schrieb John Ralls: Is there a reason you don't want to use PyLint? Regards, John Ralls On Jul 6, 2020, at 10:22 PM, c.holterm...@gmx.de

Re: [GNC-dev] Python code formatter - black

2020-07-07 Thread John Ralls
Is there a reason you don't want to use PyLint? Regards, John Ralls > On Jul 6, 2020, at 10:22 PM, c.holterm...@gmx.de wrote: > > I have used it as is without config. I'll have a look which options > there > are for configuration and if what you have in mind is configurable. > > regards, > >

Re: [GNC-dev] Python code formatter - black

2020-07-06 Thread c . holtermann
I have used it as is without config. I'll have a look which options there are for configuration and if what you have in mind is configurable. regards, Christoph Holtermann Am 2020-07-07 05:21, schrieb John Ralls: It's mostly OK, but some of the vertical space changes are excessive in

Re: [GNC-dev] Python code formatter - black

2020-07-06 Thread John Ralls
It's mostly OK, but some of the vertical space changes are excessive in particular gncinvoice_jinja.py line 213 and latex_invoices.py line 65. I don't much care for the way it handled gncinvoice_jinja.py line 207 either: I'd prefer to move the comment above the line and if it's still too wide

[GNC-dev] Python code formatter - black

2020-07-06 Thread c . holtermann
Hello folks, I'd like to use a code formatter on the python bindings. I tried black [1] and liked what I saw. Would you be ok with reformatting the whole python bindings with it? I used it on two example scripts: