Re: Backwards compatibility with new currency issue and bug 336843.

2013-11-21 Thread Geert Janssens
On Tuesday 19 November 2013 23:43:04 Mike Alexander wrote: --On November 19, 2013 11:38:23 PM +0100 Frédéric Perrin f...@fperrin.net wrote: The attached patch compiles and seems to do what we want from 5 minutes of testing. I gave the patch a try and it seems to do the trick. I tried

Re: Backwards compatibility with new currency issue and bug 336843.

2013-11-19 Thread Frédéric Perrin
Hi Mike, Le dimanche 10 à 14:19, Mike Evans a écrit : While testing bug 336843 patch for backwards compatibility with 2.4.13, I was getting this output below. The file fails to load. * 11:49:30 WARN gnc.io [valid_commodity()] Invalid commodity: 0 fraction * 11:49:30 WARN gnc.io

Re: Backwards compatibility with new currency issue and bug 336843.

2013-11-19 Thread Derek Atkins
On Tue, November 19, 2013 4:58 pm, Frédéric Perrin wrote: Hi Mike, [snip] The new ZMW currency was introduced in May with r22965, commit ab0cfdce5a. Reverting the commit fixes the problem, but obviously this is not a fix and the problem lies elsewhere. I'll file a bug for this, I mention

Re: Backwards compatibility with new currency issue and bug 336843.

2013-11-19 Thread Frédéric Perrin
Le mardi 19 à 23:05, Derek Atkins a écrit : On Tue, November 19, 2013 4:58 pm, Frédéric Perrin wrote: Anyway, this is due to r23345 : since we set the user_symbol of every currency at startup, the KVP of every currency, even those not used, now contains simething. Therefore, in

Re: Backwards compatibility with new currency issue and bug 336843.

2013-11-19 Thread Frédéric Perrin
Le mardi 19 à 23:38, Frédéric Perrin a écrit : Le mardi 19 à 23:05, Derek Atkins a écrit : On Tue, November 19, 2013 4:58 pm, Frédéric Perrin wrote: I would recommend we do something slightly different. I would have TWO setter functions, a set_default() as well as a set(). The gnc_commodity

Re: Backwards compatibility with new currency issue and bug 336843.

2013-11-19 Thread John Ralls
On Nov 19, 2013, at 2:47 PM, Frédéric Perrin f...@fperrin.net wrote: Le mardi 19 à 23:38, Frédéric Perrin a écrit : Le mardi 19 à 23:05, Derek Atkins a écrit : On Tue, November 19, 2013 4:58 pm, Frédéric Perrin wrote: I would recommend we do something slightly different. I would have TWO

Re: Backwards compatibility with new currency issue and bug 336843.

2013-11-19 Thread Mike Alexander
--On November 19, 2013 11:38:23 PM +0100 Frédéric Perrin f...@fperrin.net wrote: The attached patch compiles and seems to do what we want from 5 minutes of testing. I gave the patch a try and it seems to do the trick. I tried deleting the display symbol slot from all commodities and the

Backwards compatibility with new currency issue and bug 336843.

2013-11-10 Thread Mike Evans
While testing bug 336843 patch for backwards compatibility with 2.4.13, I was getting this output below. The file fails to load. * 11:49:30 WARN gnc.io [valid_commodity()] Invalid commodity: 0 fraction * 11:49:30 WARN gnc.io [gnc_commodity_end_handler()] Invalid commodity parsed gnc:commodity