Re: [GNC-dev] merging failing tests

2018-09-05 Thread John Ralls
Carsten: Distilling this to the core, “Why will we not merge a PR with failing tests?” Simple: If you have a test that exposes a bug, then fixing the bug is part of the job. The branch isn’t ready to merge until it’s fixed. That’s because the point of unit tests is to tell developers when

Re: [GNC-dev] merging failing tests

2018-09-05 Thread Christopher Lam
Hi As an untrained hacker, I think the issue is whether these "bugs" are really worth fixing at all. I can imagine the history of the dark ages; and html was being refined, and previously the reports were outputting plaintext or directly to screen via X calls; the hackers decide to start

[GNC-dev] merging failing tests

2018-09-05 Thread Carsten Rinke
Hi John, I transfer this thread to this channel because I think this is not PR specific but more a general issue. Let me start by saying that I do not want to "fight to get it merged". For me it is an interesting point to exchange views upon. It is specifically about "We're not merging

Re: [GNC-dev] Wiki FAQ Page

2018-09-05 Thread Adrien Monteleone
Yeah, those seem to be internal to the wiki, not an external broken link. But then, if the page itself isn’t changing, just the named anchor, it might not matter. The page still exists, so someone clicking an FAQ link from a mailing list message will still get dropped into the same page, but if

Re: [GNC-dev] Wiki FAQ Page

2018-09-05 Thread Derek Atkins
I feel like MediaWiki also has a way to fix that, too, but it may only work at a page level and not at an anchor level. c.f. https://meta.wikimedia.org/wiki/Help:Redirect and https://meta.wikimedia.org/wiki/Help:Section#Section_linking_and_redirects -derek On Tue, September 4, 2018 12:42 pm,

Re: [GNC-dev] Wiki FAQ Page

2018-09-05 Thread Adrien Monteleone
Broken links can be handled by permanent redirects in the web server’s .htaccess file. I think Derek would be the one to add those in. If you compile the list for him to copy & paste, I’m sure that would help. The end result is someone can click the old link from the mailing list and the server

Re: [GNC-dev] New balsheet (and P report), API considerations, and (slow?) KVP in Account.cpp

2018-09-05 Thread Christopher Lam
Hi All The state of balsheet-pnl for now, imho is feature complete and has nicer well-documented internal functions. However I'm still stumped by various equity calculations, unsure how to emulate all combinations of trading/unrealized/realized gains/losses. JRalls has helpfully created some