Re: [GNC-dev] ANNOUNCE: GnuCash 5.4 Released

2023-09-25 Thread Christopher Lam
Yes, some cpp conversion. Mostly .c renamed to .cpp with minimal changes.
See https://github.com/Gnucash/gnucash/pull/1708 and
https://github.com/Gnucash/gnucash/pull/1753.
Whether this is an improvement or not is yet to be decided:
https://github.com/Gnucash/gnucash/pull/1784

On Mon, 25 Sept 2023 at 15:06, Jean Laroche  wrote:

> Wow, I notice a bunch of .c files being converted to .cpp! I haven't
> looked at the code itself, does it mean that these files now have
> classes / instances in them or is it the same code in a .cpp file (which
> is already a big improvement)?
>
> Jean
>
> On 9/24/23 2:26 PM, John Ralls wrote:
> > The GnuCash development team announces GnuCash 5.4, the fifth release in
> the stable 5.x series
> >
> > Between 5.3 and 5.4, the following bugfixes were accomplished:
> >
> >  Bug 728875 - Back button does not work in QIF import assistant
> >  Bug 797507 - GnuCash Splash screen may disappear before the main
> window appears
> >  Bug 798709 - Total(Period) column does not refresh period's value
> after update of the period in settings.a>
> >  Bug 798904 - GnuCash on Windows opens a CMD window at startup.
> >  Bug 798925 - Python bindings: "invalid unclassed pointer in cast to
> 'QofInstance'".
> >  Bug 798944 - Program crashes when matching transactions
> >  Bug 798950 - Bug Report: Incorrect Currency Conversion and Provider
> Invoice Payment Recording
> >  When balancing lots use the split amount, not the value
> >  Recalculate the values using deduced exchange rates after
> adjusting split amounts.
> >  Be conservative when recalculating values after breaking up a
> split to avoid imbalances caused by rounding.
> >  Bug 798958 - gncScrubLotLinks will infinite loop in some conditions
> >  Bug 798982 - GetQuotes crashes if Finance::Quote returns an empty
> date.
> >  Bug 798983 - Empty Orphan account appears after entering
> transactions in 5.3
> >  Bug 798990 - Notes No Longer Autofills
> >  Bug 798991 - Incorrect Account Name Order in Transaction Report
> >  Bug 798995 - Keystrokes ignored during ledger entry
> >  Bug 798998 - Job Report Not Working
> >  Bug 799004 - Update of Prices attaches incorrect Date
> >  Bug 799010 - gnc-register-account-sel-limited-option errors doesn't
> work
> >  Bug 799020 - widget of gnc-register-list-option disregards user's
> clicks
> >  Bug 799021 - Saved report renders default of
> gnc-register-list-option
> >  Bug 799036 - Import prices from a CSV date problem
> >  Bug 799039 - gnc:strify produces unusual results or crashes GnuCash
> when fed an option from gnc-lookup-option
> >  Bug 799048 - Hover on tab not correct
> >  Bug 799051 - Shortcut Ctrl + Tab not working in 5.3
> >  Bug 799054 - Stock Assist not functioning
> >  Bug 799060 - Consistent Crash in Invoices
> >  Bug 799068 - csv export active register not working
> >  Bug 799069 - Multicurrency Invoice Payment
> >  Bug 799075 - Saving display tab changes in Report Options does not
> work.
> >  Bug 799084 - Unable to create new scheduled transaction
> >
> > The following fixes and improvements were not associated with bug
> reports:
> >
> >  [import-main-matcher.cpp] After clicking/toggling A/U+C/C checkbox,
> reselect the row because it'll be much faster to use keyboard navigation --
> use up/down/left/right to target desired checkbox, hit  
> repeatedly to repeat the same action over several consecutive rows.
> >  Implement support for !Type:Prices records in the QIF importer.
> >  Modernize construction of GObjects using G_DECLARE_DERIVABLE,
> G_DECLARE_FINAL, etc.
> >  Fix yet more leaks.
> >  [DBI backend] Change DBI test URLs to environment variables from
> cmake configuration definitions.
> >  Restore the Stock Transaction Assistant to full operation.
> >  Fix the Fancy Date file property so that it saves.
> >  Fix formatting error in po files project-id line.
> >  [simple-business-create.py] Overwrite an existing file instead of
> crashing.
> >  Update github action package versions.
> >  Add parsing mixed number and fraction (e.g. 10 1/2) to the
> gnc_numeric string constructor.
> >  Bump minimum cmake version to 3.14 and drop some conditionals for
> older versions
> >  Major speedup in the SQLBackend by replacing C++ exceptions with
> std::optional for null values.
> >  Refresh the GUI on completion of the import matcher so that the
> imports are immediately reflected in the register.
> >  Improve online quote retrieval error reporting.
> >  Test loading and saving XML files with and without compression
> >  [import-main-matcher] always defer_bal_computation during import to
> speed up both importing new transactions, and destroying existing ones.
> >  GncGtkListUIItem::set_option_from_ui_item: Iterate over selected
> items Instead of all possible items.
> >  Convert 

Re: [GNC-dev] ANNOUNCE: GnuCash 5.4 Released

2023-09-25 Thread Jean Laroche
Wow, I notice a bunch of .c files being converted to .cpp! I haven't 
looked at the code itself, does it mean that these files now have 
classes / instances in them or is it the same code in a .cpp file (which 
is already a big improvement)?


Jean

On 9/24/23 2:26 PM, John Ralls wrote:

The GnuCash development team announces GnuCash 5.4, the fifth release in the 
stable 5.x series

Between 5.3 and 5.4, the following bugfixes were accomplished:

 Bug 728875 - Back button does not work in QIF import assistant
 Bug 797507 - GnuCash Splash screen may disappear before the main window 
appears
 Bug 798709 - Total(Period) column does not refresh period's value after 
update of the period in settings.a>
 Bug 798904 - GnuCash on Windows opens a CMD window at startup.
 Bug 798925 - Python bindings: "invalid unclassed pointer in cast to 
'QofInstance'".
 Bug 798944 - Program crashes when matching transactions
 Bug 798950 - Bug Report: Incorrect Currency Conversion and Provider 
Invoice Payment Recording
 When balancing lots use the split amount, not the value
 Recalculate the values using deduced exchange rates after adjusting 
split amounts.
 Be conservative when recalculating values after breaking up a split to 
avoid imbalances caused by rounding.
 Bug 798958 - gncScrubLotLinks will infinite loop in some conditions
 Bug 798982 - GetQuotes crashes if Finance::Quote returns an empty date.
 Bug 798983 - Empty Orphan account appears after entering transactions in 
5.3
 Bug 798990 - Notes No Longer Autofills
 Bug 798991 - Incorrect Account Name Order in Transaction Report
 Bug 798995 - Keystrokes ignored during ledger entry
 Bug 798998 - Job Report Not Working
 Bug 799004 - Update of Prices attaches incorrect Date
 Bug 799010 - gnc-register-account-sel-limited-option errors doesn't work
 Bug 799020 - widget of gnc-register-list-option disregards user's clicks
 Bug 799021 - Saved report renders default of gnc-register-list-option
 Bug 799036 - Import prices from a CSV date problem
 Bug 799039 - gnc:strify produces unusual results or crashes GnuCash when 
fed an option from gnc-lookup-option
 Bug 799048 - Hover on tab not correct
 Bug 799051 - Shortcut Ctrl + Tab not working in 5.3
 Bug 799054 - Stock Assist not functioning
 Bug 799060 - Consistent Crash in Invoices
 Bug 799068 - csv export active register not working
 Bug 799069 - Multicurrency Invoice Payment
 Bug 799075 - Saving display tab changes in Report Options does not work.
 Bug 799084 - Unable to create new scheduled transaction

The following fixes and improvements were not associated with bug reports:

 [import-main-matcher.cpp] After clicking/toggling A/U+C/C checkbox, reselect the row 
because it'll be much faster to use keyboard navigation -- use up/down/left/right to target 
desired checkbox, hit   repeatedly to repeat the same action over 
several consecutive rows.
 Implement support for !Type:Prices records in the QIF importer.
 Modernize construction of GObjects using G_DECLARE_DERIVABLE, 
G_DECLARE_FINAL, etc.
 Fix yet more leaks.
 [DBI backend] Change DBI test URLs to environment variables from cmake 
configuration definitions.
 Restore the Stock Transaction Assistant to full operation.
 Fix the Fancy Date file property so that it saves.
 Fix formatting error in po files project-id line.
 [simple-business-create.py] Overwrite an existing file instead of crashing.
 Update github action package versions.
 Add parsing mixed number and fraction (e.g. 10 1/2) to the gnc_numeric 
string constructor.
 Bump minimum cmake version to 3.14 and drop some conditionals for older 
versions
 Major speedup in the SQLBackend by replacing C++ exceptions with 
std::optional for null values.
 Refresh the GUI on completion of the import matcher so that the imports 
are immediately reflected in the register.
 Improve online quote retrieval error reporting.
 Test loading and saving XML files with and without compression
 [import-main-matcher] always defer_bal_computation during import to speed 
up both importing new transactions, and destroying existing ones.
 GncGtkListUIItem::set_option_from_ui_item: Iterate over selected items 
Instead of all possible items.
 Convert gnc-ofx-import.c, import-parse.c, import-utilities.c, 
import-format-dialog.c, import-account-matcher.c, import-commodity-matcher.c, 
import-settings.c, import-pending-matches.c, import-match-picker.c, 
import-main-matcher.c, and gnc-pricedb.c to .cpp
 By default, filter out online_wiggle in test-gnc-quotes. Running 
./bin/test-gnc-quotes from the command line will still include online_wiggle
 Replace yahoo_json with alphavantage in test-gnc-quotes. yahoo_json is too 
unstable.
 Include timezone in price-quote date diagnostic messages.

New and Updated Translations: Arabic, Chinese 

Re: [GNC-dev] ANNOUNCE: GnuCash 5.4 Released

2023-09-24 Thread David Cousens
Thanks John and all the team.
 
Happily runnng 5.4 on Linux Mint 21.1

David Cousens

On Sun, 2023-09-24 at 14:26 -0700, John Ralls wrote:
> The GnuCash development team announces GnuCash 5.4, the fifth release in the
> stable 5.x series
> 
> Between 5.3 and 5.4, the following bugfixes were accomplished:
> 
>     Bug 728875 - Back button does not work in QIF import assistant
>     Bug 797507 - GnuCash Splash screen may disappear before the main window
> appears
>     Bug 798709 - Total(Period) column does not refresh period's value after
> update of the period in settings.a>
>     Bug 798904 - GnuCash on Windows opens a CMD window at startup.
>     Bug 798925 - Python bindings: "invalid unclassed pointer in cast to
> 'QofInstance'".
>     Bug 798944 - Program crashes when matching transactions
>     Bug 798950 - Bug Report: Incorrect Currency Conversion and Provider
> Invoice Payment Recording
>     When balancing lots use the split amount, not the value
>     Recalculate the values using deduced exchange rates after adjusting
> split amounts.
>     Be conservative when recalculating values after breaking up a split to
> avoid imbalances caused by rounding.
>     Bug 798958 - gncScrubLotLinks will infinite loop in some conditions
>     Bug 798982 - GetQuotes crashes if Finance::Quote returns an empty date.
>     Bug 798983 - Empty Orphan account appears after entering transactions in
> 5.3
>     Bug 798990 - Notes No Longer Autofills
>     Bug 798991 - Incorrect Account Name Order in Transaction Report
>     Bug 798995 - Keystrokes ignored during ledger entry
>     Bug 798998 - Job Report Not Working
>     Bug 799004 - Update of Prices attaches incorrect Date
>     Bug 799010 - gnc-register-account-sel-limited-option errors doesn't work
>     Bug 799020 - widget of gnc-register-list-option disregards user's clicks
>     Bug 799021 - Saved report renders default of gnc-register-list-option
>     Bug 799036 - Import prices from a CSV date problem
>     Bug 799039 - gnc:strify produces unusual results or crashes GnuCash when
> fed an option from gnc-lookup-option
>     Bug 799048 - Hover on tab not correct
>     Bug 799051 - Shortcut Ctrl + Tab not working in 5.3
>     Bug 799054 - Stock Assist not functioning
>     Bug 799060 - Consistent Crash in Invoices
>     Bug 799068 - csv export active register not working
>     Bug 799069 - Multicurrency Invoice Payment
>     Bug 799075 - Saving display tab changes in Report Options does not work.
>     Bug 799084 - Unable to create new scheduled transaction
> 
> The following fixes and improvements were not associated with bug reports:
> 
>     [import-main-matcher.cpp] After clicking/toggling A/U+C/C checkbox,
> reselect the row because it'll be much faster to use keyboard navigation --
> use up/down/left/right to target desired checkbox, hit  
> repeatedly to repeat the same action over several consecutive rows.
>     Implement support for !Type:Prices records in the QIF importer.
>     Modernize construction of GObjects using G_DECLARE_DERIVABLE,
> G_DECLARE_FINAL, etc.
>     Fix yet more leaks.
>     [DBI backend] Change DBI test URLs to environment variables from cmake
> configuration definitions.
>     Restore the Stock Transaction Assistant to full operation.
>     Fix the Fancy Date file property so that it saves.
>     Fix formatting error in po files project-id line.
>     [simple-business-create.py] Overwrite an existing file instead of
> crashing.
>     Update github action package versions.
>     Add parsing mixed number and fraction (e.g. 10 1/2) to the gnc_numeric
> string constructor.
>     Bump minimum cmake version to 3.14 and drop some conditionals for older
> versions
>     Major speedup in the SQLBackend by replacing C++ exceptions with
> std::optional for null values.
>     Refresh the GUI on completion of the import matcher so that the imports
> are immediately reflected in the register.
>     Improve online quote retrieval error reporting.
>     Test loading and saving XML files with and without compression
>     [import-main-matcher] always defer_bal_computation during import to speed
> up both importing new transactions, and destroying existing ones.
>     GncGtkListUIItem::set_option_from_ui_item: Iterate over selected items
> Instead of all possible items.
>     Convert gnc-ofx-import.c, import-parse.c, import-utilities.c, import-
> format-dialog.c, import-account-matcher.c, import-commodity-matcher.c, import-
> settings.c, import-pending-matches.c, import-match-picker.c, import-main-
> matcher.c, and gnc-pricedb.c to .cpp
>     By default, filter out online_wiggle in test-gnc-quotes. Running
> ./bin/test-gnc-quotes from the command line will still include online_wiggle
>     Replace yahoo_json with alphavantage in test-gnc-quotes. yahoo_json is too
> unstable.
>     Include timezone in price-quote date diagnostic messages.
> 
> New and Updated Translations: Arabic, Chinese (Traditional), Croatian, Dutch,
> English 

[GNC-dev] ANNOUNCE: GnuCash 5.4 Released

2023-09-24 Thread John Ralls
The GnuCash development team announces GnuCash 5.4, the fifth release in the 
stable 5.x series

Between 5.3 and 5.4, the following bugfixes were accomplished:

Bug 728875 - Back button does not work in QIF import assistant
Bug 797507 - GnuCash Splash screen may disappear before the main window 
appears
Bug 798709 - Total(Period) column does not refresh period's value after 
update of the period in settings.a>
Bug 798904 - GnuCash on Windows opens a CMD window at startup.
Bug 798925 - Python bindings: "invalid unclassed pointer in cast to 
'QofInstance'".
Bug 798944 - Program crashes when matching transactions
Bug 798950 - Bug Report: Incorrect Currency Conversion and Provider Invoice 
Payment Recording
When balancing lots use the split amount, not the value
Recalculate the values using deduced exchange rates after adjusting 
split amounts.
Be conservative when recalculating values after breaking up a split to 
avoid imbalances caused by rounding.
Bug 798958 - gncScrubLotLinks will infinite loop in some conditions
Bug 798982 - GetQuotes crashes if Finance::Quote returns an empty date.
Bug 798983 - Empty Orphan account appears after entering transactions in 5.3
Bug 798990 - Notes No Longer Autofills
Bug 798991 - Incorrect Account Name Order in Transaction Report
Bug 798995 - Keystrokes ignored during ledger entry
Bug 798998 - Job Report Not Working
Bug 799004 - Update of Prices attaches incorrect Date
Bug 799010 - gnc-register-account-sel-limited-option errors doesn't work
Bug 799020 - widget of gnc-register-list-option disregards user's clicks
Bug 799021 - Saved report renders default of gnc-register-list-option
Bug 799036 - Import prices from a CSV date problem
Bug 799039 - gnc:strify produces unusual results or crashes GnuCash when 
fed an option from gnc-lookup-option
Bug 799048 - Hover on tab not correct
Bug 799051 - Shortcut Ctrl + Tab not working in 5.3
Bug 799054 - Stock Assist not functioning
Bug 799060 - Consistent Crash in Invoices
Bug 799068 - csv export active register not working
Bug 799069 - Multicurrency Invoice Payment
Bug 799075 - Saving display tab changes in Report Options does not work.
Bug 799084 - Unable to create new scheduled transaction

The following fixes and improvements were not associated with bug reports:

[import-main-matcher.cpp] After clicking/toggling A/U+C/C checkbox, 
reselect the row because it'll be much faster to use keyboard navigation -- use 
up/down/left/right to target desired checkbox, hit   repeatedly to 
repeat the same action over several consecutive rows.
Implement support for !Type:Prices records in the QIF importer.
Modernize construction of GObjects using G_DECLARE_DERIVABLE, 
G_DECLARE_FINAL, etc.
Fix yet more leaks.
[DBI backend] Change DBI test URLs to environment variables from cmake 
configuration definitions.
Restore the Stock Transaction Assistant to full operation.
Fix the Fancy Date file property so that it saves.
Fix formatting error in po files project-id line.
[simple-business-create.py] Overwrite an existing file instead of crashing.
Update github action package versions.
Add parsing mixed number and fraction (e.g. 10 1/2) to the gnc_numeric 
string constructor.
Bump minimum cmake version to 3.14 and drop some conditionals for older 
versions
Major speedup in the SQLBackend by replacing C++ exceptions with 
std::optional for null values.
Refresh the GUI on completion of the import matcher so that the imports are 
immediately reflected in the register.
Improve online quote retrieval error reporting.
Test loading and saving XML files with and without compression
[import-main-matcher] always defer_bal_computation during import to speed 
up both importing new transactions, and destroying existing ones.
GncGtkListUIItem::set_option_from_ui_item: Iterate over selected items 
Instead of all possible items.
Convert gnc-ofx-import.c, import-parse.c, import-utilities.c, 
import-format-dialog.c, import-account-matcher.c, import-commodity-matcher.c, 
import-settings.c, import-pending-matches.c, import-match-picker.c, 
import-main-matcher.c, and gnc-pricedb.c to .cpp
By default, filter out online_wiggle in test-gnc-quotes. Running 
./bin/test-gnc-quotes from the command line will still include online_wiggle
Replace yahoo_json with alphavantage in test-gnc-quotes. yahoo_json is too 
unstable.
Include timezone in price-quote date diagnostic messages.

New and Updated Translations: Arabic, Chinese (Traditional), Croatian, Dutch, 
English (Australia), English (New Zealand), English (United Kingdom), French, 
German, Greek, Hebrew, Hungarian, Indonesian, Italian, Polish, Portuguese, 
Portuguese (Brazil), Romanian, Slovak, Spanish, Swedish, Ukrainian

Help translate GnuCash on Weblate: https://hosted.weblate.org/engage/gnucash/

Known