Re: [GNC-dev] Bug 795101 - Scroll Bar in Reconcile Window Floats in and covers the check boxes
Am 11.04.2018 um 16:52 schrieb Robert Fewell:
> Would like some thoughts on possible fix...
>
> There seems to be three options but I may of missed something, move the
> toggle reconcile column, make it wider or add a dummy spacer column.
>
> The first may not be liked..
> The last seems a bit over kill.
> So making the column wider seems the best / easiest.
>
> In reconcile-view.c you have the line below which sets the column title...
>
> gnc_search_param_set_title ((GNCSearchParam *) param, _("Reconciled:R")
> + 11);
>
> All I need to do is add a couple of spaces either side of the 'R' which I
> assume I can not do as it would affect the translation string
>
> gnc_search_param_set_title ((GNCSearchParam *) param, _("Reconciled:
> R ") + 11);
For this all translators would hate you - introducing a new string with
"noise"
> But can I add this after above line, it works on my setup, is this OK.
>
> // to allow space for the vertical scrollbar showing, add a couple of
> spaces
> gnc_search_param_set_title ((GNCSearchParam *) param,
> g_strconcat (" ", ((GNCSearchParam *) param)->title, " ",
> NULL));
how about gtk_grid_set_column_spacing () or similar?
> Bob
~Frank
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Bug 795101 - Scroll Bar in Reconcile Window Floats in and covers the check boxes
Op woensdag 11 april 2018 17:27:23 CEST schreef Adrien Monteleone: > Bob, > > This isn’t so much a comment on the fix itself, but the problem. > > I don’t see it on macOS 10.13.4, so it may be Windows specific. I haven’t > built yet on Linux to try it there to comment on that platform. For me, the > scroll bar is a tiny sliver that fits in nicely to the right of the check > boxes and does not cover them. The scrollbar will widen when you hover the mouse over it. That's gtk's way to handle scrollbars. Perhaps this doesn't work like that on OS X (can't test), it does on linux. Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Bug 795101 - Scroll Bar in Reconcile Window Floats in and covers the check boxes
Op woensdag 11 april 2018 16:52:05 CEST schreef Robert Fewell:
> Would like some thoughts on possible fix...
>
> There seems to be three options but I may of missed something, move the
> toggle reconcile column, make it wider or add a dummy spacer column.
>
> The first may not be liked..
> The last seems a bit over kill.
> So making the column wider seems the best / easiest.
>
> In reconcile-view.c you have the line below which sets the column title...
>
> gnc_search_param_set_title ((GNCSearchParam *) param, _("Reconciled:R")
> + 11);
>
> All I need to do is add a couple of spaces either side of the 'R' which I
> assume I can not do as it would affect the translation string
>
> gnc_search_param_set_title ((GNCSearchParam *) param, _("Reconciled:
> R ") + 11);
>
> But can I add this after above line, it works on my setup, is this OK.
>
> // to allow space for the vertical scrollbar showing, add a couple of
> spaces
> gnc_search_param_set_title ((GNCSearchParam *) param,
> g_strconcat (" ", ((GNCSearchParam *) param)->title, " ",
> NULL));
That would leak a string each time a reconcile view is created (two per
reconcile window).
It also breaks encapsulation. For this to work you need to know the title is
stored in the internal title element or a GNCSearchParam struct. You can get
away with this in C, but it will break when we migrate to C++.
You can do what you want by creating the desired column title before in a
temporary variable and g_free'ing it afterwards.
Regards,
Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Bug 795101 - Scroll Bar in Reconcile Window Floats in and covers the check boxes
Bob,
This isn’t so much a comment on the fix itself, but the problem.
I don’t see it on macOS 10.13.4, so it may be Windows specific. I haven’t built
yet on Linux to try it there to comment on that platform. For me, the scroll
bar is a tiny sliver that fits in nicely to the right of the check boxes and
does not cover them.
I’m not sure if that makes a difference in the approach.
Regards,
Adrien
> On Apr 11, 2018, at 9:52 AM, Robert Fewell <14ubo...@gmail.com> wrote:
>
> Would like some thoughts on possible fix...
>
> There seems to be three options but I may of missed something, move the
> toggle reconcile column, make it wider or add a dummy spacer column.
>
> The first may not be liked..
> The last seems a bit over kill.
> So making the column wider seems the best / easiest.
>
> In reconcile-view.c you have the line below which sets the column title...
>
>gnc_search_param_set_title ((GNCSearchParam *) param, _("Reconciled:R")
> + 11);
>
> All I need to do is add a couple of spaces either side of the 'R' which I
> assume I can not do as it would affect the translation string
>
>gnc_search_param_set_title ((GNCSearchParam *) param, _("Reconciled:
> R ") + 11);
>
> But can I add this after above line, it works on my setup, is this OK.
>
>// to allow space for the vertical scrollbar showing, add a couple of
> spaces
>gnc_search_param_set_title ((GNCSearchParam *) param,
> g_strconcat (" ", ((GNCSearchParam *) param)->title, " ",
> NULL));
>
> Bob
> ___
> gnucash-devel mailing list
> gnucash-devel@gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
