[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13062253#comment-13062253
]
Hudson commented on HDFS-941:
-
Integrated in Hadoop-Hdfs-22-branch #70 (See
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058240#comment-13058240
]
Arun C Murthy commented on HDFS-941:
TestDFSIO depends on MR scheduling
I've run into
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052160#comment-13052160
]
Konstantin Shvachko commented on HDFS-941:
--
I ran some test myself over the
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052166#comment-13052166
]
Konstantin Shvachko commented on HDFS-941:
--
Answers to some issues raised here:
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050944#comment-13050944
]
Konstantin Shvachko commented on HDFS-941:
--
150 MB/sec throughput can be if your
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051007#comment-13051007
]
Kihwal Lee commented on HDFS-941:
-
Filer was not used. Cluster has 5 DNs with a separate NN.
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051048#comment-13051048
]
Hudson commented on HDFS-941:
-
Integrated in Hadoop-Hdfs-trunk #699 (See
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051216#comment-13051216
]
Tsz Wo (Nicholas), SZE commented on HDFS-941:
-
Hi Konstantin, don't you agree
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050609#comment-13050609
]
Konstantin Shvachko commented on HDFS-941:
--
I think it is reasonable to run tests
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050621#comment-13050621
]
Todd Lipcon commented on HDFS-941:
--
Konstantin:
Yes, everything runs on one node. It tests
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050622#comment-13050622
]
Kihwal Lee commented on HDFS-941:
-
Also with 128 MB file everything is in RAM, not sure what
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050623#comment-13050623
]
Todd Lipcon commented on HDFS-941:
--
Another thing to note is that TestDFSIO itself is a
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050726#comment-13050726
]
dhruba borthakur commented on HDFS-941:
---
My experience with TestDFSIO has been that
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050798#comment-13050798
]
Kihwal Lee commented on HDFS-941:
-
Following is 4 consecutive samples taken out in the
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050845#comment-13050845
]
Konstantin Shvachko commented on HDFS-941:
--
Kihwal, thanks for doing this.
For the
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049863#comment-13049863
]
stack commented on HDFS-941:
I reran tests, same three failed. I backed out my patch and the
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050181#comment-13050181
]
Konstantin Shvachko commented on HDFS-941:
--
-1 on committing this without the proof
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050197#comment-13050197
]
stack commented on HDFS-941:
@Konstantin
Convention is that RM says whats in a release and no
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050219#comment-13050219
]
Kihwal Lee commented on HDFS-941:
-
Perhaps it's confusing because this Jira is seen as
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050231#comment-13050231
]
Todd Lipcon commented on HDFS-941:
--
Ran the following benchmark to compare 0.22 before vs
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049278#comment-13049278
]
Todd Lipcon commented on HDFS-941:
--
Looks good to me. How'd the test run go?
Datanode
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049456#comment-13049456
]
stack commented on HDFS-941:
Bit odd. These failed when I ran all tests:
{code}
[junit]
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049457#comment-13049457
]
stack commented on HDFS-941:
Or, hang on...(240 minutes) and let me rerun these tests and see if
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049500#comment-13049500
]
Konstantin Shvachko commented on HDFS-941:
--
Could anybody please run DFSIO to make
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049515#comment-13049515
]
Todd Lipcon commented on HDFS-941:
--
Cos: do you have any reason to believe there would be?
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049526#comment-13049526
]
Todd Lipcon commented on HDFS-941:
--
oops, sorry Konstantin - didn't mean to call you Cos.
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049537#comment-13049537
]
Konstantin Shvachko commented on HDFS-941:
--
Yes in the previous
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13048579#comment-13048579
]
Kihwal Lee commented on HDFS-941:
-
HDFS-2071 was filed.
Datanode xceiver protocol should
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13048688#comment-13048688
]
Todd Lipcon commented on HDFS-941:
--
Hey Stack. I just looked over your patch for 0.22. The
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13048721#comment-13048721
]
stack commented on HDFS-941:
I should put it back. Give me a sec...
Datanode xceiver
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13048837#comment-13048837
]
Todd Lipcon commented on HDFS-941:
--
Hey Stack. I still don't think this is quite right --
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13048875#comment-13048875
]
Todd Lipcon commented on HDFS-941:
--
Yea, I think we should add back the blockReadFully
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13048979#comment-13048979
]
stack commented on HDFS-941:
I put back TestDataXceiver. It does this:
{code}
-
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047039#comment-13047039
]
Nigel Daley commented on HDFS-941:
--
+1 for 0.22.
Datanode xceiver protocol should allow
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047051#comment-13047051
]
Todd Lipcon commented on HDFS-941:
--
Cool, I will review and check in Stack's backport
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047763#comment-13047763
]
Kihwal Lee commented on HDFS-941:
-
One thing I noticed is, Socket.isConnected() cannot be
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047784#comment-13047784
]
Todd Lipcon commented on HDFS-941:
--
Hey Kihwal. Nice find. Mind filing a new JIRA for this?
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046375#comment-13046375
]
Todd Lipcon commented on HDFS-941:
--
Stack seems to have turned up some kind of out of sync
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046374#comment-13046374
]
stack commented on HDFS-941:
Dang. Did more testing (w/ Todd's help). I backported his patch
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046376#comment-13046376
]
Kihwal Lee commented on HDFS-941:
-
My test is still running on trunk, but so far I only see
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046384#comment-13046384
]
stack commented on HDFS-941:
@Kihwal You are on TRUNK and not 0.22? (I wonder if my backport
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046383#comment-13046383
]
stack commented on HDFS-941:
@Kihwal Are you doing any writing at the same time? (I was).
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046387#comment-13046387
]
Kihwal Lee commented on HDFS-941:
-
It's read-only and yes it's against TRUNK. I put 200 X
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046422#comment-13046422
]
Hadoop QA commented on HDFS-941:
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046526#comment-13046526
]
Kihwal Lee commented on HDFS-941:
-
Good catch and fix! I took a close look the open
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046583#comment-13046583
]
Kihwal Lee commented on HDFS-941:
-
Regarding duplicate connections, it makes sense because
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046643#comment-13046643
]
Kihwal Lee commented on HDFS-941:
-
I am retesting with Todd's patch and I don't see the
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046650#comment-13046650
]
stack commented on HDFS-941:
@Kihwal I see lots of those sendChunks exceptions but don't think
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046661#comment-13046661
]
Kihwal Lee commented on HDFS-941:
-
OK, I see it's from BlockSender.java:407. It really
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046700#comment-13046700
]
stack commented on HDFS-941:
+1 on commit for latest version of patch.
I've been running over
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046706#comment-13046706
]
Todd Lipcon commented on HDFS-941:
--
Regarding duplicate connections: also keep in mind that
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046716#comment-13046716
]
Kihwal Lee commented on HDFS-941:
-
They were pure readers and didn't write/report anything
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046722#comment-13046722
]
Todd Lipcon commented on HDFS-941:
--
Committed to trunk.
I'm 50/50 on whether this should
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046724#comment-13046724
]
Todd Lipcon commented on HDFS-941:
--
Also, big thanks to: bc for authoring the majority of
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046738#comment-13046738
]
stack commented on HDFS-941:
Todd, I'll buy you a beer to go 51/49 in favor of 0.22 commit. If
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046739#comment-13046739
]
Hadoop QA commented on HDFS-941:
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046744#comment-13046744
]
Eli Collins commented on HDFS-941:
--
Make that two beers (52/48?). I reviewed an earlier
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046756#comment-13046756
]
stack commented on HDFS-941:
Yeah, my 0.22 version fails against trunk (trunk already has guava,
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046755#comment-13046755
]
stack commented on HDFS-941:
So, that would leave 48 beers that I need to buy (And Nigel
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046148#comment-13046148
]
stack commented on HDFS-941:
+1 on commit. Have run this patch first in a light random read
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046151#comment-13046151
]
stack commented on HDFS-941:
Oh, just to say that I don't seem hdfs-level complaints in server
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046155#comment-13046155
]
stack commented on HDFS-941:
This patch should be applied to hadoop 0.22. It'd be an incentive
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046159#comment-13046159
]
Todd Lipcon commented on HDFS-941:
--
Stack, thanks a million for the cluster testing and
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046162#comment-13046162
]
stack commented on HDFS-941:
On occasion I see these new additions to the datanode log:
{code}
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046175#comment-13046175
]
Todd Lipcon commented on HDFS-941:
--
Hey Stack, are you sure you got the latest patch
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046182#comment-13046182
]
stack commented on HDFS-941:
OK. Looks like I was running the just-previous. Let me redo
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046183#comment-13046183
]
stack commented on HDFS-941:
Or, hang on, let me indeed verify 0.22 has this minus the 941
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046212#comment-13046212
]
Kihwal Lee commented on HDFS-941:
-
I will try putting some load in a cluster with this patch
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046234#comment-13046234
]
stack commented on HDFS-941:
New patch looks good (nice comment on why NODELAY). Let me test
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046311#comment-13046311
]
Hadoop QA commented on HDFS-941:
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046330#comment-13046330
]
Todd Lipcon commented on HDFS-941:
--
I'd like to commit this tomorrow so long as Stack and
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13045432#comment-13045432
]
Kihwal Lee commented on HDFS-941:
-
You think 16 a good number for the socket cache (doesn't
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13045033#comment-13045033
]
Hadoop QA commented on HDFS-941:
+1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13045278#comment-13045278
]
stack commented on HDFS-941:
I took a look at patch. It looks good to me. Minor comments
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13044698#comment-13044698
]
Todd Lipcon commented on HDFS-941:
--
oops, the last line of my benchmark results got
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13044715#comment-13044715
]
Hadoop QA commented on HDFS-941:
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032194#comment-13032194
]
Jason Rutherglen commented on HDFS-941:
---
I'm seeing many errors trying to apply
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13023101#comment-13023101
]
Todd Lipcon commented on HDFS-941:
--
Looks pretty good, and I looped
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021837#comment-13021837
]
Todd Lipcon commented on HDFS-941:
--
TestFileConcurrentReader has been failing
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021862#comment-13021862
]
sam rash commented on HDFS-941:
---
The last failure I saw with this test was basically unrelated
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13018635#comment-13018635
]
bc Wong commented on HDFS-941:
--
I'll take a look at the TestFileConcurrentReader failure.
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13018471#comment-13018471
]
Hadoop QA commented on HDFS-941:
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13018472#comment-13018472
]
Tsz Wo (Nicholas), SZE commented on HDFS-941:
-
Hi bc, seems that Jenkins
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13018485#comment-13018485
]
bc Wong commented on HDFS-941:
--
Thanks Nicholas! I generated the wrong patch format,
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13018570#comment-13018570
]
Tsz Wo (Nicholas), SZE commented on HDFS-941:
-
You are welcome. Just have
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13018589#comment-13018589
]
Hadoop QA commented on HDFS-941:
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010814#comment-13010814
]
Kihwal Lee commented on HDFS-941:
-
+1 The patch looks good. I was unsure about the new
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010879#comment-13010879
]
stack commented on HDFS-941:
+1 on commit. Patch looks great though a bit hard to read because
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009167#comment-13009167
]
Kihwal Lee commented on HDFS-941:
-
Nice work! I performed a basic test and got results
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12996836#comment-12996836
]
Hadoop QA commented on HDFS-941:
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12866496#action_12866496
]
Todd Lipcon commented on HDFS-941:
--
I ran some benchmarks again tonight using YCSB.
I
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12866519#action_12866519
]
Todd Lipcon commented on HDFS-941:
--
I'd like to hold off on this just a bit longer yet - I'm
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1284#action_1284
]
sam rash commented on HDFS-941:
---
todd: wow, those benchmarks do look impressive! do we have
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12866680#action_12866680
]
sam rash commented on HDFS-941:
---
two other comments:
1. the number of sockets per address is
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12866456#action_12866456
]
sam rash commented on HDFS-941:
---
+1 for the idea of caching sockets, but I have some
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12862854#action_12862854
]
bc Wong commented on HDFS-941:
--
The variance is large on the tests. But they show that the patch
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12855205#action_12855205
]
bc Wong commented on HDFS-941:
--
I replaced the size-of-one cache with a more generic cache,
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847244#action_12847244
]
bc Wong commented on HDFS-941:
--
Thanks for the review, Todd. I'll add more tests, and look into
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847117#action_12847117
]
Todd Lipcon commented on HDFS-941:
--
Style notes:
- in BlockReader:
{code}
+
[
https://issues.apache.org/jira/browse/HDFS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12846499#action_12846499
]
Hadoop QA commented on HDFS-941:
-1 overall. Here are the results of testing the latest
1 - 100 of 101 matches
Mail list logo
